----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12180/ -----------------------------------------------------------
(Updated July 3, 2013, 12:25 a.m.) Review request for cloudstack, Chip Childers, Devdeep Singh, Kelven Yang, and Sateesh Chodapuneedi. Changes ------- Latest patch on top of master incorporating Sateesh and Prasanna's review comments. Bugs: CLOUDSTACK-3110 Repository: cloudstack-git Description ------- Fixing an NPE when an attempt is made to add a primary datastore by providing an unreachable/nonexistent datastore/host. Diffs (updated) ----- engine/storage/src/org/apache/cloudstack/storage/datastore/DataStoreManagerImpl.java 71df262 engine/storage/volume/src/org/apache/cloudstack/storage/datastore/manager/PrimaryDataStoreProviderManagerImpl.java 06b54e0 Diff: https://reviews.apache.org/r/12180/diff/ Testing ------- With fix in place, an attempt to add an invalid primary datastore will fail with a GUI error dialog instead of failing silently with an NPE in the mgmt server log. File Attachments ---------------- Refactored patch for master-6-17-stable branch https://reviews.apache.org/media/uploaded/files/2013/06/29/0001-CLOUDSTACK-3110-VMWARE-NPE-while-adding-primary-stor.patch Thanks, Venkata Siva Vijayendra Bhamidipati
