Review Request 14200: CLOUDSTACK-4686: Fixed volume limit for domain

2013-09-18 Thread Girish Shilamkar
Repository: cloudstack-git Description --- CLOUDSTACK-4686: Fixed volume limit for domain Diffs - test/integration/component/test_resource_limits.py 833723c Diff: https://reviews.apache.org/r/14200/diff/ Testing --- Thanks, Girish Shilamkar

Review Request 14230: Storage type was set to local due to which tests failed.

2013-09-19 Thread Girish Shilamkar
. Repository: cloudstack-git Description --- Storage type was set to local due to which tests failed. Diffs - test/integration/component/test_reset_ssh_keypair.py 8b499d0 Diff: https://reviews.apache.org/r/14230/diff/ Testing --- Thanks, Girish Shilamkar

Review Request 14335: CLOUDSTACK-4262: Fix TestVPCNetworkGc.test_01_wait_network_gc

2013-09-25 Thread Girish Shilamkar
: https://reviews.apache.org/r/14335/diff/ Testing --- Thanks, Girish Shilamkar

Virtual Router reachability

2013-09-29 Thread Girish Shilamkar
Hello, Egress rules tests rely on accessing virtual router VR after creating a network. I have often seen that VR is not immediately accessible. A ssh to VR fails, I think it takes a while for the network to come up and VR can be ssh'd. This happens even though the VR is in "Running" state. So

Re: Virtual Router reachability

2013-09-30 Thread Girish Shilamkar
, Marcus Sorensen wrote: > In the past, with KVM, the agent doesn't show the router as running until > it can ssh to it. You can watch the agent poll if it is debug logging. Does > this issue not apply to KVM, or is it a regression? > On Sep 29, 2013 11:38 PM, "Girish Shilamka

Re: Virtual Router reachability

2013-09-30 Thread Girish Shilamkar
router boot up. > Take the max interval as 10 times of boot up time. > Repeat the ssh for each boot up interval. > > Thanks, > Jayapal > > On 30-Sep-2013, at 1:38 PM, Girish Shilamkar > wrote: > >> Marcus, >> >> I guess it no longer applies to even KVM

Review Request 14469: CLOUDSTACK-4637: Fix failures in test_egress_fw_rules.py

2013-10-03 Thread Girish Shilamkar
budumuru. Bugs: CLOUDSTACK-4637 Repository: cloudstack-git Description --- Add logic to wait for router to boot. Diffs - test/integration/component/test_egress_fw_rules.py 5c18f9c Diff: https://reviews.apache.org/r/14469/diff/ Testing --- Thanks, Girish Shilamkar

Re: Review Request 14335: CLOUDSTACK-4262: Fix TestVPCNetworkGc.test_01_wait_network_gc

2013-10-06 Thread Girish Shilamkar
for network gc LB rules should be cleared. Added that check instead of router being in stopped state. Diffs (updated) - test/integration/component/test_vpc_network.py 970a625 Diff: https://reviews.apache.org/r/14335/diff/ Testing --- Thanks, Girish Shilamkar

Re: Review Request 14469: CLOUDSTACK-4637: Fix failures in test_egress_fw_rules.py

2013-10-07 Thread Girish Shilamkar
value remains same i.e. 100. - Girish --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14469/#review26761 --- On Oct. 3, 2013, 2:33 p.m., Giris

Review Request 14556: CLOUDSTACK-4766: Add timeout if vm does not reach running state

2013-10-09 Thread Girish Shilamkar
onError: The virtual machine 974d1275-b747-441c-83b2-1795de4d87df failed to start even after 10 minutes ------ Thanks, Girish Shilamkar

Review Request 14557: CLOUDSTACK-4747: Rename testcase name to use lesser characters

2013-10-09 Thread Girish Shilamkar
Description --- Renamed testcase name and also initialised _cleanup so that it does not break on non-NS Cloudstack setup. Diffs - test/integration/component/test_netscaler_nw_off.py 3139257 Diff: https://reviews.apache.org/r/14557/diff/ Testing --- Thanks, Girish Shilamkar

Re: Review Request 14556: CLOUDSTACK-4766: Add timeout if vm does not reach running state

2013-10-09 Thread Girish Shilamkar
d output. - Girish --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14556/#review26816 --- On Oct. 9, 2013, 9:50 a.m., Girish Shilam

Re: Review Request 13701: Automation Tests for HA Proxy Stickiness

2013-10-11 Thread Girish Shilamkar
-- Ran 11 tests in 2154.059s OK Thanks, Girish Shilamkar

Re: Review Request 14557: CLOUDSTACK-4747: Rename testcase name to use lesser characters

2013-10-11 Thread Girish Shilamkar
3139257 Diff: https://reviews.apache.org/r/14557/diff/ Testing --- Thanks, Girish Shilamkar

Re: [MERGE] marvin-refactor to master

2013-10-12 Thread Girish Shilamkar
Hello Prasanna, +1 to the new marvin architecture. The proposed architecture will make marvin lot more stable, remove defining data in code and will be easier to add testcases. Can we have a run in jenkins.cloudstack.org to ensure that the existing tests won't break with new marvin ? How much

Re: Http connection failure in marvin

2013-10-15 Thread Girish Shilamkar
I have been hitting this issue quite often since couple of weeks. I just switched the management server and so far haven't seen it. Maybe updating httplib might help. Regards, Girish On 16-Oct-2013, at 11:04 AM, Prasanna Santhanam wrote: > On Wed, Oct 16, 2013 at 05:11:46AM +

Re: Http connection failure in marvin

2013-10-16 Thread Girish Shilamkar
Lets track this issue here https://issues.apache.org/jira/browse/CLOUDSTACK-4846 Regards, Girish On 16-Oct-2013, at 11:30 AM, Prasanna Santhanam wrote: > httplib is used indirectly through requests. I'd try reproduce this > by throttling 1000s of requests through a single mgmt server. It is > i

Http connection failure in marvin

2013-10-16 Thread Girish Shilamkar
Hello, Sometimes while running automation testcases tests just fail with following error: ConnectionError: HTTPConnectionPool(host='10.147.59.65', port=8080): Max retries exceeded with url: /client/api? apiKey=lcgWQ9XrjyIyPjs

Re: Review Request 14469: CLOUDSTACK-4637: Fix failures in test_egress_fw_rules.py

2013-10-16 Thread Girish Shilamkar
: Master failover ... ok -- Ran 26 tests in 15127.540s OK Thanks, Girish Shilamkar

Re: Review Request 14334: CLOUDSTACK 4705: Fixed domain memory limits test cases

2013-10-16 Thread Girish Shilamkar
> On Oct. 8, 2013, 11:14 a.m., abhinav roy wrote: > > Ship It! Can someone commit this patch. - Girish --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14334/#review26770 -

Re: Http connection failure in marvin

2013-10-16 Thread Girish Shilamkar
cause for this issue. Adding complete server calls and debug information > will help to debug more i believe? > > http://stackoverflow.com/questions/1767934/why-am-i-getting-this-error-in-python-httplib > > Check above and you can get more information for this issue to delve further. >

Review Request 14872: CLOUDSTACK-4934: Rename Limit resources tests so that they have unique names

2013-10-23 Thread Girish Shilamkar
test/integration/component/test_mm_project_limits.py PRE-CREATION Diff: https://reviews.apache.org/r/14872/diff/ Testing --- Thanks, Girish Shilamkar

Review Request 14873: CLOUDSTACK-4934: Rename Limit resources tests so that they have unique names

2013-10-23 Thread Girish Shilamkar
/component/test_mm_project_limits.py PRE-CREATION Diff: https://reviews.apache.org/r/14873/diff/ Testing --- Thanks, Girish Shilamkar

Re: Review Request 14319: CLOUDSTACK 2238: Automation - Non Contiguous VLAN Ranges

2013-10-23 Thread Girish Shilamkar
On Oct. 23, 2013, 9:08 a.m., Gaurav Aradhye wrote: > > The naming of the tests should be improved. test_01/02/03 doesn't tell much > > about the test. Also is the ordering strictly required? Can I reorder the > > tests and still expect the tests to pass? If not, we should remove the 01 , > > 0

Re: [ANNOUNCE] New Committer: Shilamkar, Girish

2013-10-24 Thread Girish Shilamkar
gt;> From: Prasanna Santhanam [mailto:t...@apache.org] >> Sent: Wednesday, October 23, 2013 4:08 PM >> To: CloudStack Dev >> Subject: [ANNOUNCE] New Committer: Shilamkar, Girish >> >> The Project Management Committee (PMC) for Apache CloudStack has asked >

Re: Review Request 14459: CLOUDSTACK-2243: Add automation tests for VMs base image update faclity

2013-10-27 Thread Girish Shilamkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14459/#review27595 --- Ship it! Ship It! - Girish Shilamkar On Oct. 28, 2013, 6:02 a.m

Re: Review Request 14199: Adding missing test cases: Snapshots Improvement

2013-10-27 Thread Girish Shilamkar
automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14199/ > --- > > (Updated Oct. 28, 2013, 5:53 a.m.) > > > Review request for cloudstack, Girish Shilamkar and suresh sadhu. > >

Re: Review Request 15082: CLOUDSTACK-2237: Automation tests for Security Group Isolation in Advance Zone

2013-10-30 Thread Girish Shilamkar
://reviews.apache.org/r/15082/diff/ Testing (updated) --- Yes Thanks, Girish Shilamkar

Review Request 15082: CLOUDSTACK-2237: Automation tests for Security Group Isolation in Advance Zone

2013-10-30 Thread Girish Shilamkar
--- Thanks, Girish Shilamkar

Re: Review Request 15082: CLOUDSTACK-2237: Automation tests for Security Group Isolation in Advance Zone

2013-10-30 Thread Girish Shilamkar
://reviews.apache.org/r/15082/diff/ Testing --- Yes Thanks, Girish Shilamkar

Re: Review Request 15082: CLOUDSTACK-2237: Automation tests for Security Group Isolation in Advance Zone

2013-10-30 Thread Girish Shilamkar
/ Testing --- Yes Thanks, Girish Shilamkar

Review Request 15115: CLOUDSTACK-4335: Delete test_deployVmSharedNetworkWithoutIpRange

2013-10-31 Thread Girish Shilamkar
error insufficient capacity. So remove this test which is invalid. Diffs - test/integration/component/test_shared_network_offering.py 85f0892 Diff: https://reviews.apache.org/r/15115/diff/ Testing --- Thanks, Girish Shilamkar

Re: Review Request 15127: CLOUDSTACK-4495: Fixed TestResetSSHKeyUserRights.test_01_reset_keypair_normal_user

2013-10-31 Thread Girish Shilamkar
tps://reviews.apache.org/r/15127/#comment54310> If we are specifying vmid then no need to specify listall=True. Rest looks good. - Girish Shilamkar On Oct. 31, 2013, 12:41 p.m., Gaurav Aradhye wrote: > > --- > This is a

Re: Review Request 15127: CLOUDSTACK-4495: Fixed TestResetSSHKeyUserRights.test_01_reset_keypair_normal_user

2013-10-31 Thread Girish Shilamkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15127/#review27906 --- Ship it! Ship It! - Girish Shilamkar On Oct. 31, 2013, 1:48 p.m

Review Request 15132: CLOUDSTACK 4256: Fixed Shared Network test cases using random private ips for shared networks

2013-10-31 Thread Girish Shilamkar
test_createSharedNetwork_usedVlan (test_shared_networks.TestSharedNetworks) Thanks, Girish Shilamkar

Re: Review Request 14874: Marvin Plugin Changes: Adding timestamp and timetaken in seconds for a given testcase run to console

2013-11-01 Thread Girish Shilamkar
> On Oct. 24, 2013, 9:24 a.m., Prasanna Santhanam wrote: > > 0780604 master Shouldn't this fix also go to 4.2 branch ? - Girish --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14874/#review27

Re: Review Request 14874: Marvin Plugin Changes: Adding timestamp and timetaken in seconds for a given testcase run to console

2013-11-01 Thread Girish Shilamkar
to 4.2 i > believe. > > Santhosh > ____ > From: Girish Shilamkar [nore...@reviews.apache.org] on behalf of Girish > Shilamkar [gir...@clogeny.com] > Sent: Friday, November 01, 2013 3:07 AM > To: Prasanna Santhanam > Cc: Santhos

Re: Review Request 14874: Marvin Plugin Changes: Adding timestamp and timetaken in seconds for a given testcase run to console

2013-11-01 Thread Girish Shilamkar
rs/santhoshe/ > > Right now it seems that everything has been reviewed, so Santosh will need to > submit his patches through review board and assign you as reviewer. > > Hope that helps, > > -sebastien > > > On Nov 1, 2013, at 3:37 AM, Girish Shilamkar wrote: >

Re: Review Request 15307: Increasing the timeout values to 600 seconds from 300 seconds

2013-11-07 Thread Girish Shilamkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15307/#review28360 --- Ship it! Ship It! - Girish Shilamkar On Nov. 7, 2013, 10:23 a.m

Re: Review Request 15305: CLOUDSTACK-4996: Resolved gateway accessibility issue.

2013-11-07 Thread Girish Shilamkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15305/#review28362 --- Ship it! Ship It! - Girish Shilamkar On Nov. 7, 2013, 10:22 a.m

Re: Review Request 15342: CLOUDSTACK-4648: Fixed Snapshots test cases

2013-11-07 Thread Girish Shilamkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15342/#review28507 --- Ship it! Ship It! - Girish Shilamkar On Nov. 8, 2013, 7:07 a.m

Re: Review Request 14874: Marvin Plugin Changes: Adding timestamp and timetaken in seconds for a given testcase run to console

2013-11-07 Thread Girish Shilamkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14874/#review28510 --- 4.2: ae852adabb70f43d6d349dd4ab56dc3116e10aed - Girish Shilamkar

Re: Review Request 15021: Fixed Bug: 4899 : Added Configuration Support to Marvin.

2013-11-08 Thread Girish Shilamkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15021/#review28512 --- 4.2: e7b6ee10eda85a90c594c9de5d36cc062e069576 - Girish Shilamkar

Re: Review Request 15175: Added a verifyElementInList utility function

2013-11-08 Thread Girish Shilamkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15175/#review28513 --- 4.2: b18e730108e6a24e00c372e3c56c655ff51106ba - Girish Shilamkar

Re: Review Request 14648: Added few changes related to 4870

2013-11-08 Thread Girish Shilamkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14648/#review28520 --- 4.2: fba874120bb40ddeceacbc7ef51217f34d3749de - Girish Shilamkar

Re: Review Request 14595: Adding https support to marvin

2013-11-08 Thread Girish Shilamkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14595/#review28521 --- 4.2: 6e1821f585df5c643873ab0ce1e7d91d1d94f00d - Girish Shilamkar

Re: Review Request 14869: Added changes related to bug 4920 and few code clean up

2013-11-08 Thread Girish Shilamkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14869/#review28524 --- 4.2: 87983e09e21c51dbef6b2a8a0252b039e32915ad - Girish Shilamkar

Re: Review Request 14875: Fixed few pep8 compliant issues

2013-11-08 Thread Girish Shilamkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14875/#review28525 --- 4.2: 3a31a7e6 - Girish Shilamkar On Oct. 23, 2013, 1:57 p.m

Re: Review Request 14925: Added few misc changes to marvin

2013-11-08 Thread Girish Shilamkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14925/#review28526 --- 4.2: fba874120bb40ddeceacbc7ef51217f34d3749de - Girish Shilamkar

Re: Review Request 15208: Added fix for bug 5032. Provides custom assert facility to test features. Added the new assert to cloudstackTestCase

2013-11-08 Thread Girish Shilamkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15208/#review28527 --- 4.2: c76da53123f4130ac59bdf112171bc2e39af91d4 - Girish Shilamkar

Re: Review Request 15341: Fix-for-5099: Utils.py-has-wrong-reference, cleaned it. As well added Uniform naming convention

2013-11-08 Thread Girish Shilamkar
different file. - Girish Shilamkar On Nov. 8, 2013, 7:16 a.m., Santhosh Edukulla wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 15341: Fix-for-5099: Utils.py-has-wrong-reference, cleaned it. As well added Uniform naming convention

2013-11-08 Thread Girish Shilamkar
> On Nov. 8, 2013, 10:11 a.m., Girish Shilamkar wrote: > > Santhosh, > > > > Please update the diff instead of uploading them as different file. Also the commit header should be "CLOUDSTACK-5099: " This will ensure that the jira ticket also gets

Re: Review Request 14648: Added few changes related to 4870

2013-11-08 Thread Girish Shilamkar
> On Nov. 8, 2013, 9:15 a.m., Girish Shilamkar wrote: > > 4.2: fba874120bb40ddeceacbc7ef51217f34d3749de > > Sebastien Goasguen wrote: > if these patches apply to master, can you make sure to also apply to > master at the same time. thanks They were already applied to

Re: Review Request 15395: Fixed few test case failures

2013-11-10 Thread Girish Shilamkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15395/#review28638 --- Ship it! Ship It! - Girish Shilamkar On Nov. 10, 2013, 7:28 p.m

Re: Review Request 13841: Missing tests from QA repo to ASF - 3 tests from test_vmware_drs.py

2013-11-12 Thread Girish Shilamkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13841/#review28783 --- Ship it! Ship It! - Girish Shilamkar On Oct. 30, 2013, 7:01 a.m

Re: Review Request 14058: Including tests for VPC VM Lifecycle on Tagged hosts

2013-11-12 Thread Girish Shilamkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14058/#review28782 --- Ship it! Ship It! - Girish Shilamkar On Nov. 8, 2013, 1:48 p.m

Re: Review Request 15453: CLOUDSTACK-5146: Removed tags basic and sg from test case TestRouterRestart.test_01_restart_network_cleanup which should not be run on basic zone setup

2013-11-12 Thread Girish Shilamkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15453/#review28787 --- Ship it! Ship It! - Girish Shilamkar On Nov. 12, 2013, 1:09 p.m

Re: Review Request 15454: CLOUDSTACK-5147: Removing basic and sg tag from the test case which should not be run on basic zone setup

2013-11-12 Thread Girish Shilamkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15454/#review28793 --- Ship it! Ship It! - Girish Shilamkar On Nov. 12, 2013, 1:39 p.m

Re: Review Request 15475: CLOUDSTACK-5154: Fixed test script issue related to failure in creating snapshot from volume

2013-11-13 Thread Girish Shilamkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15475/#review28796 --- Ship it! Ship It! - Girish Shilamkar On Nov. 13, 2013, 11:48

Re: Review Request 15478: CLOUDSTACK-5156: Fixed test script issue related to detach volume

2013-11-13 Thread Girish Shilamkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15478/#review28805 --- Ship it! Ship It! - Girish Shilamkar On Nov. 13, 2013, 2:06 p.m

Re: Review Request 15478: CLOUDSTACK-5156: Fixed test script issue related to detach volume

2013-11-13 Thread Girish Shilamkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15478/#review28803 --- Ship it! Ship It! - Girish Shilamkar On Nov. 13, 2013, 2:06 p.m

Re: Review Request 13841: Missing tests from QA repo to ASF - 3 tests from test_vmware_drs.py

2013-11-13 Thread Girish Shilamkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13841/#review28810 --- Committed to 4.2, 4.3 and master - Girish Shilamkar On Oct. 30

Re: Review Request 14058: Including tests for VPC VM Lifecycle on Tagged hosts

2013-11-13 Thread Girish Shilamkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14058/#review28811 --- Committed to 4.2, 4.3 and master. - Girish Shilamkar On Nov. 8

Re: New Committer: Sanjeev Neelarapu

2013-11-13 Thread Girish Shilamkar
Congrats Sanjeev !! Regards, Girish On 14-Nov-2013, at 12:11 PM, Suresh Sadhu wrote: > Congrats Sanjeev > > -Original Message- > From: Sailaja Mada [mailto:sailaja.m...@citrix.com] > Sent: 14 November 2013 11:38 > To: dev@cloudstack.apache.org > Subject: RE: New Committer: Sanjeev Nee

Re: Review Request 15513: CLOUDSTACK-5166: Fixed test script issue related to egress rules

2013-11-14 Thread Girish Shilamkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15513/#review28935 --- Ship it! Ship It! - Girish Shilamkar On Nov. 14, 2013, 11:46

Re: Review Request 15513: CLOUDSTACK-5166: Fixed test script issue related to egress rules

2013-11-14 Thread Girish Shilamkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15513/#review28937 --- Ship it! Committed to 4.2, 4.3 and master - Girish Shilamkar

Re: Review Request 15514: CLOUDSTACK-5168: Fixed test script issue related to SSH command

2013-11-14 Thread Girish Shilamkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15514/#review28940 --- Ship it! Committed to 4.2, 4.3 and master - Girish Shilamkar On

Re: Review Request 15516: CLOUDSTACK-5169: Egress rules - Improved assertion code related to SSH to avoid assertion error

2013-11-14 Thread Girish Shilamkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15516/#review28944 --- Ship it! Committed to 4.2, 4.3 and master - Girish Shilamkar

Re: Review Request 15570: CLOUDSTACK-5180: Increasing the timeout for uploading volume

2013-11-15 Thread Girish Shilamkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15570/#review28954 --- Ship it! COmmitted to 4.2, 4.3 and master - Girish Shilamkar On

Re: Review Request 15452: CLOUDSTACK-5147: Removing basic and sg tags from test case which is invalid for basic zone

2013-11-15 Thread Girish Shilamkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15452/#review28958 --- Ship it! Committed to 4.2, 4.3 and master - Girish Shilamkar On

Re: Review Request 15569: CLOUDSTACK-5179: Fixed test script issue related to detach volume

2013-11-15 Thread Girish Shilamkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15569/#review28963 --- Ship it! COmmitted to 4.2, 4.3 and master - Girish Shilamkar On

Re: Review Request 15610: CLOUDSTACK-5185: test_egress_fw_rules - failed the test case if vm deployment failed instead of going on executing rest of the test case

2013-11-16 Thread Girish Shilamkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15610/#review29010 --- Ship it! Committed to 4.2, 4.3 and master - Girish Shilamkar

Re: Review Request 15610: CLOUDSTACK-5185: test_egress_fw_rules - failed the test case if vm deployment failed instead of going on executing rest of the test case

2013-11-16 Thread Girish Shilamkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15610/#review29011 --- Ship it! Committed to 4.2, 4.3 and master - Girish Shilamkar

Re: Review Request 15611: CLOUDSTACK-5186: Increasing the waiting time for router to come up

2013-11-16 Thread Girish Shilamkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15611/#review29015 --- Ship it! Committed to 4.2, 4.3 and master - Girish Shilamkar

Re: Review Request 15645: CLOUDSTACK-5194: portable ip - Improving cleanup code to avoid cascading failures

2013-11-18 Thread Girish Shilamkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15645/#review29101 --- Ship it! Committed to 4.2, 4.3 and master - Girish Shilamkar On

Marvin listPortForwardingRules API

2013-05-20 Thread Girish Shilamkar
Hello Prasanna, Tests using listportforwardingrules are failing with latest marvin. listportforwardingrules failed, due to: errorCode: 431, errorText:Unable to execute API command listportforwardingrules due to invalid value. Invalid parameter id value=c9373d55-3d01-480d-98dc-2365d3927378 due to

Re: Review Request: Automation: Add testcases for Affinity/Anti-Affinity Rules

2013-05-21 Thread Girish Shilamkar
/marvin/marvin/integration/lib/base.py ec1c34e Diff: https://reviews.apache.org/r/11067/diff/ Testing --- The tests which are not skipped are working. Thanks, Girish Shilamkar

Re: Review Request: Automation tests to qualify user provided hostname feature.

2013-05-21 Thread Girish Shilamkar
one? Should the setting be > > false? It looks like you are testing for the negative result? > > Girish Shilamkar wrote: > The flag is true but we don't provide the hostname so it should pick up > the configured instance name. There are different set of tests where fla

Re: Review Request: Automation tests to qualify user provided hostname feature.

2013-05-21 Thread Girish Shilamkar
hostname for the instance without internal name This addresses bug CLOUDSTACK-778. Diffs (updated) - test/integration/component/test_custom_hostname.py PRE-CREATION Diff: https://reviews.apache.org/r/10793/diff/ Testing --- Tested and works fine. Thanks, Girish Shilamkar

Review Request: Fix unresolved max_value in test_project_limits.py

2013-05-21 Thread Girish Shilamkar
unresolved max_value in test_project_limits.py This addresses bug CLOUDSTACK-2472. Diffs - test/integration/component/test_project_limits.py 17ddfc6 Diff: https://reviews.apache.org/r/11303/diff/ Testing --- Thanks, Girish Shilamkar

Review Request: Fix a typo in test_vpc_network.py

2013-05-21 Thread Girish Shilamkar
a typo in test_vpc_network.py This addresses bug CLOUDSTACK-2473. Diffs - test/integration/component/test_vpc_network.py dc53585 Diff: https://reviews.apache.org/r/11304/diff/ Testing --- Thanks, Girish Shilamkar

Review Request: CS-2474: Remove garbage code which was added while resolving merge conflicts.

2013-05-21 Thread Girish Shilamkar
--- Remove garbage code which was added while resolving merge conflicts. This addresses bug CLOUDSTACK-2474. Diffs - test/integration/component/test_vpc_routers.py 763a4cb Diff: https://reviews.apache.org/r/11306/diff/ Testing --- Thanks, Girish Shilamkar

Re: Review Request: CS-2474: Remove garbage code which was added while resolving merge conflicts.

2013-05-21 Thread Girish Shilamkar
Santhanam. Description --- Remove garbage code which was added while resolving merge conflicts. This addresses bug CLOUDSTACK-2474. Diffs - test/integration/component/test_vpc_routers.py 763a4cb Diff: https://reviews.apache.org/r/11306/diff/ Testing --- Thanks, Girish

assignVirtualMachine API fails

2013-05-22 Thread Girish Shilamkar
Hello, While writing automation tests Changing account membership for VMs, assignVirtualMachine API fails with errorCode: 530, errorText:Failed to move vm Remove the Port forwarding rules for this VM before assigning to another user. This happens even though vm wasn't set any PF rule. We saw thi

Review Request: CLOUDSTACK-2577: Fix exception handling for listPortForwarding API

2013-05-22 Thread Girish Shilamkar
--- listPortForwarding API returns an exception if the PF is deleted. Changed testcases to handle this exception. This addresses bug CLOUDSTACK-2577. Diffs - test/integration/smoke/test_network.py 4a7bb44 Diff: https://reviews.apache.org/r/11328/diff/ Testing --- Thanks, Girish

Re: assignVirtualMachine API fails

2013-05-22 Thread Girish Shilamkar
is the expected behavior. > > ** ** > > Thanks, > > Likitha **** > > ** ** > > *From:* Girish Shilamkar [mailto:gir...@clogeny.com] > *Sent:* Wednesday, May 22, 2013 12:40 PM > *To:* dev@cloudstack.apache.org > *Cc:* Likitha Shetty; Parth Jagirdar >

Re: Review Request: Automation: Add testcases for Affinity/Anti-Affinity Rules

2013-05-29 Thread Girish Shilamkar
, Girish Shilamkar

Re: Review Request: Automation: Add testcases for Affinity/Anti-Affinity Rules

2013-05-29 Thread Girish Shilamkar
/test_affinity_groups.py PRE-CREATION Diff: https://reviews.apache.org/r/11067/diff/ Testing --- The tests which are not skipped are working. Thanks, Girish Shilamkar

Re: Review Request: Automation: Add testcases for Affinity/Anti-Affinity Rules

2013-06-10 Thread Girish Shilamkar
/test_affinity_groups.py PRE-CREATION Diff: https://reviews.apache.org/r/11067/diff/ Testing --- The tests which are not skipped are working. Thanks, Girish Shilamkar

Review Request: CLOUDSATCK-1758: Update ssh key location for vmware

2013-06-18 Thread Girish Shilamkar
--- Update ssh key location for vmware This addresses bug CLOUDSTACK-1758. Diffs - tools/marvin/marvin/integration/lib/utils.py 6892c41 Diff: https://reviews.apache.org/r/11956/diff/ Testing --- Thanks, Girish Shilamkar

Review Request: CLOUDSTACK-1758: SSVM tests failed due to ssh error

2013-06-19 Thread Girish Shilamkar
--- Additional fixes were needed which were found during further testing. This addresses bug CLOUDSTACK-1758. Diffs - test/integration/smoke/test_ssvm.py d637f96 Diff: https://reviews.apache.org/r/11962/diff/ Testing --- Thanks, Girish Shilamkar

Re: Review Request: CLOUDSTACK-1758: SSVM tests failed due to ssh error

2013-06-19 Thread Girish Shilamkar
/diff/ Testing --- Thanks, Girish Shilamkar

Re: Review Request 11067: Automation: Add testcases for Affinity/Anti-Affinity Rules

2013-06-26 Thread Girish Shilamkar
-CREATION tools/marvin/marvin/integration/lib/base.py 503ed64 Diff: https://reviews.apache.org/r/11067/diff/ Testing --- The tests which are not skipped are working. Thanks, Girish Shilamkar

Re: Test Result for test-smoke-matrix #559

2013-07-02 Thread Girish Shilamkar
Hello Prasanna, While adding rest of the affinity rules tests I had removed affinity rules test from smoke. But while going through various iterations on the review board this hunk to remove test from smoke was dropped. The same test is now included in component. I think we should remove test_a

Review Request 12241: CLOUDSTACK-3339: Add Vlan as true in network offering.

2013-07-03 Thread Girish Shilamkar
-git Description --- Tests in test_network_offering.py failed as Vlan option was false. Changed it to true. Diffs - test/integration/component/test_network_offering.py a3e87f6 Diff: https://reviews.apache.org/r/12241/diff/ Testing --- Thanks, Girish Shilamkar

Verifying Load Balancer logic

2013-07-04 Thread Girish Shilamkar
Hello, Some of the BVT test cases verify if load balancing rule set to round robin is working or not. It is seen that often LBing is not perfect round robin. If first request goes to one vm the next does not always go to second, when there are just two vms added to LB rule. I vaguely recall di

Query about moving vms across domains

2013-07-08 Thread Girish Shilamkar
Hello Likitha, Some of the regression tests for changing domain membership failed. http://jenkins.buildacloud.org/job/test-regression-matrix/34/suite=test_assign_vm/testReport/ Could you please confirm my following assumptions: A domain admin can move vms only amongst its subdomains or between t

Re: Query about moving vms across domains

2013-07-08 Thread Girish Shilamkar
the move should be successful and not raise an exception. > > Thanks, > Likitha > > From: Girish Shilamkar [mailto:gir...@clogeny.com] > Sent: Monday, July 08, 2013 5:28 PM > To: Likitha Shetty > Cc: dev@cloudstack.apache.org > Subject: Query about moving vms across d

Shared networks without IP range.

2013-07-08 Thread Girish Shilamkar
Hello, In order to create shared network StartIp/endIp/gateway/netmask are required. I am looking at an old test case which creates shared network without IP range and deploys vm in it. It of course fails as IP range is required while creating shared network. Has anything related to shared netw

Review Request 12497: CLOUDSTACK-3340: Removed test_deployVmSharedNetworkWithoutIpRange

2013-07-11 Thread Girish Shilamkar
/component/test_network_offering.py a3e87f6 Diff: https://reviews.apache.org/r/12497/diff/ Testing --- Thanks, Girish Shilamkar

  1   2   3   >