Re: Review Request 22232: Fix for test_01_create_volume to use the correct volume name for KVM

2014-06-10 Thread Alex Brett
against a KVM host. Thanks, Alex Brett

Review Request 22512: CLOUDSTACK-6862 Don't run vGPU tests on KVM or in the BVTs

2014-06-12 Thread Alex Brett
tegration/smoke/test_deploy_vgpu_enabled_vm.py fa33bdc Diff: https://reviews.apache.org/r/22512/diff/ Testing --- Tested against a KVM host to ensure the skip logic kicks in. Thanks, Alex Brett

Re: Review Request 22512: CLOUDSTACK-6862 Don't run vGPU tests on KVM or in the BVTs

2014-06-12 Thread Alex Brett
ache.org/r/22512/#review45503 --- On June 12, 2014, 1:27 p.m., Alex Brett wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https

Re: Review Request 22512: CLOUDSTACK-6862 Don't run vGPU tests on KVM or in the BVTs

2014-06-12 Thread Alex Brett
icate these two issues, but I believe they are the same thing. Diffs (updated) - test/integration/smoke/test_deploy_vgpu_enabled_vm.py fa33bdc Diff: https://reviews.apache.org/r/22512/diff/ Testing --- Tested against a KVM host to ensure the skip logic kicks in. Thanks, Alex Brett

Re: Review Request 22512: CLOUDSTACK-6862 Don't run vGPU tests on KVM or in the BVTs

2014-06-12 Thread Alex Brett
if it's not running on vGPU hardware, but that's quite difficult to detect... - Alex --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22512/#review45510 --

Review Request 23197: CLOUDSTACK-7031 Improve error handling in deployDataCenter.py

2014-07-01 Thread Alex Brett
/23197/diff/ Testing --- Run through pylint, manual testing now in progress to verify functionality... Thanks, Alex Brett

RE: Failed add KVM agent to CS with latest master

2014-07-23 Thread Alex Brett
> I am unable to add KVM agent with latest master build, this issue is tracked > in https://issues.apache.org/jira/browse/CLOUDSTACK-7170 > > Those made changes in master yesterday/today, can you please check it > regressed from you commit or not ? As noted on the ticket I've narrowed this down

Review Request 24050: CLOUDSTACK-7173 Make getNewMinIops and getNewMaxIops return Longs

2014-07-29 Thread Alex Brett
getter is called is expecting a Long object, so changing it to return a Long rather than long should be safe. Diffs - server/src/com/cloud/storage/VmWorkResizeVolume.java 1caab10 Diff: https://reviews.apache.org/r/24050/diff/ Testing --- Verified cloudstack still builds Thanks, Alex

Review Request 24550: CLOUDSTACK-7306 Don't run test_01_primary_storage_iscsi on KVM or HyperV

2014-08-11 Thread Alex Brett
fy it skips correctly Thanks, Alex Brett

Review Request 24552: CLOUDSTACK-7307 Add simulator_only attribute to tests which need it

2014-08-11 Thread Alex Brett
vm_sync.py 6d56945 Diff: https://reviews.apache.org/r/24552/diff/ Testing --- Verified that tests are picked up when run without the new attribute, and not picked up when used with !simulator_only in the nosetests -a attribute list. Thanks, Alex Brett

Review Request 24605: CLOUDSTACK-7322 Tag disruptive tests

2014-08-12 Thread Alex Brett
st_ssvm.py 5713569 Diff: https://reviews.apache.org/r/24605/diff/ Testing --- Verified using --collect-only option to nosetests that filtering using the disruptive attribute works correctly. Thanks, Alex Brett

Re: Review Request 24550: CLOUDSTACK-7306 Don't run test_01_primary_storage_iscsi on KVM or HyperV

2014-08-13 Thread Alex Brett
dated) - test/integration/smoke/test_primary_storage.py d2d5b4f Diff: https://reviews.apache.org/r/24550/diff/ Testing --- Ran test against KVM host to verify it skips correctly Thanks, Alex Brett

Re: Review Request 24550: CLOUDSTACK-7306 Don't run test_01_primary_storage_iscsi on KVM or HyperV

2014-08-13 Thread Alex Brett
it at all, so the test should skip in these cases. Diffs (updated) - test/integration/smoke/test_primary_storage.py d2d5b4f Diff: https://reviews.apache.org/r/24550/diff/ Testing --- Ran test against KVM host to verify it skips correctly Thanks, Alex Brett

Re: Review Request 24550: CLOUDSTACK-7306 Don't run test_01_primary_storage_iscsi on KVM or HyperV

2014-08-13 Thread Alex Brett
ation/smoke/test_primary_storage.py d2d5b4f Diff: https://reviews.apache.org/r/24550/diff/ Testing --- Ran test against KVM host to verify it skips correctly Thanks, Alex Brett

Re: Review Request 24550: CLOUDSTACK-7306 Don't run test_01_primary_storage_iscsi on KVM or HyperV

2014-08-13 Thread Alex Brett
e done I believe resolves all of this... - Alex --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24550/#review50441 -------

Versions on Jira and web

2014-08-13 Thread Alex Brett
e.org/downloads.html) we have 4.4.0, which is correct, however on the linked archives page (http://cloudstack.apache.org/archives.html) we don't seem to have 4.3.0, the newest release shown is 4.2.1 - have we accidentally lost 4.3.0 when releasing 4.4.0? Kind Regards, Alex Brett

Review Request 24805: CLOUDSTACK-7363 test_vmware_drs.py should skip on non-VMWare hypervisors

2014-08-18 Thread Alex Brett
not in use. Diffs - test/integration/component/test_vmware_drs.py 7d3ab7f Diff: https://reviews.apache.org/r/24805/diff/ Testing --- Tested against a XenServer cloud, and test correctly skipped. Thanks, Alex Brett

Review Request 25187: test_delete_account and test_releaseIP failing in advanced zone

2014-08-29 Thread Alex Brett
results equivalent to those seen on regular regression runs. Ran test_delete_account and test_releaseIP to verify these now pass as expected. Thanks, Alex Brett

Unable to connect to management server on current master builds

2014-08-29 Thread Alex Brett
Hello all, On current master builds (such as http://jenkins.buildacloud.org/job/package-rhel63-master/3202/), I can't connect to the management server, either via the API or UI. The major changes since the last working build I had seems to be the SAML2 merge (there are a couple of other things

RE: [BLOCKED] Unable to connect to management server on current master builds

2014-08-30 Thread Alex Brett
at is the exception or issue observed? On 30-Aug-2014, at 3:03 am, Min Chen wrote: > CC Rohit here in case he didn't see this email. > > Rohit, can you fix this? > > Thanks > -min > > On 8/29/14 9:21 AM, "Alex Brett" wrote: > >> Hello

RE: [BLOCKED] Unable to connect to management server on current master builds

2014-08-30 Thread Alex Brett
Also I note the last few simulator runs on jenkins.buildacloud.org are failing, the most recent with a SAML unit test failure... Alex From: Alex Brett [alex.br...@citrix.com] Sent: 30 August 2014 12:39 To: dev@cloudstack.apache.org; Min Chen Subject: RE

RE: [BLOCKED] Unable to connect to management server on current master builds

2014-08-30 Thread Alex Brett
peblue.com] Sent: 30 August 2014 13:36 To: dev Subject: Re: [BLOCKED] Unable to connect to management server on current master builds Alex, On 30-Aug-2014, at 1:45 pm, Alex Brett wrote: > Also I note the last few simulator runs on jenkins.buildacloud.org are > failing, the most recent with

RE: [BLOCKED] Unable to connect to management server on current master builds

2014-08-31 Thread Alex Brett
This is still failing for me, but I think I've now found the exception that is actually showing the problem - it was hiding in localhost..log. I've pasted it on the ticket, but here it is as well: Aug 30, 2014 11:10:50 PM org.apache.catalina.core.StandardContext listenerStart SEVERE: Exception s

RE: [BLOCKED] Unable to connect to management server on current master builds

2014-08-31 Thread Alex Brett
access to know what it's actually running etc. Alex > -Original Message- > From: Rohit Yadav [mailto:rohit.ya...@shapeblue.com] > Sent: 31 August 2014 18:43 > To: dev@cloudstack.apache.org > Cc: Alex Brett > Subject: Re: [BLOCKED] Unable to connect to management server o

Review Request 25258: Fix TestVolumes.test_07_resize_fail

2014-09-02 Thread Alex Brett
Diff: https://reviews.apache.org/r/25258/diff/ Testing --- Test passed running against current build Thanks, Alex Brett

Re: Review Request 25187: test_delete_account and test_releaseIP failing in advanced zone

2014-09-03 Thread Alex Brett
tests in test_lb_secondary_ip.py with changes in place, verified results equivalent to those seen on regular regression runs. Ran test_delete_account and test_releaseIP to verify these now pass as expected. Thanks, Alex Brett

Re: Review Request 25289: CLOUDSTACK-7474-Failed-to-start-MS-with-java7-version

2014-09-03 Thread Alex Brett
> On Sept. 3, 2014, 9:32 a.m., Rajani Karuturi wrote: > > client/tomcatconf/classpath.conf.in, line 37 > > > > > > Can we get the JAVA_HOME from installed java instead of hardcoding it? > > The path may be different fo

Re: Review Request 24882: CLOUDSTACK-6282 - Added skip condition when hypervisor is hyper-v for tests which are not applicable for hyper-v

2014-09-03 Thread Alex Brett
e.org/r/24882/#comment91031> Not your bug, but the wording here is poor - should probably be "Not enough zones exist to copy iso" or similar. - Alex Brett On Aug. 20, 2014, 4:22 a.m., Vinay Varma wrote: > > -

RE: Review Request 25289: CLOUDSTACK-7474-Failed-to-start-MS-with-java7-version

2014-09-03 Thread Alex Brett
On 04 September 2014 00:45, David Nalley [da...@gnsa.us] wrote: > On Wed, Sep 3, 2014 at 7:40 PM, Alex Brett wrote: >> To expand on this a little bit - in RHEL 6.3 if you have both Java 1.6 and >> Java 7 installed, the default behaviour with the alternatives mechanism >>

RE: test case tagging and travis output

2014-09-04 Thread Alex Brett
me is not documented > in the bug in spite of Alex Brett asking for it, so once again: > @anyone: is this described somewhere? I'm not sure what exactly you're trying to achieve, but I've found what was done in CLOUDSTACK-6914 is limited as to what it can do - I've got a couple

RE: [DISCUSS] How xs-tools gets installed for xen vms and systemvms

2014-09-09 Thread Alex Brett
On essentially any current Linux distro, xs-tools doesn't actually install any drivers (in the days of RHEL4 and the like it used to have custom kernels as the vendor ones had severe limitations), because as you say the kernel has the support built in (PVops). What xs-tools gives in Linux is:

Marvin test cleanup

2014-09-09 Thread Alex Brett
Hello all, At the moment we have a lot of Marvin tests that follow a pattern that looks roughly like this: 1. Setup some resources (e.g. accounts, service offerings, VMs etc) 2. Add the resources to a list in the testcase (often called self.cleanup) 3. Do the test(s) 4. Call cleanup_resources wi

RE: Marvin test cleanup

2014-09-10 Thread Alex Brett
> I like the idea. What worries me is the possibility to run test cases on a > life > system. I think it is useful for some operators to be able to do that. > Those people must not lose any objects that were created outside of the > test suite. Therefore it can be very tricky, not very different f

[BLOCKED] Management server not starting

2014-09-24 Thread Alex Brett
The management server is not starting on current master builds - apparently due to a DB error. https://issues.apache.org/jira/browse/CLOUDSTACK-7621 has been filed for this, CCing Pierre-Luc Dion as the author of some DB schema changes that are potential candidates for causing the problem... A

Re: Review Request 24882: CLOUDSTACK-6282 - Added skip condition when hypervisor is hyper-v for tests which are not applicable for hyper-v

2014-09-29 Thread Alex Brett
tion/component/test_escalations_isos.py <https://reviews.apache.org/r/24882/#comment95074> You don't need this as you've already got above: from marvin.lib.utils import * - Alex Brett On Sept. 29, 2014, 7:13 a.m., Vinay Varma wrote: > > ---

Re: Review Request 26221: CLOUDSTACK-6282 - Added hyper-v hypervisor check for tests which are not applicable for hyper-v

2014-10-01 Thread Alex Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26221/#review55061 --- Ship it! Ship It! - Alex Brett On Oct. 1, 2014, 8:31 a.m

RE: Shellshock

2014-10-03 Thread Alex Brett
On 03 October 2014 13:52, Adrian Lewis [adr...@alsiconsulting.co.uk] wrote: > The only solution I can think of is to 'apt-get update bash' on every > system VM but clearly these get fired up dynamically. Is it possible to > boot the template, make modifications and then use as a replacement system

Review Request 26364: CLOUDSTACK-7673 Handle multiple gateways in test_ssvm.py

2014-10-06 Thread Alex Brett
incorrectly fail. Modify the check to look at all returned gateways for a match Diffs - test/integration/smoke/test_ssvm.py 5713569 Diff: https://reviews.apache.org/r/26364/diff/ Testing --- Verified the tests pass in a normal scenario Thanks, Alex Brett

Re: Review Request 25266: Simulator build support need to extends for RPM build

2014-10-13 Thread Alex Brett
> On Oct. 8, 2014, 5:07 p.m., Frank Zhang wrote: > > Ship It! Unfortunately what's actually been pushed in https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commit;h=f96c65416a2802bcf2a1f8d5a5070ffe6a29111f is missing a rather crucial change - in package.sh while it now takes the sim

Review Request 26760: Skip various BVT tests on LXC

2014-10-15 Thread Alex Brett
/smoke/test_vm_life_cycle.py 0be518d test/integration/smoke/test_vm_snapshots.py dae945c Diff: https://reviews.apache.org/r/26760/diff/ Testing --- Run all changed files against LXC and ensured appropriate tests skipped. Thanks, Alex Brett

Re: Review Request 27017: CLOUDSTACK-6282: Added newly automated tests and also modified some existing tests to remove dependency

2014-10-31 Thread Alex Brett
mory), would it be worth having these methods call a shared method with just a parameter as to whether to include memory or not, to avoid code duplication? (The risk is someone fixes a bug in one, but not the other or whatever) - Alex Brett On Oct. 31, 2014, 4:37 a.m.,

Re: Review Request 27017: CLOUDSTACK-6282: Added newly automated tests and also modified some existing tests to remove dependency

2014-11-24 Thread Alex Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27017/#review62786 --- Ship it! Ship It! - Alex Brett On Nov. 3, 2014, 6:19 a.m