> On Aug. 13, 2014, 10:43 a.m., Santhosh Edukulla wrote: > > test/integration/smoke/test_primary_storage.py, line 158 > > <https://reviews.apache.org/r/24550/diff/2/?file=659231#file659231line158> > > > > This check is not required right? As well, i just pushed a similar > > change to master, post the ci failure. Please check.
Your change unfortunately was broken in that it was put into the *NFS* test (which is supported on KVM), not the iSCSI test, which isn't. The most recent diff r4 I've done I believe resolves all of this... - Alex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24550/#review50441 ----------------------------------------------------------- On Aug. 13, 2014, 10:44 a.m., Alex Brett wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24550/ > ----------------------------------------------------------- > > (Updated Aug. 13, 2014, 10:44 a.m.) > > > Review request for cloudstack and Santhosh Edukulla. > > > Bugs: CLOUDSTACK-7306 > https://issues.apache.org/jira/browse/CLOUDSTACK-7306 > > > Repository: cloudstack-git > > > Description > ------- > > test_01_primary_storage_iscsi in > test/integration/smoke/test_primary_storage.py currently attempts to set up > an iSCSI primary storage pool, regardless of the type of host. > > For KVM, we only support iSCSI via shared mount point, and for Hyper-V we > don't support it at all, so the test should skip in these cases. > > > Diffs > ----- > > test/integration/smoke/test_primary_storage.py d2d5b4f > > Diff: https://reviews.apache.org/r/24550/diff/ > > > Testing > ------- > > Ran test against KVM host to verify it skips correctly > > > Thanks, > > Alex Brett > >
