[GitHub] cloudstack issue #1955: CLOUDSTACK-8239 Add VirtIO SCSI support for KVM host...

2017-02-22 Thread borisstoyanov
Github user borisstoyanov commented on the issue: https://github.com/apache/cloudstack/pull/1955 Thanks for this PR @nathanejohnson, I will build it and run smoketests agains it. @blueorangutan package --- If your project is set up for it, you can reply to this email and have y

[GitHub] cloudstack issue #1957: CLOUDSTACK-9748:VPN Users search functionality broke...

2017-02-22 Thread SudharmaJain
Github user SudharmaJain commented on the issue: https://github.com/apache/cloudstack/pull/1957 LGTM on the code changes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack issue #1955: CLOUDSTACK-8239 Add VirtIO SCSI support for KVM host...

2017-02-22 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1955 @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your re

[GitHub] cloudstack pull request #1960: CLOUDSTACK-9782: Host HA and KVM HA provider

2017-02-22 Thread rhtyd
GitHub user rhtyd opened a pull request: https://github.com/apache/cloudstack/pull/1960 CLOUDSTACK-9782: Host HA and KVM HA provider Host-HA offers investigation, fencing and recovery mechanisms for host that for any reason are malfunctioning. It uses Activity and Health checks

Re: [DISCUSS][FS] Host HA for CloudStack

2017-02-22 Thread Rohit Yadav
Here are some advantages of the proposed feature that is implemented in two parts - a HA entity-agnostic framework and a HA provider implementation specific for a resource: - Framework provides building blocks for health checks, degrading, recovery, fencing operations for a HA resource. This al

[GitHub] cloudstack issue #1873: CLOUDSTACK-9709: Updated the vm ip fetch task to use...

2017-02-22 Thread borisstoyanov
Github user borisstoyanov commented on the issue: https://github.com/apache/cloudstack/pull/1873 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled an

[GitHub] cloudstack issue #1942: CLOUDSTACK-9784 : GPU detail not displayed in GPU ta...

2017-02-22 Thread SudharmaJain
Github user SudharmaJain commented on the issue: https://github.com/apache/cloudstack/pull/1942 LGTM on the code changes --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled a

[GitHub] cloudstack issue #1768: CLOUDSTACK 9601: Upgrade: change logic for update pa...

2017-02-22 Thread DaanHoogland
Github user DaanHoogland commented on the issue: https://github.com/apache/cloudstack/pull/1768 LGTM but I hope you appreciate the concerns @marcaurele , on the other hand let's fix what breaks and make sure the 4.9 to 4.10 works with this. We can always advice to upgrade to 4.9 b

[GitHub] cloudstack issue #1873: CLOUDSTACK-9709: Updated the vm ip fetch task to use...

2017-02-22 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1873 @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your re

[GitHub] cloudstack issue #1958: CLOUDSTACK-5806: add presetup to storage types that ...

2017-02-22 Thread borisstoyanov
Github user borisstoyanov commented on the issue: https://github.com/apache/cloudstack/pull/1958 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled an

[GitHub] cloudstack issue #1958: CLOUDSTACK-5806: add presetup to storage types that ...

2017-02-22 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1958 @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your re

[GitHub] cloudstack issue #1960: [4.11/Future] CLOUDSTACK-9782: Host HA and KVM HA pr...

2017-02-22 Thread borisstoyanov
Github user borisstoyanov commented on the issue: https://github.com/apache/cloudstack/pull/1960 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled an

[GitHub] cloudstack issue #1768: CLOUDSTACK 9601: Upgrade: change logic for update pa...

2017-02-22 Thread DaanHoogland
Github user DaanHoogland commented on the issue: https://github.com/apache/cloudstack/pull/1768 btw @marcaurele @rhtyd idempotent will only be possible if we encode it. It is not encoded in older upgrades. Unless we clean those upgrades up we will have some issues. --- If your proje

[GitHub] cloudstack issue #1960: [4.11/Future] CLOUDSTACK-9782: Host HA and KVM HA pr...

2017-02-22 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1960 @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your re

[GitHub] cloudstack issue #1955: CLOUDSTACK-8239 Add VirtIO SCSI support for KVM host...

2017-02-22 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1955 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-522 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project d

[GitHub] cloudstack issue #1955: CLOUDSTACK-8239 Add VirtIO SCSI support for KVM host...

2017-02-22 Thread borisstoyanov
Github user borisstoyanov commented on the issue: https://github.com/apache/cloudstack/pull/1955 @blueorangutan test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and w

[GitHub] cloudstack issue #1955: CLOUDSTACK-8239 Add VirtIO SCSI support for KVM host...

2017-02-22 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1955 @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack issue #1873: CLOUDSTACK-9709: Updated the vm ip fetch task to use...

2017-02-22 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1873 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-523 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project d

Re: PRs for 4.10

2017-02-22 Thread Rajani Karuturi
6 days to go for the first RC. Please get the required lgtms and tests ready for the PRs you like to see in 4.10. I will try to merge all the PRs that meet the criteria. Thanks, ~Rajani On 19 Feb 2017 3:11 p.m., "Rajani Karuturi" wrote: > noted. > > > ~ Rajani > > http://cloudplatform.accelerit

[GitHub] cloudstack issue #1958: CLOUDSTACK-5806: add presetup to storage types that ...

2017-02-22 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1958 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-524 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project d

[GitHub] cloudstack issue #1960: [4.11/Future] CLOUDSTACK-9782: Host HA and KVM HA pr...

2017-02-22 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1960 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-525 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project d

[GitHub] cloudstack issue #1960: [4.11/Future] CLOUDSTACK-9782: Host HA and KVM HA pr...

2017-02-22 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1960 @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack issue #1873: CLOUDSTACK-9709: Updated the vm ip fetch task to use...

2017-02-22 Thread ustcweizhou
Github user ustcweizhou commented on the issue: https://github.com/apache/cloudstack/pull/1873 code LGTM one small suggestion: Could you modify line 2253 (_vmIpFetchThreadExecutor.execute) to be executed only when hypervisor is XenServer(already supported) or Vmware (sup

[GitHub] cloudstack issue #1960: [4.11/Future] CLOUDSTACK-9782: Host HA and KVM HA pr...

2017-02-22 Thread borisstoyanov
Github user borisstoyanov commented on the issue: https://github.com/apache/cloudstack/pull/1960 @blueorangutan test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and w

[GitHub] cloudstack issue #1958: CLOUDSTACK-5806: add presetup to storage types that ...

2017-02-22 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1958 @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack issue #1958: CLOUDSTACK-5806: add presetup to storage types that ...

2017-02-22 Thread borisstoyanov
Github user borisstoyanov commented on the issue: https://github.com/apache/cloudstack/pull/1958 @blueorangutan test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and w

[GitHub] cloudstack issue #1944: CLOUDSTACK-9783: Improve metrics view performance

2017-02-22 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1944 Requesting for review - @abhinandanprateek @DaanHoogland @rashmidixit @karuturi @koushik-das --- If your project is set up for it, you can reply to this email and have your reply appear on GitHu

[GitHub] cloudstack issue #1951: CLOUDSTACK-9792: Add upgrade path for 4.9.3.0

2017-02-22 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1951 Requesting for review - @DaanHoogland @abhinandanprateek @karuturi @koushik-das @syed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as we

[GitHub] cloudstack issue #843: Security group ingress/egress issues with xenserver 6...

2017-02-22 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/843 @blueorangutan help --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] cloudstack issue #843: Security group ingress/egress issues with xenserver 6...

2017-02-22 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/843 @rhtyd I understand these words: "help", "hello", "thanks", "package", "test" Test command usage: test [mgmt os] [hypervisor] [additional tests] Mgmt OS options: ['centos6', 'centos7

[GitHub] cloudstack issue #843: Security group ingress/egress issues with xenserver 6...

2017-02-22 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/843 @blueorangutan test centos7 xenserver-65sp1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featur

[GitHub] cloudstack issue #843: Security group ingress/egress issues with xenserver 6...

2017-02-22 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/843 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + xenserver-65sp1) has been kicked to run smoke tests --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack issue #1941: CLOUDSTACK-8663: Fixed various issues to allow VM sn...

2017-02-22 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1941 @blueorangutan test centos7 xenserver-65sp1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featu

[GitHub] cloudstack issue #1941: CLOUDSTACK-8663: Fixed various issues to allow VM sn...

2017-02-22 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1941 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + xenserver-65sp1) has been kicked to run smoke tests --- If your project is set up for it, you can reply to this email and have your repl

[GitHub] cloudstack issue #1903: [4.9] CLOUDSTACK-9356: FIX Cannot add users in VPC V...

2017-02-22 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1903 @blueorangutan test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cloudstack issue #1903: [4.9] CLOUDSTACK-9356: FIX Cannot add users in VPC V...

2017-02-22 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1903 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests --- If your project is set up for it, you can reply to this email and have your reply ap

[GitHub] cloudstack issue #1945: CLOUDSTACK-9787: Fix wrong return value in NetUtils....

2017-02-22 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1945 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fea

[GitHub] cloudstack issue #1212: [4.9] CLOUDSTACK-9136: remove ssh keypairs along wit...

2017-02-22 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1212 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cloudstack issue #1212: [4.9] CLOUDSTACK-9136: remove ssh keypairs along wit...

2017-02-22 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1212 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your reply appe

[GitHub] cloudstack issue #926: [4.10] CLOUDSTACK-7984: Collect network statistics fo...

2017-02-22 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/926 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cloudstack issue #926: [4.10] CLOUDSTACK-7984: Collect network statistics fo...

2017-02-22 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/926 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your reply appea

Re: PRs for 4.10

2017-02-22 Thread Rohit Yadav
Rajani and all, Please consider following PRs for review and merge: https://github.com/apache/cloudstack/pull/1829 (XenServer HVM VM attached disk limit bugfix, enough LGTMs and test results) https://github.com/apache/cloudstack/pull/1941 (same as above with additional fixes, lacks review lg

[GitHub] cloudstack issue #1829: CLOUDSTACK-9363: Fix HVM VM restart bug in XenServer

2017-02-22 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1829 This is ready for merge @karuturi --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enable

[GitHub] cloudstack issue #1770: CLOUDSTACK-9628: Fix Template Size in Swift as Secon...

2017-02-22 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1770 @karuturi this is ready for merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enable

[GitHub] cloudstack issue #1896: [CLOUDSTACK-9732] Update L10N resource files with 4....

2017-02-22 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1896 @karuturi pure translation changes, we need one more LGTM, otherwise this is ready for merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHu

[GitHub] cloudstack issue #1946: CLOUDSTACK-9788: Fix exception listNetworks with pag...

2017-02-22 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1946 LGTM. @karuturi this is ready for merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] cloudstack issue #1950: [4.10] CLOUDSTACK-9462: Build packages on Ubuntu 14....

2017-02-22 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1950 LGTM, I'll test it manually as soon as I get some free time. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does no

[GitHub] cloudstack issue #1945: CLOUDSTACK-9787: Fix wrong return value in NetUtils....

2017-02-22 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1945 @karuturi this is ready for merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enable

[GitHub] cloudstack issue #1947: CLOUDSTACK-9789: Fix releasing secondary guest IP fa...

2017-02-22 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1947 @karuturi this is ready for merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enable

[GitHub] cloudstack issue #1856: [4.9] CLOUDSTACK-9569: propagate global configuratio...

2017-02-22 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1856 @karuturi this is ready for merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enable

[GitHub] cloudstack issue #1212: [4.9] CLOUDSTACK-9136: remove ssh keypairs along wit...

2017-02-22 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1212 @karuturi this is ready for merge, using past review/test results. Though, I'll kick one more round of testing. --- If your project is set up for it, you can reply to this email and have your rep

[GitHub] cloudstack issue #1950: [4.10] CLOUDSTACK-9462: Build packages on Ubuntu 14....

2017-02-22 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1950 Verified packages built alright with the change. ![screenshot from 2017-02-22 16-09-11](https://cloud.githubusercontent.com/assets/95203/23207997/55394784-f919-11e6-9b50-a8c2897fd939.png) --

[GitHub] cloudstack pull request #1950: [4.10] CLOUDSTACK-9462: Build packages on Ubu...

2017-02-22 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1950#discussion_r102430976 --- Diff: debian/control --- @@ -16,6 +16,7 @@ Description: A common package which contains files which are shared by several C Package: cloudstack-m

[GitHub] cloudstack pull request #1950: [4.10] CLOUDSTACK-9462: Build packages on Ubu...

2017-02-22 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1950#discussion_r102431194 --- Diff: debian/control --- @@ -16,6 +16,7 @@ Description: A common package which contains files which are shared by several C Package: cloudstack-m

[GitHub] cloudstack issue #1768: CLOUDSTACK 9601: Upgrade: change logic for update pa...

2017-02-22 Thread DaanHoogland
Github user DaanHoogland commented on the issue: https://github.com/apache/cloudstack/pull/1768 @karuturi I think this should go in. Even being a bit of a risk, it will potentially reduce the support hours on upgrades. --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack pull request #1922: CLOUDSTACK-9757: Fixed issue in traffic from ...

2017-02-22 Thread jayapalu
Github user jayapalu commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1922#discussion_r102432766 --- Diff: server/src/com/cloud/network/router/CommandSetupHelper.java --- @@ -703,6 +722,10 @@ public void createVpcAssociatePublicIPCommands(final Vir

[GitHub] cloudstack issue #1948: [CLOUDSTACK-9793] Faster IP in subnet check

2017-02-22 Thread stefaniabergljot
Github user stefaniabergljot commented on the issue: https://github.com/apache/cloudstack/pull/1948 @rafaelweingartner It's not, but you can treat IPNetwork like it's a standard list object. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack issue #1212: [4.9] CLOUDSTACK-9136: remove ssh keypairs along wit...

2017-02-22 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1212 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-526 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project d

[GitHub] cloudstack pull request #672: Allow VM snapshots and volume snapshots to exi...

2017-02-22 Thread anshul1886
Github user anshul1886 closed the pull request at: https://github.com/apache/cloudstack/pull/672 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack issue #926: [4.10] CLOUDSTACK-7984: Collect network statistics fo...

2017-02-22 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/926 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-527 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project do

[GitHub] cloudstack issue #1773: CLOUDSTACK-9607: Preventing template deletion when t...

2017-02-22 Thread koushik-das
Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1773 I think changing the default API behaviour for fixing a bug should be ok as long as documented properly. Also in this case the deletion criteria is made more strict, so there is no unwanted

[GitHub] cloudstack issue #1951: CLOUDSTACK-9792: Add upgrade path for 4.9.3.0

2017-02-22 Thread koushik-das
Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1951 I already see schema-4920to41000.sql and the corresponding cleanup file in master. So how will this fit in the overall scheme? Is there any plans for 4.9.3? --- If your project is set up f

[GitHub] cloudstack pull request #1771: CLOUDSTACK-9611: Dedicating a Guest VLAN rang...

2017-02-22 Thread koushik-das
Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1771#discussion_r102445777 --- Diff: server/src/com/cloud/network/NetworkServiceImpl.java --- @@ -3085,9 +3085,10 @@ public GuestVlan dedicateGuestVlanRange(DedicateGuestVlanR

[GitHub] cloudstack issue #1954: CLOUDSTACK-9795: moved logrotate from cron.daily to ...

2017-02-22 Thread dmabry
Github user dmabry commented on the issue: https://github.com/apache/cloudstack/pull/1954 @blueorangutan test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes s

[GitHub] cloudstack pull request #1771: CLOUDSTACK-9611: Dedicating a Guest VLAN rang...

2017-02-22 Thread nitin-maharana
Github user nitin-maharana commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1771#discussion_r102453548 --- Diff: server/src/com/cloud/network/NetworkServiceImpl.java --- @@ -3085,9 +3085,10 @@ public GuestVlan dedicateGuestVlanRange(DedicateGuestVl

[GitHub] cloudstack issue #1951: CLOUDSTACK-9792: Add upgrade path for 4.9.3.0

2017-02-22 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1951 @koushik-das there is plan for 4.9.3, though the db schema change to insert/update the hypervisor capability need to go into 4.10.0 either with this PR carefully fwd-merged (which I can help with)

Re: apidocs build failure

2017-02-22 Thread Will Stevens
The use case is to be able to display the API docs the same as we did in the past with separation by default roles. It is still important to know from the docs that a call like create private gateway can only be done by an administrator (for example), which is longer possible from what I can tell.

[GitHub] cloudstack issue #1950: [4.10] CLOUDSTACK-9462: Build packages on Ubuntu 14....

2017-02-22 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1950 Install log on Ubuntu 16.10: root@antrix:/# apt-get install cloudstack-management -V Reading package lists... Done Building dependency tree Reading state information... Done

[GitHub] cloudstack issue #1950: [4.10] CLOUDSTACK-9462: Build packages on Ubuntu 14....

2017-02-22 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1950 /cc @karuturi LGTM, manual tests confirm that mgmt server can be installed and setup on Ubuntu 16.04+. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack issue #1950: [4.10] CLOUDSTACK-9462: Build packages on Ubuntu 14....

2017-02-22 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1950 Additional notes, I still found issues with mgmt server not working afterwards likely due to permission/sudoers issue: 017-02-22 18:37:25,076 INFO [c.c.s.ConfigurationServerImpl] (local

[GitHub] cloudstack issue #1950: [4.10] CLOUDSTACK-9462: Build packages on Ubuntu 14....

2017-02-22 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1950 @wido can you comment on this PR, thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack issue #1773: CLOUDSTACK-9607: Preventing template deletion when t...

2017-02-22 Thread priyankparihar
Github user priyankparihar commented on the issue: https://github.com/apache/cloudstack/pull/1773 Hi @serg38 @ustcweizhou @koushik-das @jburwell @borisstoyanov , Thanks for valuable insight. Code is modified according to your suggestion. :) --- If your project is set up for it, y

[GitHub] cloudstack issue #1948: [CLOUDSTACK-9793] Faster IP in subnet check

2017-02-22 Thread rafaelweingartner
Github user rafaelweingartner commented on the issue: https://github.com/apache/cloudstack/pull/1948 Great, nice work. LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature en

[GitHub] cloudstack issue #1773: CLOUDSTACK-9607: Preventing template deletion when t...

2017-02-22 Thread borisstoyanov
Github user borisstoyanov commented on the issue: https://github.com/apache/cloudstack/pull/1773 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled an

[GitHub] cloudstack issue #1773: CLOUDSTACK-9607: Preventing template deletion when t...

2017-02-22 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1773 @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your re

[GitHub] cloudstack issue #1212: [4.9] CLOUDSTACK-9136: remove ssh keypairs along wit...

2017-02-22 Thread borisstoyanov
Github user borisstoyanov commented on the issue: https://github.com/apache/cloudstack/pull/1212 @blueorangutan test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and w

[GitHub] cloudstack issue #1212: [4.9] CLOUDSTACK-9136: remove ssh keypairs along wit...

2017-02-22 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1212 @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack issue #1768: CLOUDSTACK 9601: Upgrade: change logic for update pa...

2017-02-22 Thread marcaurele
Github user marcaurele commented on the issue: https://github.com/apache/cloudstack/pull/1768 As a reminder for `-cleanup` SQL scripts: > We rarely need cleanup scripts, only when some field/value is required during the data migration and has to be dropped later on. https

[GitHub] cloudstack issue #1773: CLOUDSTACK-9607: Preventing template deletion when t...

2017-02-22 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1773 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-528 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project d

[GitHub] cloudstack issue #1773: CLOUDSTACK-9607: Preventing template deletion when t...

2017-02-22 Thread borisstoyanov
Github user borisstoyanov commented on the issue: https://github.com/apache/cloudstack/pull/1773 @blueorangutan test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and w

[GitHub] cloudstack issue #1773: CLOUDSTACK-9607: Preventing template deletion when t...

2017-02-22 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1773 @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack issue #1915: CLOUDSTACK-9746 system-vm: logrotate config causes c...

2017-02-22 Thread dmabry
Github user dmabry commented on the issue: https://github.com/apache/cloudstack/pull/1915 LGTM. tag:mergeready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cloudstack issue #1773: CLOUDSTACK-9607: Preventing template deletion when t...

2017-02-22 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1773 @priyankparihar A part is still missing that will use forced option in UI but give a user option to cancel deletion if active VMs exist --- If your project is set up for it, you can reply to th

[GitHub] cloudstack issue #1773: CLOUDSTACK-9607: Preventing template deletion when t...

2017-02-22 Thread priyankparihar
Github user priyankparihar commented on the issue: https://github.com/apache/cloudstack/pull/1773 @serg38 >A part is still missing that will use forced option in UI but give a user option to cancel deletion if active VMs exist. I think it will be good to take all a

[GitHub] cloudstack pull request #:

2017-02-22 Thread borisstoyanov
Github user borisstoyanov commented on the pull request: https://github.com/apache/cloudstack/commit/3caedb9ef3556e2c59681f4ec52662f8d7797888#commitcomment-20995874 In test/integration/smoke/test_snapshots.py: In test/integration/smoke/test_snapshots.py on line 281: @nvazquez c

[GitHub] cloudstack pull request #1774: CLOUDSTACK-9608: Errored State and Abandoned ...

2017-02-22 Thread priyankparihar
Github user priyankparihar closed the pull request at: https://github.com/apache/cloudstack/pull/1774 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

[GitHub] cloudstack issue #1774: CLOUDSTACK-9608: Errored State and Abandoned state T...

2017-02-22 Thread priyankparihar
Github user priyankparihar commented on the issue: https://github.com/apache/cloudstack/pull/1774 Hi @borisstoyanov Please check. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack issue #1302: CLOUDSTACK-9104: VM naming convention in case vmware...

2017-02-22 Thread priyankparihar
Github user priyankparihar commented on the issue: https://github.com/apache/cloudstack/pull/1302 Hi @borisstoyanov Please check. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack issue #815: CLOUDSTACK-8841: Storage XenMotion from XS 6.2 to XS ...

2017-02-22 Thread priyankparihar
Github user priyankparihar commented on the issue: https://github.com/apache/cloudstack/pull/815 Hi @borisstoyanov Please check. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack issue #1773: CLOUDSTACK-9607: Preventing template deletion when t...

2017-02-22 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1773 @priyankparihar Well. API use cases can be recoded but not UI. Presently we can delete templates in UI even with active VMs. With your changes there will be no recourse. An easy option will be t

[GitHub] cloudstack issue #1774: CLOUDSTACK-9608: Errored State and Abandoned state T...

2017-02-22 Thread borisstoyanov
Github user borisstoyanov commented on the issue: https://github.com/apache/cloudstack/pull/1774 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled a

[GitHub] cloudstack issue #1774: CLOUDSTACK-9608: Errored State and Abandoned state T...

2017-02-22 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1774 @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your re

[GitHub] cloudstack issue #815: CLOUDSTACK-8841: Storage XenMotion from XS 6.2 to XS ...

2017-02-22 Thread borisstoyanov
Github user borisstoyanov commented on the issue: https://github.com/apache/cloudstack/pull/815 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cloudstack issue #815: CLOUDSTACK-8841: Storage XenMotion from XS 6.2 to XS ...

2017-02-22 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/815 @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your rep

[GitHub] cloudstack pull request #1774: CLOUDSTACK-9608: Errored State and Abandoned ...

2017-02-22 Thread priyankparihar
GitHub user priyankparihar reopened a pull request: https://github.com/apache/cloudstack/pull/1774 CLOUDSTACK-9608: Errored State and Abandoned state Templates are not … Errored and Abandoned Templates should also be displayed on UI so that user has the accessibility to delete the

[GitHub] cloudstack issue #1847: CLOUDSTACK-9691: Fixed unhandeled excetion in list s...

2017-02-22 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1847 @karuturi @anshul1886 Can we tweak line 278 of test_snaphsot.py from self.services["nfs"], to self.services["nfs2"], and re-merge this PR so it doesn't conflict with other

[GitHub] cloudstack issue #1773: CLOUDSTACK-9607: Preventing template deletion when t...

2017-02-22 Thread priyankparihar
Github user priyankparihar commented on the issue: https://github.com/apache/cloudstack/pull/1773 @borisroman and @serg38 Sure. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature en

[GitHub] cloudstack issue #1774: CLOUDSTACK-9608: Errored State and Abandoned state T...

2017-02-22 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1774 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-529 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project d

[GitHub] cloudstack issue #1774: CLOUDSTACK-9608: Errored State and Abandoned state T...

2017-02-22 Thread borisstoyanov
Github user borisstoyanov commented on the issue: https://github.com/apache/cloudstack/pull/1774 @blueorangutan test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and w

[GitHub] cloudstack issue #1774: CLOUDSTACK-9608: Errored State and Abandoned state T...

2017-02-22 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1774 @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests --- If your project is set up for it, you can reply to this email and have your

  1   2   3   >