Github user jayapalu commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1922#discussion_r102432766
--- Diff: server/src/com/cloud/network/router/CommandSetupHelper.java ---
@@ -703,6 +722,10 @@ public void createVpcAssociatePublicIPCommands(final
VirtualRouter router, final
sourceNatIpAdd = new Pair<IpAddressTO, Long>(ip,
ipAddr.getNetworkId());
addSourceNat = add;
}
+
+ if (!firstIP || add) {
+ firstIP = false;
+ }
--- End diff --
for additional public subnet on delete it is not sure which ip is set to
first ip. So on delete we want to set sourcenat to true for all ips to delete
source nat rules.
@ramkatru
I will add above comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
