[GitHub] cloudstack pull request #1771: CLOUDSTACK-9611: Dedicating a Guest VLAN rang...

[nitin-maharana]

Github user nitin-maharana commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1771#discussion_r102453548
  
    --- Diff: server/src/com/cloud/network/NetworkServiceImpl.java ---
    @@ -3085,9 +3085,10 @@ public GuestVlan 
dedicateGuestVlanRange(DedicateGuestVlanRangeCmd cmd) {
             // Verify account is valid
             Account vlanOwner = null;
             if (projectId != null) {
    -            if (accountName != null) {
    -                throw new InvalidParameterValueException("accountName and 
projectId are mutually exclusive");
    -            }
    +            //accountName and projectId are mutually exclusive
    --- End diff --
    
    @koushik-das : If we go with the scope field, we have to revert that change 
and have to make required depending on the scope we select. Like shown in the 
below snapshot.
    
    <img width="420" alt="screen shot 2017-02-22 at 6 14 19 pm" 
src="https://cloud.githubusercontent.com/assets/12583725/23212092/1ba1cd22-f92b-11e6-83ba-72dab04dc497.png";>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---