Github user kansal commented on the pull request:
https://github.com/apache/cloudstack/pull/826#issuecomment-212773238
@jayapalu Rebased. Please have a look now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1326#issuecomment-212776381
@swill This has 2 LGTMs and also CI results. The failures are unrelated as
this PR only adds new test cases and no product code changes. This can be
merged.
-
Github user kansal commented on the pull request:
https://github.com/apache/cloudstack/pull/826#issuecomment-212777128
@jayapalu attached the screenshots:
https://cloud.githubusercontent.com/assets/4276209/14700575/17b9fb80-07be-11e6-84cb-b61d68816496.png";>
https://cloud.
Github user rajesh-battala commented on the pull request:
https://github.com/apache/cloudstack/pull/815#issuecomment-212777172
Looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not ha
GitHub user bhaisaab opened a pull request:
https://github.com/apache/cloudstack/pull/1506
fake don't merge
Travis is failing marvin tests repeatedly, this is a fake test to verify if
that's happening due to one of my PRs of due to recent PR merged on master.
You can merge this pul
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1399#issuecomment-212777880
LGTM - Verified on 4.7 that the dropdown shows http option.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1398#issuecomment-212779591
LGTM - verified on 4.7 that alignment is proper
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1399
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user rajesh-battala commented on the pull request:
https://github.com/apache/cloudstack/pull/1271#issuecomment-212780472
Looks good to me.
After this patch on pressing "/" on console not showing/activating the
search bar.
---
If your project is set up for it, you can reply
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1398
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user rajesh-battala commented on the pull request:
https://github.com/apache/cloudstack/pull/1244#issuecomment-212781462
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feat
Github user srinivas-gandikota commented on the pull request:
https://github.com/apache/cloudstack/pull/1200#issuecomment-212781868
LGTM based on code review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user rajesh-battala commented on the pull request:
https://github.com/apache/cloudstack/pull/846#issuecomment-212782054
I have gone through the code. patch LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If y
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/625#issuecomment-212789349
This will probably never merge. Closing for now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user wido closed the pull request at:
https://github.com/apache/cloudstack/pull/625
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is en
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1054#issuecomment-212789949
Can we already merge this one?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SudharmaJain commented on the pull request:
https://github.com/apache/cloudstack/pull/876#issuecomment-212794906
@alexandrelimassantana This method is about a query execution on database.
Could you suggest how can i add a unit test for it?
---
If your project is set up f
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1501#issuecomment-212797997
LGTM, cc @swill
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user bhaisaab closed the pull request at:
https://github.com/apache/cloudstack/pull/1506
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user bhaisaab opened a pull request:
https://github.com/apache/cloudstack/pull/1507
fake don't merge
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shapeblue/cloudstack
fake-marvin-faliing-master
Alternatively you can r
Github user nitin-maharana commented on the pull request:
https://github.com/apache/cloudstack/pull/1333#issuecomment-212799750
@koushik-das: Actually this dialog appears after the first CIDR unchanged
confirmation dialog. If its an admin account, Even if we select yes/no, it will
be
Github user jayapalu commented on the pull request:
https://github.com/apache/cloudstack/pull/826#issuecomment-212800418
Tested the vpn user configuration with one router down and one router up
and it is working fine.
LGTM
---
If your project is set up for it, you can reply to th
Github user syed commented on the pull request:
https://github.com/apache/cloudstack/pull/1501#issuecomment-212800599
LGTM based on code review @mike-tutkowski cc @swill
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user rajesh-battala commented on the pull request:
https://github.com/apache/cloudstack/pull/775#issuecomment-212803920
I have gone through the code. LGTM.
without UT for this patch might not be an issue.
---
If your project is set up for it, you can reply to this email and
Github user rajesh-battala commented on the pull request:
https://github.com/apache/cloudstack/pull/1126#issuecomment-212805433
Gone through the code.
API change for the description param is good.
---
If your project is set up for it, you can reply to this email and have your
rep
Github user kansal commented on the pull request:
https://github.com/apache/cloudstack/pull/1241#issuecomment-212807918
@jayapalu rebased. Please have a look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proj
Github user nitin-maharana commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1255#discussion_r60544347
--- Diff: ui/scripts/network.js ---
@@ -6517,7 +6445,192 @@
}
}
}
-
Github user nitin-maharana commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1255#discussion_r60544256
--- Diff: ui/scripts/network.js ---
@@ -4508,99 +4524,11 @@
$('').addClass('psk').html(_l('me
Github user nitin-maharana commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1255#discussion_r60544689
--- Diff: ui/scripts/network.js ---
@@ -6517,7 +6445,192 @@
}
}
}
-
Github user rajesh-battala commented on the pull request:
https://github.com/apache/cloudstack/pull/905#issuecomment-212814104
Marvin test really helps for validating this bug fix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub a
Github user rajesh-battala commented on the pull request:
https://github.com/apache/cloudstack/pull/1157#issuecomment-212815918
went through code.
LGTM. :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
Github user sanju1010 commented on the pull request:
https://github.com/apache/cloudstack/pull/1458#issuecomment-212820627
LGTM based on the code review!!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project d
Github user cloudsadhu commented on the pull request:
https://github.com/apache/cloudstack/pull/1498#issuecomment-212828874
reviewed your code change and looks good. Please post the test result.
LGTM based on code review !!
---
If your project is set up for it, you can reply to t
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/815#issuecomment-212832800
@priyankparihar This version check removal is at a generic place and impact
all HVs. Since you have only verified for XS 6.2 -> 6.5, there are concerns as
to wha
Github user kansal commented on the pull request:
https://github.com/apache/cloudstack/pull/1255#issuecomment-212834905
@nitin-maharana Yes. Will update and rebase the PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. I
Github user sanju1010 commented on the pull request:
https://github.com/apache/cloudstack/pull/826#issuecomment-212836461
Tested these changes manually in my setup. Changes works fine. LGTM!!
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user sanju1010 commented on the pull request:
https://github.com/apache/cloudstack/pull/1308#issuecomment-212839793
@pavanb018 , those failures are not related to this PR. Can somebody merge
this PR?
---
If your project is set up for it, you can reply to this email and have yo
Github user sanju1010 commented on the pull request:
https://github.com/apache/cloudstack/pull/1308#issuecomment-212839936
@pavanb018 , those failures are not related to this PR. Can somebody please
merge this PR?
---
If your project is set up for it, you can reply to this email and
Github user bhaisaab closed the pull request at:
https://github.com/apache/cloudstack/pull/1507
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1308#issuecomment-212842361
@swill This is a test only PR. 2 LGTMs are there and the CI failures are
unrelated to the changes. This can be merged.
---
If your project is set up for it, yo
Github user kishankavala commented on the pull request:
https://github.com/apache/cloudstack/pull/1418#issuecomment-212842771
@kansal
LGTM. See if you can add an integration test.
Actual response from traffic sentinel resource in the logs will also help.
---
If your projec
Github user jayapalu commented on the pull request:
https://github.com/apache/cloudstack/pull/1255#issuecomment-212842613
@kansal Can you please complete the localisation changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user rajesh-battala commented on the pull request:
https://github.com/apache/cloudstack/pull/1200#issuecomment-212842649
LGTM. :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have thi
Github user sateesh-chodapuneedi commented on the pull request:
https://github.com/apache/cloudstack/pull/815#issuecomment-212842765
>>Currently UI does not allow migration between different versions, and
changing UI for this change is not elegant.
@priyankparihar
Why allow t
Github user sateesh-chodapuneedi commented on the pull request:
https://github.com/apache/cloudstack/pull/815#issuecomment-212845624
>Purpose of doing this change is if some user intentionally want to do
migration from lower to higher then he can do it via API(from UI he can not do
th
Github user priyankparihar commented on the pull request:
https://github.com/apache/cloudstack/pull/815#issuecomment-212846127
@sateesh-chodapuneedi @koushik-das I will get back to you soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1489#issuecomment-212852849
@jburwell I've fixed outstanding issues, including a framework level API
arg validation (and removed such validations across cmd implementations)
@koushik-das l
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1464#issuecomment-212853751
@shwetaag @swill As I understand from @sanju1010 comment, the script is
used to automate creation of dc, cluster and hosts in vCenter. The setup
created can the
Github user sateesh-chodapuneedi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1302#discussion_r60561591
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -2030,12 +2030,29 @@ int getReserv
Github user sateesh-chodapuneedi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1302#discussion_r60561870
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -2030,12 +2030,29 @@ int getReserv
Github user deepthimachiraju commented on the pull request:
https://github.com/apache/cloudstack/pull/866#issuecomment-212857384
Tested this feature Manually .
LGTM .
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. I
Github user sateesh-chodapuneedi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1302#discussion_r60562111
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -2030,12 +2030,29 @@ int getReserv
Github user sateesh-chodapuneedi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1302#discussion_r60562268
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -2030,12 +2030,29 @@ int getReserv
Github user sateesh-chodapuneedi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1302#discussion_r60562370
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -2030,12 +2030,29 @@ int getReserv
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1302#discussion_r60562805
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -2030,12 +2030,29 @@ int getReservedCpuMHZ(Vir
All,
Whenever we've to write new APIs, we end up putting a lot of validations such
as Strings.isNullOrEmpty or checks on API args such as on id we do this a lot
getId() != null && getId() > 0 and on failing throw server api exception (as
cloudstack entity ids are always > 0, such as ids of vms,
HI All,
Jenkins build are failing with below licensing error "Too many files with
unapproved license: 1 " can someone please look into it. PR merge getting
delayed due to this build issues.
Check these jobs:
https://builds.apache.org/job/cloudstack-pr-analysis/971/
https://builds.apache.org/jo
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1321#issuecomment-212868899
@nitin-maharana I checked the discussions on #823 as well. Looks like it is
best to remove all tag checks for selecting offering. Also there is no usage
impact
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1200#issuecomment-212870271
@swill This is ready for merge, has the required LGTMs
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1302#issuecomment-212873785
@priyankparihar we'll need a unit test that shows that this change is
backward compatible. I like that we're considering both default instance name
with host name
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1302#discussion_r60565861
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -2030,12 +2030,29 @@ int getReservedCpuMHZ(Vir
Github user GabrielBrascher commented on the pull request:
https://github.com/apache/cloudstack/pull/1418#issuecomment-212876630
@kansal create methods would also help to test the behavior of this code,
using unit test and integration test (to verify if the methods that have unit
test
Would that be related to the PR being tested?
On Apr 21, 2016 7:17 AM, "Suresh Sadhu" wrote:
> HI All,
>
> Jenkins build are failing with below licensing error "Too many files with
> unapproved license: 1 " can someone please look into it. PR merge getting
> delayed due to this build issues.
>
>
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1157
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user pavanb018 commented on the pull request:
https://github.com/apache/cloudstack/pull/1323#issuecomment-212886925
@sanju1010 Have done code walk through and LGTM !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
I don’t think it is related to the PRs Will. I have force pushed two of my PRs
which are related to marvin tests. Jenkins build failed even for those two PRs.
Best Regards,
Sanjeev N
Chief Product Engineer, Accelerite
Off: +91 40 6722 9368 | EMail: sanjeev.neelar...@accelerite.com
-Origina
Github user pavanb018 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1304#discussion_r60570371
--- Diff: test/integration/component/test_vpc_network.py ---
@@ -2748,3 +2751,86 @@ def test_stop_start_vpc_router(self):
if (exceptionOccu
As per the build logs RAT is failing. Not sure from where this file is getting
picked up.
Unapproved licenses:
utils/testsmallfileinactive
***
From: Will Stevens
Sent: Thursday, April 21, 2016 5:27 PM
To: dev@cloudstack.ap
Github user pavanb018 commented on the pull request:
https://github.com/apache/cloudstack/pull/1304#issuecomment-212892204
Done code review ,a part from the above comment , the code LGTM !
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1489#discussion_r60570949
--- Diff:
plugins/acl/dynamic-role-based/src/org/apache/cloudstack/acl/DynamicRoleBasedAPIAccessChecker.java
---
@@ -0,0 +1,170 @@
+// Licensed
Github user nitin-maharana commented on the pull request:
https://github.com/apache/cloudstack/pull/1321#issuecomment-212898459
@koushik-das : I also think the same. Yes, that would be better. I will
raise another PR with removing the existing implementation. pinging @agneya2001
@remi
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1323#issuecomment-212902454
I think this one is ready to merge. I will add it to my merge queue...
---
If your project is set up for it, you can reply to this email and have your
reply appear o
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1200#issuecomment-212903509
Thanks, I will merge...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1489#discussion_r60573629
--- Diff:
plugins/acl/dynamic-role-based/src/org/apache/cloudstack/acl/DynamicRoleBasedAPIAccessChecker.java
---
@@ -0,0 +1,170 @@
+// Licensed to
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1464#issuecomment-212904531
I am fine with not running CI on this one. It would be nice if someone
could post a screenshot or something to show that the code behaves as expected.
We are
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1308#issuecomment-212905418
I will merge this today. Thanks...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project do
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1458#issuecomment-212906931
I think this one is ready. I want Jenkins to be green before I merge
though. I will review what is going on with Jenkins today. I will this to my
merge list.
---
Github user syed commented on the pull request:
https://github.com/apache/cloudstack/pull/1331#issuecomment-212907833
@jburwell @rafaelweingartner I've added the test for checking the logged
message using the gist provided by @jburwell. I've also added a `log4j.xml`
because the test w
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1326#issuecomment-212910562
Thanks, I will merge this today.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/866#issuecomment-212912851
@deepthimachiraju what's the downtime of network ?
I think this PR is too complicated.
---
If your project is set up for it, you can reply to this email and
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1501#issuecomment-212908719
I am pretty confident with this one and we have the LGTM code reviews
required, so I will add this to my merge queue to be merged today. Thanks...
---
If your proje
Github user dmabry commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1500#discussion_r60581671
--- Diff: test/integration/component/test_volumes.py ---
@@ -603,7 +603,144 @@ def test_01_volume_attach_detach(self):
"Check the stat
Github user dmabry commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1500#discussion_r60582064
--- Diff: test/integration/component/test_volumes.py ---
@@ -603,7 +603,144 @@ def test_01_volume_attach_detach(self):
"Check the stat
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1500#discussion_r60582658
--- Diff: test/integration/component/test_volumes.py ---
@@ -603,7 +603,144 @@ def test_01_volume_attach_detach(self):
"Check the st
Github user dmabry commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1500#discussion_r60582709
--- Diff: test/integration/component/test_volumes.py ---
@@ -603,7 +603,144 @@ def test_01_volume_attach_detach(self):
"Check the stat
Github user dmabry commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1500#discussion_r60584441
--- Diff: test/integration/component/test_volumes.py ---
@@ -603,7 +603,144 @@ def test_01_volume_attach_detach(self):
"Check the stat
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1489#discussion_r60585031
--- Diff:
plugins/acl/dynamic-role-based/src/org/apache/cloudstack/acl/DynamicRoleBasedAPIAccessChecker.java
---
@@ -0,0 +1,170 @@
+// Licensed to
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1304#issuecomment-212934000
@sanju1010 can you review @pavanb018's comment.
We need 1 more LGTM code review, otherwise things are looking to be in
pretty good shape here.
---
If your p
Github user dmabry commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1500#discussion_r60585058
--- Diff: test/integration/component/test_volumes.py ---
@@ -603,7 +603,144 @@ def test_01_volume_attach_detach(self):
"Check the stat
GitHub user insom opened a pull request:
https://github.com/apache/cloudstack/pull/1508
CLOUDSTACK-9362: Skip VXLANs when rewriting the bridge name for migrations
From the [JIRA
issue](https://issues.apache.org/jira/browse/CLOUDSTACK-9362):
>
https://github.com/apache/clou
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/1505#issuecomment-212950771
Screen shot from
[before](https://issues.apache.org/jira/secure/attachment/1250/Screen%20Shot%202015-12-15%20at%2015.32.12.png)
the fix
After:
http
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1505#issuecomment-212956256
Thank you sir. This is looking pretty good now. I think this LGTM, so I
will add this to the PRs to be merged today.
---
If your project is set up for it, you can
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/826#issuecomment-212963691
I am pretty comfortable with this change. We have had 2 manual tests to
validate the functionality and two LGTM votes. I am not sure this change
warrants a full run
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1498#issuecomment-212964858
I need one more LGTM and if you can post some proof this is working as
expected, I will feel better about merging it. Thanks... :)
---
If your project is set up fo
Github user dmabry commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1500#discussion_r60602140
--- Diff: test/integration/component/test_volumes.py ---
@@ -603,7 +603,144 @@ def test_01_volume_attach_detach(self):
"Check the stat
Github user dmabry commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1500#discussion_r60602084
--- Diff: test/integration/component/test_volumes.py ---
@@ -603,7 +603,144 @@ def test_01_volume_attach_detach(self):
"Check the stat
Github user dmabry commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1500#discussion_r60602700
--- Diff: test/integration/component/test_volumes.py ---
@@ -603,7 +603,144 @@ def test_01_volume_attach_detach(self):
"Check the stat
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1126#issuecomment-212976859
We need to be doing this to more API calls, so I am happy we are starting
to look at this.
@DaanHoogland I don't think JSON adds much value here. I think the
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1054#issuecomment-212981219
I need one more LGTM for this one and I would like to run CI to make sure
nothing breaks. Otherwise I think this is in a good place.
---
If your project is set up f
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/846#issuecomment-212983883
I need one more LGTM. I will add this to my CI queue. Thx...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub a
1 - 100 of 131 matches
Mail list logo
