Github user GabrielBrascher commented on the pull request:
https://github.com/apache/cloudstack/pull/1418#issuecomment-212876630
@kansal create methods would also help to test the behavior of this code,
using unit test and integration test (to verify if the methods that have unit
test are called in the correct order by a more generic method).
For example, you could create a method `queryTrafficSentinel`, this method
calls the part 1, 2 and 3 in this exact sequence and one time each (you can use
[InOrder](https://mockito.googlecode.com/hg-history/1.6/javadoc/org/mockito/InOrder.html)
to ensure the order and times that a method was called). Methods that would do
the part 1, 2 and 3 could have unit tests.
At the end, you could create a Javadoc for those methods using all four
comment blocks that you created.
Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
