Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1302#issuecomment-212873785
@priyankparihar we'll need a unit test that shows that this change is
backward compatible. I like that we're considering both default instance name
with host name here (i.e. the names should be globally unique) but we'll need
few more units tests to make sure the contract is not broken again in future.
We've changed how internal/external vmware vm names are composed 3-4 times
since 4.0, can you explain why we want to do this again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
