Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1179#discussion_r46767881
--- Diff:
plugins/network-elements/ovs/src/com/cloud/network/element/OvsElement.java ---
@@ -488,50 +494,54 @@ public boolean applyPFRules(final Net
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1177#issuecomment-162286584
LGTM based on these tests:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=true \
component/test_
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1175#issuecomment-162286626
LGTM based on these tests:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=true \
component/test_
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1179#issuecomment-162287415
LGTM based on these tests:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=true \
component/test_
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1057#issuecomment-162287862
LGTM based on these tests:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=true \
component/test_
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1178#issuecomment-162287978
LGTM based on these tests:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=true \
component/test_
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/1094#issuecomment-162302939
@nvazquez I've been able to verify that the existing tests did not break
with your PR, however I can't seem to get an NSX configuration for running the
two
It is in the admin guide already.
> On 06 Dec 2015, at 12:00, Rohit Yadav (JIRA) wrote:
>
>
>[
> https://issues.apache.org/jira/browse/CLOUDSTACK-9111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15043822#comment-15043822
> ]
>
> Rohit Yadav co
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1176#discussion_r46769041
--- Diff:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/XenServerGuru.java ---
@@ -185,7 +185,8 @@ public boolean trackVmHostChange() {
Zitat von dev-h...@cloudstack.apache.org:
Hi! This is the ezmlm program. I'm managing the
dev@cloudstack.apache.org mailing list.
I'm working for my owner, who can be reached
at dev-ow...@cloudstack.apache.org.
To confirm that you would like
norbert.kl...@infosecprojects.net
removed from
Github user wilderrodrigues commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1179#discussion_r46769789
--- Diff:
plugins/network-elements/ovs/src/com/cloud/network/element/OvsElement.java ---
@@ -488,50 +494,54 @@ public boolean applyPFRules(final
Github user wilderrodrigues commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1179#discussion_r46769848
--- Diff: server/src/com/cloud/network/element/VirtualRouterElement.java ---
@@ -841,24 +857,26 @@ public VirtualRouterProvider addElement(final L
Github user serg38 commented on the pull request:
https://github.com/apache/cloudstack/pull/1094#issuecomment-162319994
Since you are testing L3 connectivity existing switch patch to router
shouldn't overlap an ip range used by the new subnet. Cidr #1 should work fine
. You might also
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/1094#issuecomment-162321883
@serg38 I will use CIDR 1 and disconnect the switch from the router, to se
if that works. I haven't' seen any think left behind after testing. That is,
the
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1179#discussion_r46771839
--- Diff: server/src/com/cloud/network/element/VirtualRouterElement.java ---
@@ -841,24 +857,26 @@ public VirtualRouterProvider addElement(final Long
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1179#issuecomment-162324443
@remibergsma I think I am being captain obvious (as my new colleagues like
to call each other) but let's add them to the standard run.
---
If your project is
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1177#issuecomment-162331595
lgtm, but can you squash these commits to no longer include a revert,
@ustcweizhou ? thanks
---
If your project is set up for it, you can reply to this email
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1177#issuecomment-162331667
@snuf are you, as the author of the ovm3 hypervisor plugin, alright with
this?
---
If your project is set up for it, you can reply to this email and have your
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1176#discussion_r46773579
--- Diff:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/XenServerGuru.java ---
@@ -185,7 +185,8 @@ public boolean trackVmHostChange() {
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1176#issuecomment-162332724
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/977#issuecomment-162334352
@wido any reason we shouldn't merge this in before 4.7?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub a
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1086#issuecomment-162335446
two lgtm, no response to the the answers on reviews so merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1086
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1154#issuecomment-162336048
code looks good to me
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1161#issuecomment-162336211
lgtm, merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have thi
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1161
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1168#issuecomment-162336441
code lgtm and since @ustcweizhou and @anshul1886 agree on how to solve this
and @remibergsma did the tests, i am merging this
---
If your project is set up fo
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1177#issuecomment-162337123
lgtm, merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have thi
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1177
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1168
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1057
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1049#issuecomment-162337898
merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feat
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1049
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/850
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1056#issuecomment-162339708
#1177 obsoleted this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user DaanHoogland closed the pull request at:
https://github.com/apache/cloudstack/pull/1056
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feat
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1060#issuecomment-162339782
@rafaelweingartner we still allow for 1.7 so no 1.8 only features for now
---
If your project is set up for it, you can reply to this email and have your
reply
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1056#issuecomment-162339992
Actually, the one that obsoleted this is #1124
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as w
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1176
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1175#issuecomment-162340165
lgtm merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1175
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1167
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1165#issuecomment-162341273
@priyankparihar I do not know any vmware users
@bhaisaab Do you have any insight on this change? or do you know any
candidate reviewer for this?
---
If yo
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1179#issuecomment-162341294
@DaanHoogland Yes, sir! See linked PR above.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1162#issuecomment-162341391
lgtm
@remibergsma can you schedule a regression?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user ustcweizhou commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1176#discussion_r46774983
--- Diff:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/XenServerGuru.java ---
@@ -185,7 +185,8 @@ public boolean trackVmHostChange() {
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1094#issuecomment-162342223
Guys, I cannot build a cloud from this branch any more. The build itself
works, but the database deployment gives an SQL error: `Can't DROP
'logicalrouter_uuid'
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1179#issuecomment-162342338
Run this test: `nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=true smoke/test_privategw_acl.py`
Result:
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1152#discussion_r46775072
--- Diff: api/src/com/cloud/user/AccountService.java ---
@@ -136,4 +140,6 @@ void checkAccess(Account account, AccessType
accessType, boolean sameOw
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1152#issuecomment-162342597
@kansal looking forward to your update. your intended change makes sense
---
If your project is set up for it, you can reply to this email and have your
reply
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1156#issuecomment-162342696
@sanju1010 Thanks for the PR. Can you make it PEP8 compliant again please?
Most tests seem to create the offering the test needs. Isn't that a better
id
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1162#issuecomment-162342893
@DaanHoogland That makes no sense. We should build RPMs and install mgt
server from it and test both the new and existing features. The integration
tests do not
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1150#discussion_r46775285
--- Diff: ui/scripts/instanceWizard.js ---
@@ -731,25 +746,33 @@
//step 1 : select zone
$.extend(deployVmData
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1148#issuecomment-162344831
@wenwenxiong can you add tests and or test data to this? any combination of
- unit tests
- marvin tests
- test procedure
thanks
---
If you
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1056#issuecomment-162345306
@rafaelweingartner you better read #1177, part of #1124 will no longer
merge cleanly because of the ovm3 changes.
---
If your project is set up for it, you ca
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/830#issuecomment-162345934
PIng @DaanHoogland can you review this please? I'll run some tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/823#issuecomment-162346076
Pinging @DaanHoogland to review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/815#issuecomment-162346266
Pinging @DaanHoogland to review. Will run some tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as w
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1056#issuecomment-162353745
@DaanHoogland PR #1124 rebased on top of master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46777687
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/usage/GetUsageRecordsCmd.java
---
@@ -111,6 +111,30 @@ public Long getProjectId() {
p
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46777696
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/usage/GetUsageRecordsCmd.java
---
@@ -111,6 +111,30 @@ public Long getProjectId() {
p
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r4622
--- Diff: engine/schema/src/com/cloud/upgrade/dao/Upgrade461to470.java ---
@@ -51,8 +53,23 @@ public boolean supportsRollingUpgrade() {
retur
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r4624
--- Diff: engine/schema/src/com/cloud/upgrade/dao/Upgrade461to470.java ---
@@ -51,8 +53,23 @@ public boolean supportsRollingUpgrade() {
retur
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r4638
--- Diff: engine/schema/src/com/cloud/usage/UsageVO.java ---
@@ -328,4 +339,48 @@ public Date getStartDate() {
public Date getEndDate() {
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r4633
--- Diff: engine/schema/src/com/cloud/usage/UsageVO.java ---
@@ -328,4 +339,48 @@ public Date getStartDate() {
public Date getEndDate() {
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46777893
--- Diff: framework/db/src/com/cloud/utils/db/Transaction.java ---
@@ -35,18 +35,15 @@
if (currentTxn != null) {
databaseId
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46782245
--- Diff:
framework/quota/src/org/apache/cloudstack/quota/QuotaAlertManagerImpl.java ---
@@ -0,0 +1,408 @@
+//Licensed to the Apache Software Foundat
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46782964
--- Diff:
framework/quota/src/org/apache/cloudstack/quota/QuotaStatementImpl.java ---
@@ -0,0 +1,376 @@
+//Licensed to the Apache Software Foundation
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46782968
--- Diff:
framework/quota/src/org/apache/cloudstack/quota/QuotaStatementImpl.java ---
@@ -0,0 +1,376 @@
+//Licensed to the Apache Software Foundation
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46783089
--- Diff:
framework/quota/src/org/apache/cloudstack/quota/constant/QuotaConfig.java ---
@@ -0,0 +1,53 @@
+//Licensed to the Apache Software Foundatio
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46783125
--- Diff:
framework/quota/src/org/apache/cloudstack/quota/constant/QuotaConfig.java ---
@@ -0,0 +1,53 @@
+//Licensed to the Apache Software Foundatio
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46783314
--- Diff:
framework/quota/src/org/apache/cloudstack/quota/dao/QuotaTariffDaoImpl.java ---
@@ -0,0 +1,131 @@
+//Licensed to the Apache Software Founda
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46783388
--- Diff:
framework/quota/src/org/apache/cloudstack/quota/vo/QuotaUsageVO.java ---
@@ -0,0 +1,177 @@
+//Licensed to the Apache Software Foundation (A
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46783384
--- Diff:
framework/quota/src/org/apache/cloudstack/quota/vo/QuotaUsageVO.java ---
@@ -0,0 +1,177 @@
+//Licensed to the Apache Software Foundation (A
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46783406
--- Diff:
framework/quota/src/org/apache/cloudstack/quota/vo/QuotaUsageVO.java ---
@@ -0,0 +1,177 @@
+//Licensed to the Apache Software Foundation (A
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46784092
--- Diff:
framework/quota/test/org/apache/cloudstack/quota/QuotaStatementTest.java ---
@@ -0,0 +1,248 @@
+// Licensed to the Apache Software Foundati
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46784117
--- Diff:
framework/quota/test/org/apache/cloudstack/quota/QuotaStatementTest.java ---
@@ -0,0 +1,248 @@
+// Licensed to the Apache Software Foundati
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46784126
--- Diff:
framework/quota/test/org/apache/cloudstack/quota/QuotaStatementTest.java ---
@@ -0,0 +1,248 @@
+// Licensed to the Apache Software Foundati
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46784145
--- Diff:
framework/quota/test/org/apache/cloudstack/quota/QuotaStatementTest.java ---
@@ -0,0 +1,248 @@
+// Licensed to the Apache Software Foundati
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46784176
--- Diff:
framework/quota/test/org/apache/cloudstack/quota/QuotaStatementTest.java ---
@@ -0,0 +1,248 @@
+// Licensed to the Apache Software Foundati
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46784185
--- Diff:
framework/quota/test/org/apache/cloudstack/quota/QuotaStatementTest.java ---
@@ -0,0 +1,248 @@
+// Licensed to the Apache Software Foundati
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46784229
--- Diff:
framework/quota/test/org/apache/cloudstack/quota/QuotaManagerImplTest.java ---
@@ -0,0 +1,203 @@
+// Licensed to the Apache Software Founda
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46784268
--- Diff:
framework/quota/test/org/apache/cloudstack/quota/QuotaManagerImplTest.java ---
@@ -0,0 +1,203 @@
+// Licensed to the Apache Software Founda
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46784283
--- Diff:
framework/quota/test/org/apache/cloudstack/quota/QuotaManagerImplTest.java ---
@@ -0,0 +1,203 @@
+// Licensed to the Apache Software Founda
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46784327
--- Diff:
framework/quota/test/org/apache/cloudstack/quota/QuotaAlertManagerImplTest.java
---
@@ -0,0 +1,205 @@
+// Licensed to the Apache Software
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46784388
--- Diff:
framework/quota/test/org/apache/cloudstack/quota/QuotaAlertManagerImplTest.java
---
@@ -0,0 +1,205 @@
+// Licensed to the Apache Software
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46784395
--- Diff:
framework/quota/test/org/apache/cloudstack/quota/QuotaAlertManagerImplTest.java
---
@@ -0,0 +1,205 @@
+// Licensed to the Apache Software
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46784408
--- Diff:
framework/quota/test/org/apache/cloudstack/quota/QuotaAlertManagerImplTest.java
---
@@ -0,0 +1,205 @@
+// Licensed to the Apache Software
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46784435
--- Diff:
framework/quota/test/org/apache/cloudstack/quota/QuotaManagerImplTest.java ---
@@ -0,0 +1,203 @@
+// Licensed to the Apache Software Founda
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46784536
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaBalanceCmd.java
---
@@ -0,0 +1,125 @@
+//Licensed to the Apache Software
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46784547
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaBalanceCmd.java
---
@@ -0,0 +1,125 @@
+//Licensed to the Apache Software
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46784552
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaBalanceCmd.java
---
@@ -0,0 +1,125 @@
+//Licensed to the Apache Software
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46784560
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaBalanceCmd.java
---
@@ -0,0 +1,125 @@
+//Licensed to the Apache Software
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46784647
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/usage/GetUsageRecordsCmd.java
---
@@ -111,6 +111,30 @@ public Long getProjectId() {
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46784609
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaStatementCmd.java
---
@@ -0,0 +1,141 @@
+//Licensed to the Apache Softwa
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46784636
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/usage/GetUsageRecordsCmd.java
---
@@ -111,6 +111,30 @@ public Long getProjectId() {
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46784622
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaStatementCmd.java
---
@@ -0,0 +1,141 @@
+//Licensed to the Apache Softwa
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46784658
--- Diff: engine/schema/src/com/cloud/usage/UsageVO.java ---
@@ -328,4 +339,48 @@ public Date getStartDate() {
public Date getEndDate()
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46784665
--- Diff: framework/db/src/com/cloud/utils/db/Transaction.java ---
@@ -35,18 +35,15 @@
if (currentTxn != null) {
da
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r46784639
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaStatementCmd.java
---
@@ -0,0 +1,141 @@
+//Licensed to the Apache Softwa
1 - 100 of 136 matches
Mail list logo
