Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1176#discussion_r46773579
--- Diff:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/XenServerGuru.java ---
@@ -185,7 +185,8 @@ public boolean trackVmHostChange() {
DataTO srcData = cpyCommand.getSrcTO();
DataTO destData = cpyCommand.getDestTO();
- if (srcData.getObjectType() == DataObjectType.SNAPSHOT &&
destData.getObjectType() == DataObjectType.TEMPLATE) {
+ if (srcData.getHypervisorType() == HypervisorType.XenServer &&
srcData.getObjectType() == DataObjectType.SNAPSHOT &&
--- End diff --
@anshul1886 I looked it up. @bhaisaab @ustcweizhou Anshul is right about
the equals versus ==, for readability it makes sense to leave this as is. from
8.9 in the language specs:
Because there is only one instance of each enum constant, it is permitted
to use the == operator in place of the equals method when comparing two object
references if it is known that at least one of them refers to an enum constant.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
