[GitHub] cloudstack pull request: [4.5] rate-limit: increase JVM memory and...

GitHub user bhaisaab opened a pull request: https://github.com/apache/cloudstack/pull/1170 [4.5] rate-limit: increase JVM memory and enable fork mode for unit tests Enables forkmode for surefire plugin and increases memory opts for JVM for rate-limit tests. This tries to fix inte

[GitHub] cloudstack pull request: [4.6/master] rate-limit: increase JVM mem...

GitHub user bhaisaab opened a pull request: https://github.com/apache/cloudstack/pull/1171 [4.6/master] rate-limit: increase JVM memory and enable fork mode for unit tests Enables forkmode for surefire plugin and increases memory opts for JVM for rate-limit tests. This tries to

[GitHub] cloudstack pull request: CLOUDSTACK-9107: Description of global co...

GitHub user koushik-das opened a pull request: https://github.com/apache/cloudstack/pull/1172 CLOUDSTACK-9107: Description of global config agent.load.threshold an… …d the actual behavior are not in sync Made configuration parameter description and behavior in sync. You

Re: [4.6.1/4.7.0] Database upgrade path issues/forks between 4.6.0/4.6.1 and 4.7.0/master

Rohit, First of all good catch. I think we need to remove the 460to470 step and have the path always pass by 4.6.1. Are you busy with this change already? On Fri, Dec 4, 2015 at 6:03 AM, Rohit Yadav wrote: > There seems to be a db view related change between 4.6.0 and 4.6.1 (DB) > versions; and

Re: [4.6.1/4.7.0] Database upgrade path issues/forks between 4.6.0/4.6.1 and 4.7.0/master

Hi Daan, I’m testing quota but can work on it in 1-2 hours. So, not started yet but if you got time go ahead, and later I can help review/merge your PR. Regards. On 04-Dec-2015, at 2:15 PM, Daan Hoogland mailto:daan.hoogl...@gmail.com>> wrote: Rohit, First of all good catch. I think we need to

Re: [4.6.1/4.7.0] Database upgrade path issues/forks between 4.6.0/4.6.1 and 4.7.0/master

I gave it a quick shot. A test build is running and I'll create the pr in a minute. On Fri, Dec 4, 2015 at 9:51 AM, Rohit Yadav wrote: > Hi Daan, I’m testing quota but can work on it in 1-2 hours. So, not > started yet but if you got time go ahead, and later I can help review/merge > your PR. >

[GitHub] cloudstack pull request: 4.6.0 upgrade path is to pass 4.6.1 to cr...

GitHub user DaanHoogland opened a pull request: https://github.com/apache/cloudstack/pull/1173 4.6.0 upgrade path is to pass 4.6.1 to create the extra view in there test build done only You can merge this pull request into a Git repository by running: $ git pull https://github.

[GitHub] cloudstack pull request: Send arping to the gateway instead of our...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1163#issuecomment-161915494 @DaanHoogland Yes, that one fails quite regularly and I think that is related. Although without this fix it also passes, just not always (can be explained by ip

[GitHub] cloudstack pull request: Send arping to the gateway instead of our...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1163#issuecomment-161915571 Full integration tests pass: ``` nosetests --with-marvin --marvin-config=${marvinCfg} -s -a tags=advanced,required_hardware=true \ component/test_vpc

[GitHub] cloudstack pull request: Send arping to the gateway instead of our...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1163#issuecomment-161916594 please merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack pull request: debian: allow rules to pick ACS_BUILD_OPT...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1169#issuecomment-161916597 Thanks @bhaisaab I will merge this now, as I count the LGTMs in PR #1149 (in this case running the tests again is not needed). --- If your project is set up fo

[GitHub] cloudstack pull request: debian: allow rules to pick ACS_BUILD_OPT...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1169 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Send arping to the gateway instead of our...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1163#issuecomment-161916986 @DaanHoogland I will count that as a LGTM and will ask @wilderrodrigues to also review. --- If your project is set up for it, you can reply to this email and h

[GitHub] cloudstack pull request: Removal of class AgentBasedStandaloneCons...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/855#issuecomment-161918331 @rafaelweingartner @alexandrelimassantana Did you test whether the console proxy is still in there? @anshul1886 Do you or any of your colleagues have the opo

[GitHub] cloudstack pull request: CLOUDSTACK-9100: ISO.CREATE/TEMPLATE.CREA...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1157#issuecomment-161918736 LGTM based on these tests: ``` nosetests --with-marvin --marvin-config=${marvinCfg} -s -a tags=advanced,required_hardware=true \ component/test_

[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-9004: Add features to Hy...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1013#issuecomment-161919315 LGTM based on these tests: ``` nosetests --with-marvin --marvin-config=${marvinCfg} -s -a tags=advanced,required_hardware=true \ component/test_

[GitHub] cloudstack pull request: CLOUDSTACK-9086: ACS allows to create iso...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1125#issuecomment-161919700 LGTM based on these tests: ``` nosetests --with-marvin --marvin-config=${marvinCfg} -s -a tags=advanced,required_hardware=true \ component/test_

[GitHub] cloudstack pull request: [4.6/master] rate-limit: increase JVM mem...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1171#issuecomment-161920716 @bhaisaab How can I help testing this? Also, your branch mentions 4.6 but the PR is made against master branch. Is that correct? Just checking ;-) --- If your

[GitHub] cloudstack pull request: Fixed return type Void to void in DataMot...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/969#issuecomment-161920931 LGTM, will start a regression suite --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

[GitHub] cloudstack pull request: Send arping to the gateway instead of our...

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1163#issuecomment-161921580 Hi there... Also got my LGTM! So it's now 2. :) Cheers, Wilder --- If your project is set up for it, you can reply to this email and h

[GitHub] cloudstack pull request: CLOUDSTACK-9025: Fixed can't create usabl...

GitHub user anshul1886 opened a pull request: https://github.com/apache/cloudstack/pull/1174 CLOUDSTACK-9025: Fixed can't create usable template from snapshot in Xenserver and Vmware https://issues.apache.org/jira/browse/CLOUDSTACK-9025 Fix also reverts below commit as belo

[GitHub] cloudstack pull request: [4.6/master] rate-limit: increase JVM mem...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1171#issuecomment-161921440 @remibergsma thanks, not sure why this happened again. This was supposed to be for 4.6, will recreate a new PR. I'm not sure on how to test it, it's just that Jenk

[GitHub] cloudstack pull request: Send arping to the gateway instead of our...

Github user snuf commented on the pull request: https://github.com/apache/cloudstack/pull/1163#issuecomment-161921763 Aloha, Nice find Remi, thanks for fixing this! LGTM. Cheers, Funs --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack pull request: [4.6/master] rate-limit: increase JVM mem...

GitHub user bhaisaab opened a pull request: https://github.com/apache/cloudstack/pull/1175 [4.6/master] rate-limit: increase JVM memory and enable fork mode for unit tests Enables forkmode for surefire plugin and increases memory opts for JVM for rate-limit tests. This tries to

[GitHub] cloudstack pull request: [4.6/master] rate-limit: increase JVM mem...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1171#issuecomment-161922013 @remibergsma okay, I found what Github did in my case: when you select the second branch dropdown while create a PR it resets the first dropdown branch to master

[GitHub] cloudstack pull request: [4.6/master] rate-limit: increase JVM mem...

Github user bhaisaab closed the pull request at: https://github.com/apache/cloudstack/pull/1171 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: Send arping to the gateway instead of our...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1163 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-9025: Fixed can't create usabl...

GitHub user anshul1886 opened a pull request: https://github.com/apache/cloudstack/pull/1176 CLOUDSTACK-9025: Fixed can't create usable template from snapshot in Xenserver and Vmware https://issues.apache.org/jira/browse/CLOUDSTACK-9025 Fix also reverts below commit as belo

[GitHub] cloudstack pull request: CLOUDSTACK-9025: Fixed can't create usabl...

Github user anshul1886 closed the pull request at: https://github.com/apache/cloudstack/pull/1174 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] cloudstack pull request: Send arping to the gateway instead of our...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1163#issuecomment-161923353 Thanks guys, will reduce the number of false positives by some --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: Send arping to the gateway instead of our...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1163#issuecomment-161923441 Nice :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request: CLOUDSTACK-9025: Fixed can't create usabl...

Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/1176#issuecomment-161926055 @anshul1886 I do not have Xenserver, so I do not test it. However, I have to say that the issue CLOUDSTACK-8964 will appear again with this commit. --- If

[GitHub] cloudstack pull request: Removal of class AgentBasedStandaloneCons...

Github user anshul1886 commented on the pull request: https://github.com/apache/cloudstack/pull/855#issuecomment-161926840 This file could be used while fixing some time taking bugs in Console Proxy code. It can be used in similar way as described on https://cwiki.apache.org/confluenc

[GitHub] cloudstack pull request: Add support for not (re)starting server a...

Github user ProjectMoon commented on the pull request: https://github.com/apache/cloudstack/pull/1162#issuecomment-161926917 Removed the unintentional change to the initLoging (sic) method. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: Removed the PlannerBase class because it ...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1108#issuecomment-161927037 There is a lot of LGTM here (including mine) but did anybody do any relevant tests with this code? --- If your project is set up for it, you can reply to this

[GitHub] cloudstack pull request: CLOUDSTACK-9025: Fixed can't create usabl...

Github user anshul1886 commented on the pull request: https://github.com/apache/cloudstack/pull/1176#issuecomment-161927620 @ustcweizhou That bug is already taken care in Ovm3 guru code with commit 66fed46 --- If your project is set up for it, you can reply to this email and have you

[GitHub] cloudstack pull request: CLOUDSTACK-9103 : Missing OS Mappings for...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1159#issuecomment-161927649 @maneesha-p It doesn't hurt to put this statement every where but let's reduce the number of paths. as 4.6.0 to 4.6.1 contains a new view, I made a pr to re-ro

[GitHub] cloudstack pull request: 4.6.0 upgrade path is to pass 4.6.1 to cr...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1173#issuecomment-161929046 LGTM, thanks @DaanHoogland for fixing this so fast --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cloudstack pull request: 4.6.0 upgrade path is to pass 4.6.1 to cr...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1173#issuecomment-161929234 once merged on master, I'll rebase quota-master branch (the quota PR) with latest master and then fix it's db upgrade paths. --- If your project is set up for it,

[GitHub] cloudstack pull request: CLOUDSTACK-9025: Fixed can't create usabl...

Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/1176#issuecomment-161929602 @anshul1886 thanks for pointing out. I think it is not reasonable to send command to each hypervisorguru, so my suggestion is to not change HypervisorGuruM

[GitHub] cloudstack pull request: CLOUDSTACK-9025: Fixed can't create usabl...

Github user anshul1886 commented on the pull request: https://github.com/apache/cloudstack/pull/1176#issuecomment-161931232 @ustcweizhou I differ on this. We should not make HypervisorGuruManagerImpl complex by adding these kind of conditions as nobody is expert of all hypervisors and

[GitHub] cloudstack pull request: CLOUDSTACK-9087:adding projectid paramete...

Github user nitt10prashant commented on the pull request: https://github.com/apache/cloudstack/pull/1153#issuecomment-161931625 @pdube you are right projectid is not required , i did check API doc but got confused with UI and took it as doc bug. when createVMSnapshot is being calle

[GitHub] cloudstack pull request: CLOUDSTACK-9087:adding projectid paramete...

Github user nitt10prashant closed the pull request at: https://github.com/apache/cloudstack/pull/1153 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

[GitHub] cloudstack pull request: CLOUDSTACK-9105: Logging enhancement: Han...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1167#issuecomment-161932139 LGTM, no tests done --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

Re: release managers wanted

Hi Raja, Kinda missed your mail, sorry! Are you a committer? Would be great if you could help testing PRs, maybe run some BVT tests against them etc. That will allow to get them in sooner. Also, once we freeze we should test master again and make sure it is stable. Running the BVT against mast

[GitHub] cloudstack pull request: CLOUDSTACK-9107: Description of global co...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1172#discussion_r46669997 --- Diff: engine/orchestration/src/com/cloud/agent/manager/ClusteredAgentManagerImpl.java --- @@ -1411,14 +1411,12 @@ protected void runInContext()

[GitHub] cloudstack pull request: CLOUDSTACK-9107: Description of global co...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1172#issuecomment-161936477 LGTM (based on the code) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

[GitHub] cloudstack pull request: CLOUDSTACK-9107: Description of global co...

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1172#discussion_r46670189 --- Diff: engine/orchestration/src/com/cloud/agent/manager/ClusteredAgentManagerImpl.java --- @@ -1411,14 +1411,12 @@ protected void runInContext()

[GitHub] cloudstack pull request: CLOUDSTACK-8845: Fixed list snapshots com...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1166#issuecomment-161936797 @anshul1886 and @ustcweizhou can you guys go in a ring about this and 1168 please. Both address the same issue in a slightly different way. --- If your projec

[GitHub] cloudstack pull request: CLOUDSTACK-8845: set isRevertable of snap...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1168#issuecomment-161936820 @anshul1886 and @ustcweizhou can you guys go in a ring about this and 1166 please. Both address the same issue in a slightly different way. --- If your projec

[GitHub] cloudstack pull request: Add support for not (re)starting server a...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1162#discussion_r46670911 --- Diff: python/lib/cloudutils/serviceConfigServer.py --- @@ -135,9 +135,14 @@ def checkHostName(): self.syscfg.svo.disableServ

[GitHub] cloudstack pull request: Add support for not (re)starting server a...

Github user ProjectMoon commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1162#discussion_r46671185 --- Diff: python/lib/cloudutils/serviceConfigServer.py --- @@ -135,9 +135,14 @@ def checkHostName(): self.syscfg.svo.disableServi

[GitHub] cloudstack pull request: Add support for not (re)starting server a...

Github user ProjectMoon commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1162#discussion_r46671835 --- Diff: python/lib/cloudutils/serviceConfigServer.py --- @@ -135,9 +135,14 @@ def checkHostName(): self.syscfg.svo.disableServi

[GitHub] cloudstack pull request: Add support for not (re)starting server a...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1162#discussion_r46671886 --- Diff: python/lib/cloudutils/serviceConfigServer.py --- @@ -135,9 +135,14 @@ def checkHostName(): self.syscfg.svo.disableServ

[GitHub] cloudstack pull request: Strongswan vpn feature

Github user jayapalu commented on the pull request: https://github.com/apache/cloudstack/pull/872#issuecomment-161940413 @bhaisaab @remibergsma Started merging these commits into the latest master/4.6. Hopefully Monday it will be ready. @bhaisaab In strongswan ipsec observed

[GitHub] cloudstack pull request: Add support for not (re)starting server a...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1162#discussion_r46671989 --- Diff: python/lib/cloudutils/serviceConfigServer.py --- @@ -135,9 +135,14 @@ def checkHostName(): self.syscfg.svo.disableServ

[GitHub] cloudstack pull request: Add support for not (re)starting server a...

Github user ProjectMoon commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1162#discussion_r46672120 --- Diff: python/lib/cloudutils/serviceConfigServer.py --- @@ -135,9 +135,14 @@ def checkHostName(): self.syscfg.svo.disableServi

[GitHub] cloudstack pull request: CLOUDSTACK-8845: Fixed list snapshots com...

Github user ustcweizhou commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1166#discussion_r46672520 --- Diff: engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/StorageSystemSnapshotStrategy.java --- @@ -459,12 +463,8 @@ public Stra

[GitHub] cloudstack pull request: CLOUDSTACK-9086: ACS allows to create iso...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1125#discussion_r46672603 --- Diff: server/src/com/cloud/network/NetworkServiceImpl.java --- @@ -1197,6 +1197,10 @@ public Network createGuestNetwork(CreateNetworkCmd cmd) th

[GitHub] cloudstack pull request: CLOUDSTACK-9086: ACS allows to create iso...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1125#discussion_r46672736 --- Diff: server/src/com/cloud/network/NetworkServiceImpl.java --- @@ -1197,6 +1197,10 @@ public Network createGuestNetwork(CreateNetworkCmd cmd) th

[GitHub] cloudstack pull request: CLOUDSTACK-9099: SecretKey is returned fr...

Github user kansal commented on the pull request: https://github.com/apache/cloudstack/pull/1152#issuecomment-161944643 @jburwell Sure!! Will look into these. Adding the test cases and some UI changes for this to work. Will update the PR. --- If your project is set up for it, you can

[GitHub] cloudstack pull request: CLOUDSTACK-9086: ACS allows to create iso...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1125#discussion_r46672870 --- Diff: utils/src/main/java/com/cloud/utils/net/NetUtils.java --- @@ -1526,6 +1527,14 @@ public static boolean isIpWithtInCidrRange(final String i

[GitHub] cloudstack pull request: CLOUDSTACK-9086: ACS allows to create iso...

Github user kansal commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1125#discussion_r46673005 --- Diff: utils/src/main/java/com/cloud/utils/net/NetUtils.java --- @@ -1526,6 +1527,14 @@ public static boolean isIpWithtInCidrRange(final String ipAddre

[GitHub] cloudstack pull request: CLOUDSTACK-8845: Fixed list snapshots com...

Github user anshul1886 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1166#discussion_r46673018 --- Diff: engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/StorageSystemSnapshotStrategy.java --- @@ -459,12 +463,8 @@ public Strat

[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-9004: Add features to Hy...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1013#issuecomment-161948346 LGTM @jharshman can you make sure to add tests in follow-ups (both unit and integration)? --- If your project is set up for it, you can reply to this email an

[GitHub] cloudstack pull request: Changes made to DeployDataCenter to suppo...

Github user harikrishna-patnala commented on the pull request: https://github.com/apache/cloudstack/pull/809#issuecomment-161954435 I have not tested but did a code walk through. LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHu

[GitHub] cloudstack pull request: Removal of class AgentBasedStandaloneCons...

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/855#issuecomment-161957476 @anshul1886, we really tried to look up some doc about the use of that class, unfortunately nothing came up on our google searches. After reading the link

[GitHub] cloudstack pull request: Remove extraenous log dir and add catalin...

Github user jburwell commented on the pull request: https://github.com/apache/cloudstack/pull/1087#issuecomment-161975241 @PaulAngus sounds like a reasonable solution to preserve custom logrotate configurations on update. Can you push update the PR to remove commit ec698f5? --- If y

[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-9004: Add features to Hy...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1013 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: 4.6.0 upgrade path is to pass 4.6.1 to cr...

Github user pdube commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1173#discussion_r46685020 --- Diff: setup/db/db/schema-460to470.sql --- @@ -1,32 +0,0 @@ --- Licensed to the Apache Software Foundation (ASF) under one --- or more contributo

[GitHub] cloudstack pull request: CLOUDSTACK-9087:adding projectid paramete...

Github user pdube commented on the pull request: https://github.com/apache/cloudstack/pull/1153#issuecomment-161978474 @nitt10prashant No problemo --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] cloudstack pull request: 4.6.0 upgrade path is to pass 4.6.1 to cr...

Github user ustcweizhou commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1173#discussion_r46686423 --- Diff: setup/db/db/schema-460to470.sql --- @@ -1,32 +0,0 @@ --- Licensed to the Apache Software Foundation (ASF) under one --- or more cont

[GitHub] cloudstack pull request: Changes made to DeployDataCenter to suppo...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/809#issuecomment-161980229 @sanju1010 can you add a run output to the PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. I

[GitHub] cloudstack pull request: Removal of class AgentBasedStandaloneCons...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/855#issuecomment-161981047 Based on code review I can live with this, though I am not happy with wiki-links in javadoc. wiki links may change independant of versions of the code. --- If

[GitHub] cloudstack pull request: Changes made to DeployDataCenter to suppo...

Github user sanju1010 commented on the pull request: https://github.com/apache/cloudstack/pull/809#issuecomment-161982308 Sure Daan I will add . On Dec 4, 2015 7:58 PM, "Daan Hoogland" wrote: > @sanju1010 can you add a run output to the >

[GitHub] cloudstack pull request: 4.6.0 upgrade path is to pass 4.6.1 to cr...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1173#discussion_r46687151 --- Diff: setup/db/db/schema-460to470.sql --- @@ -1,32 +0,0 @@ --- Licensed to the Apache Software Foundation (ASF) under one --- or more con

Re: [VOTE] Apache CloudStack 4.6.1

Hi there! I tested the RC, but could not finish all the tests because faced a network disconnection (wifi) during the last ones! :( Got pretty much everything in place! My vote is +1 (binding) All the tests I got executed are below: KVM Host on CentOS 7.1 Management Server on CentOS 7.1 Crea

[GitHub] cloudstack pull request: 4.6.0 upgrade path is to pass 4.6.1 to cr...

Github user pdube commented on the pull request: https://github.com/apache/cloudstack/pull/1173#issuecomment-161987586 LGTM by code review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have th

[GitHub] cloudstack pull request: 4.6.0 upgrade path is to pass 4.6.1 to cr...

Github user ustcweizhou commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1173#discussion_r46694480 --- Diff: setup/db/db/schema-460to470.sql --- @@ -1,32 +0,0 @@ --- Licensed to the Apache Software Foundation (ASF) under one --- or more cont

[GitHub] cloudstack pull request: Removal of class AgentBasedStandaloneCons...

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/855#issuecomment-162006901 @DaanHoogland, I just used the link there because before the link that was presented by @anshul1886, we have not being able to find that page. I ag

[GitHub] cloudstack pull request: 4.6.0 upgrade path is to pass 4.6.1 to cr...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1173#discussion_r46698656 --- Diff: setup/db/db/schema-460to470.sql --- @@ -1,32 +0,0 @@ --- Licensed to the Apache Software Foundation (ASF) under one --- or more con

Re: [VOTE] Apache CloudStack 4.6.1

For the record, I’m also +1 (binding) on the RC, based on the tests I shared earlier. Regards, Remi On 04/12/15 15:58, "Wilder Rodrigues" wrote: >Hi there! > >I tested the RC, but could not finish all the tests because faced a network >disconnection (wifi) during the last ones! :( Got pr

[RESULT][VOTE] Apache CloudStack 4.6.1

Hi all, After 72+ hours, the vote for CloudStack 4.6.1 [1] *passes* with 4 PMC + 1 non-PMC votes. +1 (PMC / binding) * Rohit * Milamber * Wilder * Remi +1 (non binding) * Glenn 0 * Wido * Paul * Daan -1 none Thanks to everyone participating. I will now prepare the release announcement to go

[GitHub] cloudstack pull request: CLOUDSTACK-9025: Fixed can't create usabl...

Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/1176#issuecomment-162027142 @anshul1886 thanks a lot! now I agree with you that we should revert 66fed46. this PR LTGM, just one small comment. I will create another PR for

[GitHub] cloudstack pull request: CLOUDSTACK-9025: Fixed can't create usabl...

Github user ustcweizhou commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1176#discussion_r46707102 --- Diff: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/XenServerGuru.java --- @@ -185,7 +185,8 @@ public boolean trackVmHostChange() {

[GitHub] cloudstack pull request: CLOUDSTACK-8964: Ovm3HypervisorGuru handl...

GitHub user ustcweizhou opened a pull request: https://github.com/apache/cloudstack/pull/1177 CLOUDSTACK-8964: Ovm3HypervisorGuru handle only srcData with HypervisorType is Ovm3 This PR can only be applied after PR #1176 The CopyCommand on Ovm3 should be handled by Ovm3Sto

[GitHub] cloudstack pull request: CLOUDSTACK-9025: Fixed can't create usabl...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1176#issuecomment-162030592 LGTM, but just fix the .equals() --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project do

[GitHub] cloudstack pull request: 4.6.0 upgrade path is to pass 4.6.1 to cr...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1173#issuecomment-162030722 Merging now, that we've enough LGTMs. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proje

[GitHub] cloudstack pull request: 4.6.0 upgrade path is to pass 4.6.1 to cr...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1173 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Quota

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/768#issuecomment-162038916 @remibergsma I've rebased and fixed upgrade paths, made the icon smaller with fainter colours (it's still coloured but faded). When you enable the quota service fro

[GitHub] cloudstack pull request: Quota

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/768#issuecomment-162039438 This is what it looks like: ![screen shot 2015-12-04 at 11 42 18 pm](https://cloud.githubusercontent.com/assets/95203/11597357/3d8bf5ba-9ae1-11e5-98f4-e39046cc1f

[GitHub] cloudstack pull request: Strongswan vpn feature

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/872#issuecomment-162040698 @jayapalu thank for the update, unfortunately I couldn't find time to work on it but good to see you're working on it. I'm not sure about the restarts, but on VPC r

[GitHub] cloudstack pull request: CLOUDSTACK-9107: Description of global co...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1172#issuecomment-162043429 LGTM based on these tests: ``` nosetests --with-marvin --marvin-config=${marvinCfg} -s -a tags=advanced,required_hardware=true \ component/test_

[GitHub] cloudstack pull request: CLOUDSTACK-9107: Description of global co...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1172 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8845: set isRevertable of snap...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1168#issuecomment-162044783 LGTM based on these tests: ``` nosetests --with-marvin --marvin-config=${marvinCfg} -s -a tags=advanced,required_hardware=true \ component/test_

[GitHub] cloudstack pull request: CLOUDSTACK-9105: Logging enhancement: Han...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1167#issuecomment-162045526 LGTM based on these tests: ``` nosetests --with-marvin --marvin-config=${marvinCfg} -s -a tags=advanced,required_hardware=true \ component/test_

[GitHub] cloudstack pull request: CLOUDSTACK-9105: Logging enhancement: Han...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1167#issuecomment-162047910 Example logs from this branch: ``` 2015-12-04 18:37:14,864 DEBUG [c.c.s.StatsCollector] (StatsCollector-2:ctx-601c739d) (logid:52f7b0de) VmStatsCollector

[GitHub] cloudstack pull request: CLOUDSTACK-8845: Fixed list snapshots com...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1166#issuecomment-162048942 LGTM based on these tests: ``` nosetests --with-marvin --marvin-config=${marvinCfg} -s -a tags=advanced,required_hardware=true \ component/test_

[GitHub] cloudstack pull request: CLOUDSTACK-9025: Fixed can't create usabl...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1176#issuecomment-162050985 FYI, this integration test failed: ``` Create a VPC with two networks with one VM in each network and test nics after destroy ... === TestName: test_01_V

[GitHub] cloudstack pull request: CLOUDSTACK-9101: fix some issues in resiz...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1161#issuecomment-162051744 LGTM based on these tests: ``` nosetests --with-marvin --marvin-config=${marvinCfg} -s -a tags=advanced,required_hardware=true \ component/test_

  1   2   >