Github user ustcweizhou commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1166#discussion_r46672520
--- Diff:
engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/StorageSystemSnapshotStrategy.java
---
@@ -459,12 +463,8 @@ public StrategyPriority canHandle(Snapshot snapshot,
SnapshotOperation op) {
storagePoolId = volumeVO.getPoolId();
}
- if (SnapshotOperation.REVERT.equals(op)) {
- if (volumeVO != null &&
ImageFormat.QCOW2.equals(volumeVO.getFormat()))
- return StrategyPriority.DEFAULT;
- else
- return StrategyPriority.CANT_HANDLE;
- }
+ if (SnapshotOperation.REVERT.equals(op) && volumeVO != null &&
ImageFormat.QCOW2.equals(volumeVO.getFormat()))
--- End diff --
this can be moved to line 446.
in case volumeVO is not null , the only thing between these lines is
storagePoolId = volumeVO.getPoolId();
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
