Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1125#discussion_r46672870 --- Diff: utils/src/main/java/com/cloud/utils/net/NetUtils.java --- @@ -1526,6 +1527,14 @@ public static boolean isIpWithtInCidrRange(final String ipAddress, final String return isInRange; } + public static boolean isNetworkorBroadcastIP(String ip, String netmask){ --- End diff -- Can you add unit tests for this function?
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---