[GitHub] cloudstack pull request: CLOUDSTACK-8720: Handle corner case in re...

2015-08-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/671 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8723: Verify API call "listUsa...

2015-08-11 Thread pritisarap12
GitHub user pritisarap12 opened a pull request: https://github.com/apache/cloudstack/pull/675 CLOUDSTACK-8723: Verify API call "listUsageRecords" returns usage of new volume created after restore VM After restoring a running VM current ROOT disk gets destroyed and new ROOT disk get

Re: VR remote access vpn not working in master

2015-08-11 Thread Jayapal Reddy Uradi
Marked this bug as blocker because the remote access VPN functionality itself broken. Thanks, Jayapal On 31-Jul-2015, at 11:42 AM, Jayapal Reddy mailto:jayapalreddy.ur...@citrix.com>> wrote: Hi All, In latest master remote access vpn is not working because the configuration is not applied on

[Blocker/Critical] VR related Issues

2015-08-11 Thread Kishan Kavala
Below VR related issues currently open. Most of these issues did not exist in 4.5.x and are related to VR refactor (persistent VR). Blocker https://issues.apache.org/jira/browse/CLOUDSTACK-8690 - Remote Access VPN not working Critical https://issues.apache.org/jira/browse/CLOUDSTACK-8688 - Defa

[GitHub] cloudstack pull request: Implemented condition that only admin or ...

2015-08-11 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/658#issuecomment-129801929 @manuiiit Nice. LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

Re: Ec2stack not working with current aws cli

2015-08-11 Thread sebgoa
On Aug 10, 2015, at 11:25 PM, Carlos Reátegui wrote: > >> >> Can you make a PR that updates the README with this config option… > > Done. > thanks merged > >> >> thanks >> >>> On Aug 6, 2015, at 3:07 AM, Carlos Reategui wrote: >>> >>> BTW I figured out how to force the cli to send v2

[GitHub] cloudstack pull request: Implemented condition that only admin or ...

2015-08-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/658 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8723: Verify API call "listUsa...

2015-08-11 Thread nitt10prashant
Github user nitt10prashant commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/675#discussion_r36731289 --- Diff: test/integration/testpaths/testpath_usage.py --- @@ -2879,6 +2882,60 @@ def test_07_positive_tests_usage(self): # aggregation

[GitHub] cloudstack pull request: CLOUDSTACK-8723: Verify API call "listUsa...

2015-08-11 Thread nitt10prashant
Github user nitt10prashant commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/675#discussion_r36732367 --- Diff: test/integration/testpaths/testpath_usage.py --- @@ -2879,6 +2882,60 @@ def test_07_positive_tests_usage(self): # aggregation

[GitHub] cloudstack pull request: CLOUDSTACK-8717: Failed to start instance...

2015-08-11 Thread nitt10prashant
Github user nitt10prashant commented on the pull request: https://github.com/apache/cloudstack/pull/667#issuecomment-129836794 can we get test result ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack pull request: CLOUDSTACK-8717: Failed to start instance...

2015-08-11 Thread nitt10prashant
Github user nitt10prashant commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/667#discussion_r36733719 --- Diff: test/integration/testpaths/testpath_restore_vm.py --- @@ -0,0 +1,201 @@ +# Licensed to the Apache Software Foundation (ASF) under one

[GitHub] cloudstack pull request: CLOUDSTACK-8717: Failed to start instance...

2015-08-11 Thread nitt10prashant
Github user nitt10prashant commented on the pull request: https://github.com/apache/cloudstack/pull/667#issuecomment-129837984 can we get test results ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack pull request: CLOUDSTACK-8716: Verify creation of snaps...

2015-08-11 Thread nitt10prashant
Github user nitt10prashant commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/665#discussion_r36733882 --- Diff: test/integration/testpaths/testpath_multiple_snapshot.py --- @@ -0,0 +1,279 @@ +# Licensed to the Apache Software Foundation (ASF) und

[GitHub] cloudstack pull request: CLOUDSTACK-8716: Verify creation of snaps...

2015-08-11 Thread nitt10prashant
Github user nitt10prashant commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/665#discussion_r36734207 --- Diff: test/integration/testpaths/testpath_multiple_snapshot.py --- @@ -0,0 +1,279 @@ +# Licensed to the Apache Software Foundation (ASF) und

[GitHub] cloudstack pull request: CLOUDSTACK-8716: Verify creation of snaps...

2015-08-11 Thread nitt10prashant
Github user nitt10prashant commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/665#discussion_r36734361 --- Diff: test/integration/testpaths/testpath_multiple_snapshot.py --- @@ -0,0 +1,279 @@ +# Licensed to the Apache Software Foundation (ASF) und

[GitHub] cloudstack pull request: CLOUDSTACK-8723: Verify API call "listUsa...

2015-08-11 Thread pritisarap12
Github user pritisarap12 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/675#discussion_r36734678 --- Diff: test/integration/testpaths/testpath_usage.py --- @@ -2879,6 +2882,60 @@ def test_07_positive_tests_usage(self): # aggregation p

[GitHub] cloudstack pull request: CLOUDSTACK-8716: Verify creation of snaps...

2015-08-11 Thread nitt10prashant
Github user nitt10prashant commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/665#discussion_r36735392 --- Diff: test/integration/testpaths/testpath_multiple_snapshot.py --- @@ -0,0 +1,279 @@ +# Licensed to the Apache Software Foundation (ASF) und

[GitHub] cloudstack pull request: CLOUDSTACK-8716: Verify creation of snaps...

2015-08-11 Thread nitt10prashant
Github user nitt10prashant commented on the pull request: https://github.com/apache/cloudstack/pull/665#issuecomment-129846827 can you update test results ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack pull request: APIServlet, AuthCmd, SAML fixes

2015-08-11 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/650#discussion_r36737719 --- Diff: plugins/user-authenticators/saml2/src/org/apache/cloudstack/api/command/SAML2LoginAPIAuthenticatorCmd.java --- @@ -322,21 +306,11 @@ public St

[GitHub] cloudstack pull request: Improve debug message when the scheduler ...

2015-08-11 Thread milamberspace
GitHub user milamberspace opened a pull request: https://github.com/apache/cloudstack/pull/676 Improve debug message when the scheduler prepare to snapshot (volume … …'id' and add volume name) Signed-off-by: Milamber You can merge this pull request into a Git repositor

[GitHub] cloudstack pull request: [ACS4.5] Improve debug message when the s...

2015-08-11 Thread milamberspace
GitHub user milamberspace opened a pull request: https://github.com/apache/cloudstack/pull/677 [ACS4.5] Improve debug message when the scheduler prepare to snapshot (volume … …'id' and add volume name) Signed-off-by: Milamber You can merge this pull request into a Git

[GitHub] cloudstack pull request: Improve cloud-install-sys-tmplt to work i...

2015-08-11 Thread remibergsma
GitHub user remibergsma opened a pull request: https://github.com/apache/cloudstack/pull/678 Improve cloud-install-sys-tmplt to work in dev environment again The script that you run to initially setup secondary storage, had some errors. As it now depends on /etc/cloudstack/managemen

[GitHub] cloudstack pull request: CLOUDSTACK-8721: Fixed Setting details of...

2015-08-11 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/673#issuecomment-129868539 Thanks @anshul1886 will test it soon. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

[GitHub] cloudstack pull request: [ACS4.5] Improve debug message when the s...

2015-08-11 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/677#issuecomment-129868111 Code LGTM, we should also bring this to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. I

[GitHub] cloudstack pull request: [ACS4.5] Improve debug message when the s...

2015-08-11 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/677#issuecomment-129886138 @milamberspace Ah, only now noticed you sent two pull requests ;-) FYI: For 4.5, you can send a PR to master which we'll cherry-pick to 4.5. From 4.6 and

[GitHub] cloudstack pull request: Improve debug message when the scheduler ...

2015-08-11 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/676#issuecomment-129886755 Build failure not related to this change (cloudstack-pull-rats #256) Code LGTM --- If your project is set up for it, you can reply to this email and hav

[GitHub] cloudstack pull request: getUsedBytes should query the SolidFire c...

2015-08-11 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/674#issuecomment-129902187 I see now unit tests for getUsedBytes() and creatAsync(), the methods you changed only a generic package org.apache.cloudstack.storage.test. Can you expand on h

[GitHub] cloudstack pull request: Improve cloud-install-sys-tmplt to work i...

2015-08-11 Thread snuf
Github user snuf commented on the pull request: https://github.com/apache/cloudstack/pull/678#issuecomment-129909452 lgtm, tested and uploads without the file there now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cloudstack pull request: Improve cloud-install-sys-tmplt to work i...

2015-08-11 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/678#issuecomment-129910400 lgtm --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

RE: VR remote access vpn not working in master

2015-08-11 Thread Somesh Naidu
Is this open for voting? Is there a workaround/quickfix for this? Regards, Somesh -Original Message- From: Jayapal Reddy Uradi [mailto:jayapalreddy.ur...@citrix.com] Sent: Tuesday, August 11, 2015 4:53 AM To: dev@cloudstack.apache.org Subject: Re: VR remote access vpn not working in mast

Re: VR remote access vpn not working in master

2015-08-11 Thread Jayapal Reddy Uradi
There is no work around. Currently there are no code changes in VR to config the remote access vpn. Thanks, Jayapal On 11-Aug-2015, at 8:23 PM, Somesh Naidu wrote: > Is this open for voting? Is there a workaround/quickfix for this? > > Regards, > Somesh > > -Original Message- > From

[GitHub] cloudstack pull request: CLOUDSTACK-8721: Fixed Setting details of...

2015-08-11 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/673#issuecomment-129925883 @anshul1886 Tested your code, works just fine! LGTM. The only thing I noticed: excisting key/values are removed, then added again. So the net result is O

[GitHub] cloudstack pull request: Improve cloud-install-sys-tmplt to work i...

2015-08-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/678 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[Proposal] Minimise VR downtime during network update.

2015-08-11 Thread Bharat Kumar
Hi, Currently we use redundant virtual router enabled networks to prevent network outage even if one of the virtual router fails. This is achieved by using redundant virtual routers along with VRRP protocol. This has increased the network robustness. However updating a network with new network

Re: [Proposal] Minimise VR downtime during network update.

2015-08-11 Thread Daan Hoogland
Can you make a ticket on apache instead of referring an internal ticket? Can you describe how this work relates to the rvpc refactor work done for 4.6? On Tue, Aug 11, 2015 at 5:41 PM, Bharat Kumar wrote: > Hi, > > Currently we use redundant virtual router enabled networks to prevent > networ

Re: [Proposal] Minimise VR downtime during network update.

2015-08-11 Thread Bharat Kumar
Hi Daan, I am not aware of the work done for rVPC networks. I am still in the POC stage, will update the FS or scope it down depending on the changes related to rvpc, If there are too many changes may be i will restrict this to non vpc networks. I will create a apache ticket fro this work.

Re: [Blocker/Critical] VR related Issues

2015-08-11 Thread Remi Bergsma
Hi Kishan, Thanks for your mail, we clearly need to spend some time in debugging and fixing these issues. Let me look into the blocking Remote Access VPN issue (CLOUDSTACK-8690) and see if I can reproduce / fix it. Regards, Remi > On 11 Aug 2015, at 11:33, Kishan Kavala wrote: > > Below VR

[GitHub] cloudstack pull request: [WIP] Cloudstack 8656: do away with more ...

2015-08-11 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/654#discussion_r36763863 --- Diff: services/console-proxy/server/src/com/cloud/consoleproxy/vnc/packet/server/RawRect.java --- @@ -50,26 +52,27 @@ public void paint(Buffered

exception messages added

2015-08-11 Thread Daan Hoogland
H, CLOUDSTACK-8656 is not completely done with this pull request but I want to rest this work for a while. I got comments (thanks) and made some changes to adhere to peoples wishes. Can I get LGTM now? -- Daan

Re: [Proposal] Minimise VR downtime during network update.

2015-08-11 Thread Daan Hoogland
Thanks Bharat, One of the main implications of the rvpc refactor is that vpc routers and normal VRs are greatly unified. If you are working with master you will notice this. happy sailing, On Tue, Aug 11, 2015 at 5:57 PM, Bharat Kumar wrote: > Hi Daan, > > I am not aware of the work done for

How about using drone.io for cloudstack bugs and test

2015-08-11 Thread Keerthiraja SJ
Hi How about *Continuous Integration* for Github and Bitbucket that monitors your code for bugs. Kindly go through I believe this is free for the Public Projects. *https://drone.io/ * Thanks, Keerthi

[GitHub] cloudstack pull request: Added Virtualmachine count and ID's to li...

2015-08-11 Thread borisroman
GitHub user borisroman opened a pull request: https://github.com/apache/cloudstack/pull/679 Added Virtualmachine count and ID's to listSecurityGroups response See issue CLOUDSTACK-8133 for more information. You can merge this pull request into a Git repository by running: $ git

[GitHub] cloudstack pull request:

2015-08-11 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/commit/f4449b62d93e56d9f62fac06922b12381a51b8e4#commitcomment-12645845 The re-positioning of the imports is an automated feature of Eclipse. --- If your project is set up for it, you can reply

[GitHub] cloudstack pull request: getUsedBytes should query the SolidFire c...

2015-08-11 Thread mike-tutkowski
Github user mike-tutkowski commented on the pull request: https://github.com/apache/cloudstack/pull/674#issuecomment-129974204 I have internal functional tests that make use of a SolidFire system. On Tuesday, August 11, 2015, Daan Hoogland wrote: > I see now unit test

[GitHub] cloudstack pull request: Cloudstack 8656: do away with more silent...

2015-08-11 Thread mike-tutkowski
Github user mike-tutkowski commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/654#discussion_r36774764 --- Diff: services/console-proxy/server/src/com/cloud/consoleproxy/vnc/packet/server/RawRect.java --- @@ -50,26 +52,27 @@ public void paint(Buffer

[GitHub] cloudstack pull request: Cloudstack 8656: do away with more silent...

2015-08-11 Thread mike-tutkowski
Github user mike-tutkowski commented on the pull request: https://github.com/apache/cloudstack/pull/654#issuecomment-129990097 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featur

Re: Remi Bergsma joins the PMC

2015-08-11 Thread Remi Bergsma
Thanks everyone! Great working with you :-) > On 11 Aug 2015, at 07:44, Wilder Rodrigues > wrote: > > Congratulations, dude! > > Cheers, > Wilder > > Sent from my iPhone > >> On 10 Aug 2015, at 19:09, Daan Hoogland wrote: >> >> LS, >> >> Today the PMC has invited Remi Bergsma to join its

[GitHub] cloudstack pull request: getUsedBytes should query the SolidFire c...

2015-08-11 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/674#issuecomment-130091528 Code lgtm. can you publish the tests? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[GitHub] cloudstack pull request: Interface changes related to CLOUDSTACK-8...

2015-08-11 Thread borisroman
GitHub user borisroman opened a pull request: https://github.com/apache/cloudstack/pull/680 Interface changes related to CLOUDSTACK-8580 See issue CLOUDSTACK-8580 and individual commits. You can merge this pull request into a Git repository by running: $ git pull https://github

[GitHub] cloudstack pull request: getUsedBytes should query the SolidFire c...

2015-08-11 Thread mike-tutkowski
Github user mike-tutkowski commented on the pull request: https://github.com/apache/cloudstack/pull/674#issuecomment-130100258 I'd eventually like to. I'm in the process of setting up our test infrastructure so these kinds of tests can run automatically. Right now it's a combina

[Low Priority] Resource method names

2015-08-11 Thread Mike Tutkowski
I like these names. :) public long findCorrectResourceLimitForAccount(Account account, ResourceType type); public long findCorrectResourceLimitForAccount(long accountId, Long limit, ResourceType type); public long findCorrectResourceLimitForDomain(Domain domain, ResourceType type); What if I was

[GitHub] cloudstack pull request: Coverity regressions per 10 aug 2015

2015-08-11 Thread DaanHoogland
GitHub user DaanHoogland opened a pull request: https://github.com/apache/cloudstack/pull/681 Coverity regressions per 10 aug 2015 Not all are in here, the db upgrade code seems to stay the main pitfall. You can merge this pull request into a Git repository by running: $ git pu

Re: [Proposal] Replacing Openswan ipsec with Strongswan ipsec

2015-08-11 Thread Jayapal Reddy Uradi
Here is the FS[1] and ticket[2] details. [1]https://cwiki.apache.org/confluence/display/CLOUDSTACK/Replacing+openswan+ipsec+with+strongswan+ipsec [2]https://issues.apache.org/jira/browse/CLOUDSTACK-8682 Thanks, Jayapal On 27-Jul-2015, at 12:12 PM, Suresh Sadhu wrote: > +1 > > Kindly share a

Re: [Proposal] Replacing Openswan ipsec with Strongswan ipsec

2015-08-11 Thread Rohit Yadav
Jayapal - great and looking forward to it. As a test case, I would hope that with strongswan it would be possible to use both Mac and Windows VPN clients which was an issue with openswan - https://issues.apache.org/jira/browse/CLOUDSTACK-7087 On 12-Aug-2015, at 10:29 am, Jayapal Reddy Uradi ma

[GitHub] cloudstack pull request: Coverity regressions per 10 aug 2015

2015-08-11 Thread koushik-das
Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/681#issuecomment-130167859 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

Re: [Blocker/Critical] VR related Issues

2015-08-11 Thread Bharat Kumar
Hi, looks like there is one more issue. Conntrackd fails to start in case of rvr enabled isolated networks. created a bug to track this. https://issues.apache.org/jira/browse/CLOUDSTACK-8725 Thanks, Bharat. On 11-Aug-2015, at 3:03 pm, Kishan Kavala mailto:kishan.kav...@citrix.com>> wrote:

[GitHub] cloudstack pull request: Added Virtualmachine count and ID's to li...

2015-08-11 Thread koushik-das
Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/679#discussion_r36827811 --- Diff: server/src/com/cloud/api/query/dao/SecurityGroupJoinDaoImpl.java --- @@ -125,6 +130,14 @@ public SecurityGroupResponse newSecurityGroupResp

[GitHub] cloudstack pull request: Added Virtualmachine count and ID's to li...

2015-08-11 Thread koushik-das
Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/679#issuecomment-130175830 Please add tests. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have t

Re: [Low Priority] Resource method names

2015-08-11 Thread Rajani Karuturi
:) ~Rajani On Wed, Aug 12, 2015 at 5:11 AM, Mike Tutkowski < mike.tutkow...@solidfire.com> wrote: > I like these names. :) > > public long findCorrectResourceLimitForAccount(Account account, > ResourceType type); > > public long findCorrectResourceLimitForAccount(long accountId, Long limit, > Re

[GitHub] cloudstack pull request: getUsedBytes should query the SolidFire c...

2015-08-11 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/674#issuecomment-130186688 code lgtm --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request: Coverity regressions per 10 aug 2015

2015-08-11 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/681#issuecomment-130186820 Thanks for fixing these @DaanHoogland. :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If you

[GitHub] cloudstack pull request: [ACS4.5] Improve debug message when the s...

2015-08-11 Thread milamberspace
Github user milamberspace commented on the pull request: https://github.com/apache/cloudstack/pull/677#issuecomment-130187847 Ok thanks for your comment. I close this PR. I will cherry-pick the PR #676 on the 4.5 branch. --- If your project is set up for it, you can reply to this ema

[GitHub] cloudstack pull request: [ACS4.5] Improve debug message when the s...

2015-08-11 Thread milamberspace
Github user milamberspace closed the pull request at: https://github.com/apache/cloudstack/pull/677 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feat

RE: [Low Priority] Resource method names

2015-08-11 Thread Koushik Das
Please send out a PR with the fix. -Original Message- From: Rajani Karuturi [mailto:raj...@apache.org] Sent: Wednesday, 12 August 2015 12:02 To: dev@cloudstack.apache.org Subject: Re: [Low Priority] Resource method names :) ~Rajani On Wed, Aug 12, 2015 at 5:11 AM, Mike Tutkowski < mike