RE: deleteAffinityGroup API

Account and domainId are not required parameters of this API. It works fine with just an id too. Account and domain will be used if delete is called providing a name of the group instead of id, say by an admin for a regular user's group. -Original Message- From: Prasanna Santhanam [mai

Re: CallContexts?

On Thu, Jul 18, 2013 at 11:58:30AM +0530, Prasanna Santhanam wrote: > I see the following repeated lines with API calls on master code > lately: What's the call context? and what's the role? > > 2013-07-18 11:52:24,372 DEBUG [cloudstack.context.CallContext] > (RouterStatusMonitor-1:ctx-9bb138b4)

Re: Review Request 12700: Fix for CLOUDSTACK-3596 to include domain id

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12700/#review23357 --- Commit f5bd253b2b8d50bb42ce8a85b4d1db5b8e729b41 in branch refs/heads

Re: Review Request 12546: CLOUDSTACK-3168: test_network.py - Changed try_ssh function defn. Resolved Object NoneType issues

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12546/ --- (Updated July 18, 2013, 8:45 a.m.) Review request for cloudstack and Prasanna S

Re: deleteAffinityGroup API

On Thu, Jul 18, 2013 at 07:14:42AM +, Prachi Damle wrote: > Account and domainId are not required parameters of this API. It > works fine with just an id too. > > Account and domain will be used if delete is called providing a name > of the group instead of id, say by an admin for a regular us

Re: Review Request 12700: Fix for CLOUDSTACK-3596 to include domain id

> On July 18, 2013, 8:31 a.m., ASF Subversion and Git Services wrote: > > Commit f5bd253b2b8d50bb42ce8a85b4d1db5b8e729b41 in branch refs/heads/master > > from sailajam > > [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=f5bd253 ] > > > > CLOUDSTACK-3596: Domain ID missing to deploy

Review Request 12717: CLOUDSTACK-3618: [Automation] API call listprojectaccounts failed, and test case test_projects.py:test_08_cleanup_after_project_delete failed due to this.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12717/ --- Review request for cloudstack, Devdeep Singh and Prasanna Santhanam. Bugs: CLOU

Re: Review Request 12358: CLOUDSTACK-3228: system vms are not comming up in zone with two cluster xen and kvm

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12358/ --- (Updated July 18, 2013, 9:23 a.m.) Review request for cloudstack and Nitin Meht

Re: Review Request 12717: CLOUDSTACK-3618: [Automation] API call listprojectaccounts failed, and test case test_projects.py:test_08_cleanup_after_project_delete failed due to this.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12717/#review23359 --- Ship it! Ship It! - Prasanna Santhanam On July 18, 2013, 9:14 a.

RE: Quick Secondary Storage Question

tl;dr - your network config may result in a need for system VMs on both Xen and VMWare clusters. Long form: System VMs provide services that are not feasible to deploy alongside the CloudStack management server. Currently, there are three kinds: secondary storage management services (aka SSV

Re: Review Request 12632: CLOUDSTACK-3551: Fix value over flow due to type conversion

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12632/#review23360 --- Commit b4662af0a93c68b5a94e044bf56fc7e2c15efd63 in branch refs/heads

Re: Review Request 12546: CLOUDSTACK-3168: test_network.py - Changed try_ssh function defn. Resolved Object NoneType issues

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12546/#review23363 --- Commit e25cbd66d2b13db684f2f339b05aafa6b119bcfe in branch refs/heads

Re: Review Request 12546: CLOUDSTACK-3168: test_network.py - Changed try_ssh function defn. Resolved Object NoneType issues

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12546/#review23361 --- Commit f2d9a7b659087e599494ca98f7cfed2721179c49 in branch refs/heads

Re: Review Request 12717: CLOUDSTACK-3618: [Automation] API call listprojectaccounts failed, and test case test_projects.py:test_08_cleanup_after_project_delete failed due to this.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12717/#review23362 --- Commit 52fa8532bb2821f9b5472e713a905bc6b7f712b5 in branch refs/heads

Re: Review Request 12717: CLOUDSTACK-3618: [Automation] API call listprojectaccounts failed, and test case test_projects.py:test_08_cleanup_after_project_delete failed due to this.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12717/#review23364 --- Ship it! Ship It! - Prasanna Santhanam On July 18, 2013, 9:14 a.

Re: Review Request 12546: CLOUDSTACK-3168: test_network.py - Changed try_ssh function defn. Resolved Object NoneType issues

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12546/#review23365 --- Ship it! Ship It! - Prasanna Santhanam On July 18, 2013, 8:45 a.

Re: Review Request 12499: CLOUDSTACK-3376: NPE: resource count calculation from the account manager on account cleanup

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12499/#review23366 --- Commit c9548e37885bee6abf62c515c910fe29f9fcd7c6 in branch refs/heads

RE: Template Question

I am also seeing it. -Koushik > -Original Message- > From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com] > Sent: Wednesday, July 17, 2013 9:22 PM > To: dev@cloudstack.apache.org > Subject: Template Question > > Hi, > > I've noticed recently on XenServer when SSVM and CPVM are dep

RE: Template Question

Changes were made recently to allow some commands to execute in parallel on a hypervisor resource. Maybe that is causing it. Regards, Devdeep > -Original Message- > From: Koushik Das [mailto:koushik@citrix.com] > Sent: Thursday, July 18, 2013 3:11 PM > To: dev@cloudstack.apache.org >

Review Request 12719: CLOUDSTACK-3634: Adding router.template.xen/kvm/hyperv/kvm/lxc in upgrade setup

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12719/ --- Review request for cloudstack, Abhinandan Prateek and Kishan Kavala. Bugs: CLOU

Review Request 12720: CLOUDSTACK: 3382 Unable to Migrate VM's If the hosts are implicitly or explicitly dedicated.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12720/ --- Review request for cloudstack and Devdeep Singh. Bugs: 3382 Repository: cloud

Re: Review Request 12720: CLOUDSTACK: 3382 Unable to Migrate VM's If the hosts are implicitly or explicitly dedicated.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12720/#review23372 --- Do you think you can add a integration test to test_explicit_dedicat

Re: Review Request 11782: (CLOUDSTACK-1301) VM Disk I/O Throttling

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11782/#review23373 --- Commit 27b5085542cbc881ea1847e9b894d7723dc869db in branch refs/heads

Meet up on July 20th - Hyderabad, India

There is an upcoming meet up on July 20th at Hyderabad, India There will be talks on CS architecture and hacking with devcloud. Detailed info @ http://www.meetup.com/CloudStack-Hyderabad-Group/events/125208462/ Thanks, -Nitin

Re: [jira] [Closed] (CLOUDSTACK-3636) [Automation]Fix iintegration.component.test_accounts.TestServiceOfferingHierarchy.test_01_service_offering_hierarchy script

Can you apply the fixes on 4.2 as well? On Thu, Jul 18, 2013 at 11:38:49AM +, Sailaja Mada (JIRA) wrote: > > [ > https://issues.apache.org/jira/browse/CLOUDSTACK-3636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel > ] > > Sailaja Mada closed CLOUDSTACK-3636. > -

Re: Review Request 12720: CLOUDSTACK: 3382 Unable to Migrate VM's If the hosts are implicitly or explicitly dedicated.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12720/#review23375 --- Few comments: 1. You need to handle when migration with storage is t

Auto format javascript

Hi, Anybody have suggestions for automatically formatting javascript? Just going through some of the UI stuff and noticed the indentation is a bit all over the place. Thanks, Ian

RE: Review Request 12510: CLOUDSTACK 3476 : deleteDomain api should fail when release dedicated resource to that domain fails:

The fix should qualify for 4.1.1 Thanks, Saksham -Original Message- From: Musayev, Ilya [mailto:imusa...@webmd.net] Sent: Thursday, July 18, 2013 6:41 AM To: dev@cloudstack.apache.org; Alena Prokharchyk; Devdeep Singh Cc: Saksham Srivastava; cloudstack Subject: RE: Review Request 12510:

Re: Auto format javascript

+1 . I was thinking of proposing this thing too . JS code is a little messed up probably due to different editor settings being used in different environments by different people . One tool which I have used is http://jsbeautifier.org/ . But somebody would have to make the effort to manually copy

Re: Review Request 12700: Fix for CLOUDSTACK-3596 to include domain id

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12700/#review23377 --- Commit 3385b200faa929d2027c5e4743e58271f4d7ad56 in branch refs/heads

Re: deleteAffinityGroup API

On Thu, Jul 18, 2013 at 02:17:46PM +0530, Prasanna Santhanam wrote: > On Thu, Jul 18, 2013 at 07:14:42AM +, Prachi Damle wrote: > > Account and domainId are not required parameters of this API. It > > works fine with just an id too. > > > > Account and domain will be used if delete is called p

Re: Auto format javascript

Should be able to format them all at once using the node module of it Will install it and submit a patch over the next few minutes. Using something like http://editorconfig.org/ to keep styling the same for html/css/js based stuff might not be a bad idea. That site you recommended has a subli

Re: Auto format javascript

Awesome . Yeah it's an awesome auto-formatting tool , which I have used in the past !!:) On Thu, Jul 18, 2013 at 6:41 PM, Ian Duffy wrote: > Should be able to format them all at once using the node module of it > Will install it and submit a patch over the next few minutes. > > Using someth

Re: Review Request 12277: Add VHDX image support

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12277/#review23378 --- Ship it! Committed to master with commit id 876a7b3361a17bc16b1342f

Re: Review Request 12277: Add VHDX image support

> On July 18, 2013, 1:36 p.m., Devdeep Singh wrote: > > Committed to master with commit id 876a7b3361a17bc16b1342fdebbff0f0306674a6. Kindly close the request. - Devdeep --- This is an automatically generated e-mail. To reply, visit: htt

Re: [DISCUSS] Upgrade path to ACS 4.2 from CCP

On Wed, Jul 17, 2013 at 11:43:49PM +, Animesh Chaturvedi wrote: > > Folks > > We have an upgrade path from CCP 3.0.2 to 4.0 ACS and since then we have > diverged. I would like to propose adding upgrade path from later CCP versions > to ACS 4.2 which provides customers the choice to move to

Re: [DISCUSS] Upgrade path to ACS 4.2 from CCP

+1 I received the question from many clients about how to upgrade CCP 3.0.6 to ACS 4.1/4.2. 2013/7/18 Animesh Chaturvedi > > Folks > > We have an upgrade path from CCP 3.0.2 to 4.0 ACS and since then we have > diverged. I would like to propose adding upgrade path from later CCP > versions to AC

Review Request 12721: Formatting of CSS and JS files

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12721/ --- Review request for cloudstack, Abhinandan Prateek, Pranav Saxena, and Sebastien

Re: Review Request 11479: SolidFire storage plug-in and enhancements to the storage framework and GUI

> On May 31, 2013, 8:32 p.m., Wei Zhou wrote: > > Mike, > > > > I think it is better to create a table for SolidFire instead of changing > > disk_offering table. > > It is not a good idea to change disk_offering for a specific vendor. > > You can have a look at what nicira did in the past, mayb

Re: Review Request 11479: SolidFire storage plug-in and enhancements to the storage framework and GUI

> On June 28, 2013, 3:42 p.m., John Burwell wrote: > > api/src/com/cloud/offering/DiskOffering.java, line 60 > > > > > > When would it be valid for the value of this property to be null? > > Seems like it should be bo

Re: [ACS42] Release Status Update

Mike, Have you posted the diff with the resolved second round issues for the SolidFire patch to Review Board? Thanks, -John On Jun 28, 2013, at 12:49 PM, Mike Tutkowski wrote: > Hi John, > > OK, this sounds good. > > I updated from master yesterday and was resolving some (major) conflicts

Re: Review Request 12721: Formatting of CSS and JS files

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12721/ --- (Updated July 18, 2013, 2:47 p.m.) Review request for cloudstack, Abhinandan Pr

Review Request 12723: test for Script

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12723/ --- Review request for cloudstack. Repository: cloudstack-git Description ---

Re: Is it possible for reviewer to add other reviewers in the reviewboard?

So personally, I try my best to look at reviews whenever I have a spare moment. That's not all that frequent, but if everyone did that we would be moving new code into the repo much more effectively and efficiently. On Thu, Jul 18, 2013 at 11:42:01AM +0530, Prasanna Santhanam wrote: > Yes and I'

Re: Review Request 12716: Fix for NPE

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12716/#review23385 --- Ship it! Ship It! - Sheng Yang On July 18, 2013, 2:10 a.m., Venk

Re: Review Request 12660: Replaced multiple grep/awk/head commands by one awk

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12660/ --- (Updated July 18, 2013, 3:57 p.m.) Review request for cloudstack and Wido den H

Re: Review Request 12646: Truncated trailing/double spaces.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12646/ --- (Updated July 18, 2013, 4:07 p.m.) Review request for cloudstack and Wido den H

Re: Review Request 12646: Truncated trailing/double spaces.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12646/ --- (Updated July 18, 2013, 4:07 p.m.) Review request for cloudstack and Wido den H

Re: Is it possible for reviewer to add other reviewers in the reviewboard?

this has been kind of bugging me too. Along with unanswered questions on teh list by newbees like me. As we all depend on volunteers and conculeagues I don't really see a solution but reporting on outstanding reviews and maybe unanswered questions. The latter can only be done manually though, as it

Re: Review Request 12659: Removed unused script scripts/storage/qcow2/cleanupmyvms.sh

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12659/ --- (Updated July 18, 2013, 4:09 p.m.) Review request for cloudstack and Wido den H

Problem in adding Ceph RBD storage to CloudStack

Hi, I'm building a CloudStack 4.1 with Ceph RBD storage using RHEL 6.3 recently but it fails when adding RBD storage to primary storage. Does anybody know about the problem? 1. qemu (1.5.50, configured with "--enable-rbd") and libvirt (0.10.2, configured with "--with-storage-rbd") are installed t

Re: Review Request 12658: Corrected typos in log messages

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12658/ --- (Updated July 18, 2013, 4:07 p.m.) Review request for cloudstack and Wido den H

Re: Review Request 12679: CLOUDSTACK-904: Changed multiple vcpus to one vcpu with multiple sockets

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12679/ --- (Updated July 18, 2013, 4:06 p.m.) Review request for cloudstack and Wido den H

Re: Problem in adding Ceph RBD storage to CloudStack

Hi, On 07/18/2013 06:09 PM, Takuma Nakajima wrote: Hi, I'm building a CloudStack 4.1 with Ceph RBD storage using RHEL 6.3 recently but it fails when adding RBD storage to primary storage. Does anybody know about the problem? No, it works for me like a charm :) Could you set the Agent loggin

Re: Is it possible for reviewer to add other reviewers in the reviewboard?

On Thu, Jul 18, 2013 at 06:07:48PM +0200, Daan Hoogland wrote: > this has been kind of bugging me too. Along with unanswered questions on > teh list by newbees like me. As we all depend on volunteers and > conculeagues I don't really see a solution but reporting on outstanding > reviews and maybe u

Re: Problem in adding Ceph RBD storage to CloudStack

On Thu, Jul 18, 2013 at 12:09 PM, Takuma Nakajima wrote: > Hi, > > I'm building a CloudStack 4.1 with Ceph RBD storage using RHEL 6.3 recently > but it fails when adding RBD storage to primary storage. > Does anybody know about the problem? Why not 6.4?

Re: Review Request 12721: Formatting of CSS and JS files

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12721/#review23391 --- Ship it! Changes look good. I don't have an access to my machine fr

Re: Review Request 12721: Formatting of CSS and JS files

> On July 18, 2013, 4:24 p.m., Pranav Saxena wrote: > > Changes look good. I don't have an access to my machine from where I could > > commit your changes. Hence, request a committer to merge these into all the > > relevant branches. > > Thanks ! Okay will leave it as open until a committer me

Re: Review Request 12721: Formatting of CSS and JS files

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12721/#review23394 --- Ship it! committed to master ad69bc8da3244b783dd003ddf3184fca2762c5

Re: [ACS42] Release Status Update

Hi John, Oh, not yet...I am still working on one of your VMware issues. It should be done today or tomorrow, I expect. Thanks On Thu, Jul 18, 2013 at 8:47 AM, John Burwell wrote: > Mike, > > Have you posted the diff with the resolved second round issues for the > SolidFire patch to Review Boa

RE: [rant] stupid test cases

I don't believe this is a bad testcase. It's to force the code path on cleanup procedure before a domain is properly deleted. If this was a unit-test I would say there's no point. For a systems/integration test, the testcase makes sense. --Alex > -Original Message- > From: Prasanna

Re: Template Question

It does seem indeterministic. Sometimes there are two; sometimes there is only one. On Thu, Jul 18, 2013 at 4:23 AM, Devdeep Singh wrote: > Changes were made recently to allow some commands to execute in parallel > on a hypervisor resource. Maybe that is causing it. > > Regards, > Devdeep > > >

Regarding the bug Cloudstack-3589 VM created from VPC network is not getting IP

Hi Dann, The bug fix https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commitdiff;h=b903262df5e2ff5d174859ce28abae75c4689f0c is causing an null value in dnsmasq.config file while creating VPC network (bug-id Cloudstack-3589 ). Can you please take a look at this. Regards, Bharat.

Re: Review Request 11479: SolidFire storage plug-in and enhancements to the storage framework and GUI

> On May 31, 2013, 2:32 p.m., Wei Zhou wrote: > > Mike, > > > > I think it is better to create a table for SolidFire instead of changing > > disk_offering table. > > It is not a good idea to change disk_offering for a specific vendor. > > You can have a look at what nicira did in the past, mayb

Re: Review Request 11479: SolidFire storage plug-in and enhancements to the storage framework and GUI

> On June 28, 2013, 9:42 a.m., John Burwell wrote: > > api/src/com/cloud/offering/DiskOffering.java, line 60 > > > > > > When would it be valid for the value of this property to be null? > > Seems like it should be bo

Re: Is it possible for reviewer to add other reviewers in the reviewboard?

We need some mechanism to help on review board. Sometime the people didn't know who to ask for review and sometime committer push the code they didn't familiar with. I decided to spend much more time on reviewing code during 4.2 release period, trying to make sure I would review everything on netw

Why are these code in utils?

As part of the work to merge vmsync over to master, I've been combing through our code. I'm surprised to find the following code in the utils package. Cisco n1kv.vsm S3 Swift The intent of the utils package is to provide generic java software libraries that all other cloudstack libraries to us

Re: Why are these code in utils?

On Thu, Jul 18, 2013 at 05:01:54PM +, Alex Huang wrote: > As part of the work to merge vmsync over to master, I've been combing through > our code. > > I'm surprised to find the following code in the utils package. > > Cisco n1kv.vsm > S3 > Swift > > The intent of the utils package is to pr

Re: Ending IRC Meetings

On Wed, Jul 17, 2013 at 6:04 PM, Donal Lafferty wrote: > >> -Original Message- >> From: David Nalley [mailto:da...@gnsa.us] >> Sent: 17 July 2013 6:46 PM >> To: dev@cloudstack.apache.org >> Subject: Re: Ending IRC Meetings >> >> On Wed, Jul 17, 2013 at 1:43 PM, Joe Brockmeier wrote: >> >

Re: Review Request 12702: Fix CopyCmdAnswer returned by backupSnapshotCommand for VMware

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12702/#review23407 --- Ship it! Ship It! - edison su On July 18, 2013, 4:29 a.m., Satee

RE: [DISCUSS] Upgrade path to ACS 4.2 from CCP

Citrix QA would test the upgrades on the suggested paths. > The proposed upgrade paths are CCP3.0.4, CCP3.0.5, CCP3.06, CCP3.0.7 to ACS4.2 So far it is always testing from all versions to current release. Hope with the suggestion from Hugo/Chip, this can be reduced to checkpoint releases.

RE: Why are these code in utils?

For s3/swift, both secondary storage code and storage plugin will access S3/Swift library. What you suggestion to put these library? > -Original Message- > From: Alex Huang [mailto:alex.hu...@citrix.com] > Sent: Thursday, July 18, 2013 10:02 AM > To: dev@cloudstack.apache.org > Subject: W

RE: deleteAffinityGroup API

Hi Alex, The error thrown while deleting affinitygroup by Id is: " Account and domainId are needed for resource creation " Many of our APIs call AccntManager to figure out owner of the resources the API is working on like this: Account caller = CallContext.current().getCallingAccount(

[ACS 4.1.1] Bug fixes applicable to 4.1.1

Dear ACS Dev Community, We need help with identifying which bug fixes in 4.2 or 4.0 need to be back-ported to 4.1 before ACS 4.1.1 release. If you've released a bug fix that is applicable to 4.1, please kindly back-port or let me know and I will do it on your behalf. We need a response by next

Re: Why are these code in utils?

Edison, I suggest creating a utils model in engine/storage in package org.apache.cloudstack.engine.storage.utils. When I Swift and S3 were originally implemented, we didn't have such a good place to put these types of classes. Now that we have a more robust module structure, it seems appropri

Re: code formatting for enums

All, Another thing I have noticed is that enum values are not capitalized. General coding convention is that enum values are declared in all caps using an underscore to separate words. I notice that our coding conventions are silent on enumerations. Any opposition to adding this rule to our

Re: [DISCUSS] coding convention for method - and class length

I'm not sure how I feel about an arbitrary number of lines per method (although 200 is obviously quite high and I would recommend modularizing such a method), but I'm not in favor of limiting the number of methods per class (especially not to just 10). Some types of objects simply need many discret

RE: Why are these code in utils?

+1 > -Original Message- > From: John Burwell [mailto:jburw...@basho.com] > Sent: Thursday, July 18, 2013 12:25 PM > To: dev@cloudstack.apache.org > Subject: Re: Why are these code in utils? > > Edison, > > I suggest creating a utils model in engine/storage in package > org.apache.cloudst

Re: [DISCUSS] coding convention for method - and class length

On Thu, Jul 18, 2013 at 02:34:36PM -0600, Mike Tutkowski wrote: > I'm not sure how I feel about an arbitrary number of lines per method > (although 200 is obviously quite high and I would recommend modularizing > such a method), but I'm not in favor of limiting the number of methods per > class (es

Review Request 12743: removed unused class and related test utils

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12743/ --- Review request for cloudstack. Repository: cloudstack-git Description ---

Review Request 12744: Removed unused classes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12744/ --- Review request for cloudstack. Repository: cloudstack-git Description ---

RE: [DISCUSS] coding convention for method - and class length

> -Original Message- > From: Chip Childers [mailto:chip.child...@sungard.com] > Sent: 18 July 2013 9:43 PM > To: dev@cloudstack.apache.org > Subject: Re: [DISCUSS] coding convention for method - and class length > > On Thu, Jul 18, 2013 at 02:34:36PM -0600, Mike Tutkowski wrote: > > I'm no

Re: [jira] [Commented] (CLOUDSTACK-3163) KVM Virtual Router startup time is painfully long

... and each vmdata.sh calls ssh and/or scp several times. Off the top of my head, it seems like we could serialize that cmd.getVmData() output to maybe JSON or something, get it up on the router in one call, and then process it there in a python script. On Thu, Jul 18, 2013 at 7:08 AM, Wido den H

Re: [DISCUSS] coding convention for method - and class length

Like eight or so years ago, I sent a method I had to modify to the printer (so I could study it on regular paper) and it came out on 14 pages. On Thu, Jul 18, 2013 at 3:04 PM, Donal Lafferty wrote: > > -Original Message- > > From: Chip Childers [mailto:chip.child...@sungard.com] > > Sent

Re: CallContexts?

CallContext was renamed from original UserContext. The semantic is pretty much the same as before to API calls Kelven On 7/18/13 1:25 AM, "Prasanna Santhanam" wrote: >On Thu, Jul 18, 2013 at 11:58:30AM +0530, Prasanna Santhanam wrote: >> I see the following repeated lines with API calls on mast

Re: [ACS4.1.1][BLOCKER] Unable to launch VNC Console to VSphere VMs

I'll take a look at it. It seems that my devCloud environment failed to get CPVM upgraded thus let my testing on this skipped with success Kelven On 7/17/13 8:04 PM, "Musayev, Ilya" wrote: >Kelven > >Please review the commit "73a6aa78854f379e6439bf22457094a5272cbfed", >cloudstack-3433. > >After

Re: Review Request 12716: Fix for NPE

> On July 18, 2013, 3:54 p.m., Sheng Yang wrote: > > Ship It! Pushed to 4.2 and MASTER. - Sheng --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12716/#review23385

Review Request 12747: Fix configuration of Jetty-based execution so that CloudStack can execute scripts properly

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12747/ --- Review request for cloudstack, Chip Childers, Devdeep Singh, and Hugo Trippaers.

RE: [ACS4.1.1][BLOCKER] Unable to launch VNC Console to VSphere VMs

Kelven, Perhaps I missed it, Does CPVM needs to be upgraded from 4.1 to 4.1.1? Thanks ilya > -Original Message- > From: Kelven Yang [mailto:kelven.y...@citrix.com] > Sent: Thursday, July 18, 2013 5:25 PM > To: Musayev, Ilya; dev@cloudstack.apache.org > Subject: Re: [ACS4.1.1][BLOCKER] U

RE: [ACS4.1.1][BLOCKER] Unable to launch VNC Console to VSphere VMs

When I say upgraded, I mean it needs to be trashed and redeployed. > -Original Message- > From: Musayev, Ilya [mailto:imusa...@webmd.net] > Sent: Thursday, July 18, 2013 5:46 PM > To: Kelven Yang; dev@cloudstack.apache.org > Subject: RE: [ACS4.1.1][BLOCKER] Unable to launch VNC Console to

RE: [DISCUSS] Upgrade path to ACS 4.2 from CCP

> -Original Message- > From: Chip Childers [mailto:chip.child...@sungard.com] > Sent: Thursday, July 18, 2013 6:49 AM > To: dev@cloudstack.apache.org > Subject: Re: [DISCUSS] Upgrade path to ACS 4.2 from CCP > > On Wed, Jul 17, 2013 at 11:43:49PM +, Animesh Chaturvedi wrote: > > > >

RE: [rant] stupid test cases

+1 VM can be in "Stopped" state Anthony -Original Message- From: Marcus Sorensen [mailto:shadow...@gmail.com] Sent: Wednesday, July 17, 2013 10:47 PM To: dev@cloudstack.apache.org Subject: Re: [rant] stupid test cases I can understand that we may want to test that everything related

Re: Review Request 12744: Removed unused classes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12744/#review23444 --- Ship it! Ship It! - Sheng Yang On July 18, 2013, 8:51 p.m., Lasz

Re: Review Request 12744: Removed unused classes

> On July 18, 2013, 10:42 p.m., Sheng Yang wrote: > > Ship It! Pushed to MASTER. - Sheng --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12744/#review23444 ---

Re: Review Request 12743: removed unused class and related test utils

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12743/ --- (Updated July 18, 2013, 10:53 p.m.) Review request for cloudstack and Kelven Ya

RE: code formatting for enums

Actually, that's more of a C/C++ coding convention. (Speaking of which, please don't use "I" to start interfaces.) I prefer to have enums as follows Public class Vm { enum State { IsRunning, Stopped, } } I generally like to write Vm.State.IsRunning in the code. It's readable and clear.

RE: deleteAffinityGroup API

This one is a problem. I will look into it. In the bug description, all the logs were background threads. All of CloudStack background threads act with system context. That's correct. That's why I closed it out. Here I think you're actually saying that when called through admin API, it came

Re: deleteAffinityGroup API

If the API came through port 8096, then the caller comes as a System context (System default user id=1, account id=1). It was always like this since the time the UserContext was introduced. -Alena. From: Alex Huang mailto:alex.hu...@citrix.com>> Reply-To: "dev@cloudstack.apache.org

RE: deleteAffinityGroup API

Prasanna does the regression test scripts call using 8096 port? If yes then that's the reason why the API is failing. From: Alena Prokharchyk Sent: Thursday, July 18, 2013 4:13 PM To: dev@cloudstack.apache.org; Prachi Damle; Alex Huang Subject: Re: deleteAffinityGroup API If the API came throug

Re: [ACS4.1.1][BLOCKER] Unable to launch VNC Console to VSphere VMs

Yes, CPVM has to be destroyed and be re-deployed so that updates can be pushed over to make it work Kelven On 7/18/13 2:54 PM, "Musayev, Ilya" wrote: >When I say upgraded, I mean it needs to be trashed and redeployed. > >> -Original Message- >> From: Musayev, Ilya [mailto:imusa...@webmd

  1   2   >