Re: Review Request 23314: Plugin specific code for the Brocade Network Plugin

2015-04-06 Thread Sebastien Goasguen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23314/#review79041 --- Thank you for submitting your CloudStack contribution through review

Re: Review Request 23314: Plugin specific code for the Brocade Network Plugin

2014-07-15 Thread Ritu Sabharwal
> On July 15, 2014, 11:21 a.m., Hugo Trippaers wrote: > > This is looking good, when you addresses the comment on the system.js file > > in the other review i'll apply both patches. If the patches apply clean > > i'll run findbugs and cobertura to check for any issues and unit test > > coverag

Re: Review Request 23314: Plugin specific code for the Brocade Network Plugin

2014-07-15 Thread Ritu Sabharwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23314/ --- (Updated July 15, 2014, 9:52 p.m.) Review request for cloudstack. Changes ---

Re: Review Request 23314: Plugin specific code for the Brocade Network Plugin

2014-07-15 Thread Hugo Trippaers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23314/#review47769 --- This is looking good, when you addresses the comment on the system.j

Re: Review Request 23314: Plugin specific code for the Brocade Network Plugin

2014-07-14 Thread Ritu Sabharwal
> On July 8, 2014, 9:29 a.m., Hugo Trippaers wrote: > > Thanks for make this a separate review, much easier to read. > > > > The licenses are not added to all files and in some files they appear not > > to be complete. A good trick to solve this is to include the > > license-maven-plugin in th

Re: Review Request 23314: Plugin specific code for the Brocade Network Plugin

2014-07-11 Thread Ritu Sabharwal
> On July 8, 2014, 9:29 a.m., Hugo Trippaers wrote: > > Thanks for make this a separate review, much easier to read. > > > > The licenses are not added to all files and in some files they appear not > > to be complete. A good trick to solve this is to include the > > license-maven-plugin in th

Re: Review Request 23314: Plugin specific code for the Brocade Network Plugin

2014-07-11 Thread Ritu Sabharwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23314/ --- (Updated July 11, 2014, 11:44 p.m.) Review request for cloudstack. Changes --

Re: Review Request 23314: Plugin specific code for the Brocade Network Plugin

2014-07-09 Thread Ritu Sabharwal
> On July 8, 2014, 9:29 a.m., Hugo Trippaers wrote: > > Thanks for make this a separate review, much easier to read. > > > > The licenses are not added to all files and in some files they appear not > > to be complete. A good trick to solve this is to include the > > license-maven-plugin in th

Re: Review Request 23314: Plugin specific code for the Brocade Network Plugin

2014-07-09 Thread Hugo Trippaers
> On July 8, 2014, 9:29 a.m., Hugo Trippaers wrote: > > Thanks for make this a separate review, much easier to read. > > > > The licenses are not added to all files and in some files they appear not > > to be complete. A good trick to solve this is to include the > > license-maven-plugin in th

Re: Review Request 23314: Plugin specific code for the Brocade Network Plugin

2014-07-08 Thread Ritu Sabharwal
> On July 8, 2014, 9:29 a.m., Hugo Trippaers wrote: > > Thanks for make this a separate review, much easier to read. > > > > The licenses are not added to all files and in some files they appear not > > to be complete. A good trick to solve this is to include the > > license-maven-plugin in th

Re: Review Request 23314: Plugin specific code for the Brocade Network Plugin

2014-07-08 Thread Ritu Sabharwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23314/ --- (Updated July 8, 2014, 6:49 p.m.) Review request for cloudstack. Changes

Re: Review Request 23314: Plugin specific code for the Brocade Network Plugin

2014-07-08 Thread Ritu Sabharwal
> On July 8, 2014, 9:29 a.m., Hugo Trippaers wrote: > > Thanks for make this a separate review, much easier to read. > > > > The licenses are not added to all files and in some files they appear not > > to be complete. A good trick to solve this is to include the > > license-maven-plugin in th

Re: Review Request 23314: Plugin specific code for the Brocade Network Plugin

2014-07-08 Thread Hugo Trippaers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23314/#review47435 --- Thanks for make this a separate review, much easier to read. The li

Re: Review Request 23314: Plugin specific code for the Brocade Network Plugin

2014-07-07 Thread Ritu Sabharwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23314/ --- (Updated July 7, 2014, 7:08 p.m.) Review request for cloudstack. Bugs: CLOUDS

Review Request 23314: Plugin specific code for the Brocade Network Plugin

2014-07-07 Thread Ritu Sabharwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23314/ --- Review request for cloudstack. Summary (updated) - Plugin spec