----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23314/#review47769 -----------------------------------------------------------
This is looking good, when you addresses the comment on the system.js file in the other review i'll apply both patches. If the patches apply clean i'll run findbugs and cobertura to check for any issues and unit test coverage. Hugo plugins/network-elements/brocade-vcs/resources/BrocadeInterfaceSchema.xsd <https://reviews.apache.org/r/23314/#comment83972> Did you check with the rat plugin if the license is accepted like this? I think the license is only properly detected with it is located in a comment like in the spring xml files. - Hugo Trippaers On July 11, 2014, 11:44 p.m., Ritu Sabharwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23314/ > ----------------------------------------------------------- > > (Updated July 11, 2014, 11:44 p.m.) > > > Review request for cloudstack. > > > Bugs: CLOUDSTACK-6823 > https://issues.apache.org/jira/browse/CLOUDSTACK-6823 > > > Repository: cloudstack-git > > > Description > ------- > > Plugin specific code. > > > Diffs > ----- > > plugins/network-elements/brocade-vcs/pom.xml PRE-CREATION > plugins/network-elements/brocade-vcs/resources/BrocadeInterfaceSchema.xsd > PRE-CREATION > plugins/network-elements/brocade-vcs/resources/BrocadePortProfileSchema.xsd > PRE-CREATION > plugins/network-elements/brocade-vcs/resources/BrocadeShowVcsSchema.xsd > PRE-CREATION > > plugins/network-elements/brocade-vcs/resources/META-INF/cloudstack/vcs/module.properties > PRE-CREATION > > plugins/network-elements/brocade-vcs/resources/META-INF/cloudstack/vcs/spring-vcs-context.xml > PRE-CREATION > > plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/AssociateMacToNetworkAnswer.java > PRE-CREATION > > plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/AssociateMacToNetworkCommand.java > PRE-CREATION > > plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/CreateNetworkAnswer.java > PRE-CREATION > > plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/CreateNetworkCommand.java > PRE-CREATION > > plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DeleteNetworkAnswer.java > PRE-CREATION > > plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DeleteNetworkCommand.java > PRE-CREATION > > plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DisassociateMacFromNetworkAnswer.java > PRE-CREATION > > plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DisassociateMacFromNetworkCommand.java > PRE-CREATION > > plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/StartupBrocadeVcsCommand.java > PRE-CREATION > > plugins/network-elements/brocade-vcs/src/com/cloud/network/BrocadeVcsNetworkHostMappingVO.java > PRE-CREATION > > plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/BrocadeVcsApi.java > PRE-CREATION > > plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/BrocadeVcsApiException.java > PRE-CREATION > > plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/Cache.java > PRE-CREATION > > plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/CacheManager.java > PRE-CREATION > > plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/Constants.java > PRE-CREATION > > plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/Switch.java > PRE-CREATION > > plugins/network-elements/brocade-vcs/src/com/cloud/network/dao/BrocadeVcsNetworkHostMappingDao.java > PRE-CREATION > > plugins/network-elements/brocade-vcs/src/com/cloud/network/dao/BrocadeVcsNetworkHostMappingDaoImpl.java > PRE-CREATION > > plugins/network-elements/brocade-vcs/src/com/cloud/network/element/BrocadeVcsElement.java > PRE-CREATION > > plugins/network-elements/brocade-vcs/src/com/cloud/network/guru/BrocadeVcsGuestNetworkGuru.java > PRE-CREATION > > plugins/network-elements/brocade-vcs/src/com/cloud/network/resource/BrocadeVcsResource.java > PRE-CREATION > > plugins/network-elements/brocade-vcs/test/com/cloud/network/brocade/BrocadeVcsApiTest.java > PRE-CREATION > > plugins/network-elements/brocade-vcs/test/com/cloud/network/guru/BrocadeVcsGuestNetworkGuruTest.java > PRE-CREATION > > plugins/network-elements/brocade-vcs/test/com/cloud/network/resource/BrocadeVcsResourceTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/23314/diff/ > > > Testing > ------- > > > Thanks, > > Ritu Sabharwal > >
