Re: Review Request 21908: Fix for CLOUDSTACK-6464

2014-06-04 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21908/#review44778 --- Commit 15385948dcdf4c69136e99bf3c602f95fd018f39 in cloudstack's bran

Re: Review Request 21908: Fix for CLOUDSTACK-6464

2014-06-04 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21908/#review44713 --- Commit 91391e6779bd25b91a3ca4d014656e24592187eb in cloudstack's bran

Re: Review Request 21908: Fix for CLOUDSTACK-6464

2014-06-04 Thread Anders Lannerbäck
> On June 4, 2014, 2:29 p.m., Marcus Sorensen wrote: > > let's be extra careful not to apply this patch now that the other fixes are > > in. This patch will break fresh 4.3 installs and is incompatible with the > > fixes for the upgrades. Yes, this patch should be rejected now that a better fi

Re: Review Request 21908: Fix for CLOUDSTACK-6464

2014-06-04 Thread Marcus Sorensen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21908/#review44711 --- let's be extra careful not to apply this patch now that the other fi

Re: Review Request 21908: Fix for CLOUDSTACK-6464

2014-06-03 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21908/#review44665 --- Commit dfb59cd6cc0292a88cb619e53f34cdb713879ffd in cloudstack's bran

Re: Review Request 21908: Fix for CLOUDSTACK-6464

2014-06-03 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21908/#review44664 --- Commit 15385948dcdf4c69136e99bf3c602f95fd018f39 in cloudstack's bran

Re: Review Request 21908: Fix for CLOUDSTACK-6464

2014-06-03 Thread Marcus Sorensen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21908/#review44635 --- I would vote to reject this patch, by the way, on the terms that it

Re: Review Request 21908: Fix for CLOUDSTACK-6464

2014-06-03 Thread Marcus Sorensen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21908/#review44634 --- Actually, this would be fixed by changing the upgraded db to have vl

Re: Review Request 21908: Fix for CLOUDSTACK-6464

2014-05-26 Thread daan Hoogland
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21908/#review43928 --- Anders, use the BroadcastDomainType from Networks.java for this. -

Review Request 21908: Fix for CLOUDSTACK-6464

2014-05-26 Thread Anders Lannerbäck
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21908/ --- Review request for cloudstack. Repository: cloudstack-git Description ---