----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21908/#review44635 -----------------------------------------------------------
I would vote to reject this patch, by the way, on the terms that it just works around the inconsistency in the data being passed. I'm glad that you were able to find and use it as an interim solution, though. - Marcus Sorensen On May 26, 2014, 12:25 p.m., Anders Lannerbäck wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21908/ > ----------------------------------------------------------- > > (Updated May 26, 2014, 12:25 p.m.) > > > Review request for cloudstack. > > > Repository: cloudstack-git > > > Description > ------- > > Fix for CLOUDSTACK-6464. This patch is against 4.3-branch. > > The original code adds broadcastUri on the format "vlan://100", but later > looks for HashMap keys without the "vlan://" bit. This causes new interfaces > be created with duplicate MACs and the routers become unusable. > > > Diffs > ----- > > > plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java > 36382e3 > > Diff: https://reviews.apache.org/r/21908/diff/ > > > Testing > ------- > > Used to repair our production Cloudstack instance. > > > Thanks, > > Anders Lannerbäck > >
