> On June 4, 2014, 2:29 p.m., Marcus Sorensen wrote: > > let's be extra careful not to apply this patch now that the other fixes are > > in. This patch will break fresh 4.3 installs and is incompatible with the > > fixes for the upgrades.
Yes, this patch should be rejected now that a better fix is in. - Anders ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21908/#review44711 ----------------------------------------------------------- On May 26, 2014, 12:25 p.m., Anders Lannerbäck wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21908/ > ----------------------------------------------------------- > > (Updated May 26, 2014, 12:25 p.m.) > > > Review request for cloudstack. > > > Repository: cloudstack-git > > > Description > ------- > > Fix for CLOUDSTACK-6464. This patch is against 4.3-branch. > > The original code adds broadcastUri on the format "vlan://100", but later > looks for HashMap keys without the "vlan://" bit. This causes new interfaces > be created with duplicate MACs and the routers become unusable. > > > Diffs > ----- > > > plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java > 36382e3 > > Diff: https://reviews.apache.org/r/21908/diff/ > > > Testing > ------- > > Used to repair our production Cloudstack instance. > > > Thanks, > > Anders Lannerbäck > >
