Re: Review Request 12251: Incorporating the review comments given by Alena and Sheng

> On July 17, 2013, 7:01 a.m., Abhinandan Prateek wrote: > > Ship It! This patch does not contain the dnsmasq changes. Bharat is going to create another review request for the dnsmasq changes so that it does not overwrite the cloud-early-config dns conf. - Abhinandan --

Re: Review Request 12251: Incorporating the review comments given by Alena and Sheng

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12251/#review23246 --- Ship it! Ship It! - Abhinandan Prateek On July 17, 2013, 5:52 a.

Re: Review Request 12251: Incorporating the review comments given by Alena and Sheng

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12251/ --- (Updated July 17, 2013, 5:52 a.m.) Review request for cloudstack, Alena Prokhar

Re: Review Request 12251: Incorporating the review comments given by Alena and Sheng

> On July 15, 2013, 6:33 p.m., Sheng Yang wrote: > > I think we can split the patch by different fixes(ensure each one of them > > won't break compile or any functionality), then we can commit it gradually. > > Do all of them in one batch is too big and hard to review. > > > > Besides, I didn'

Re: Review Request 12251: Incorporating the review comments given by Alena and Sheng

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12251/#review23165 --- I think we can split the patch by different fixes(ensure each one of

Re: Review Request 12251: Incorporating the review comments given by Alena and Sheng

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12251/ --- (Updated July 13, 2013, 2:33 p.m.) Review request for cloudstack, Alena Prokhar

Re: Review Request 12251: Incorporating the review comments given by Alena and Sheng

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12251/#review22901 --- Can you create a new patch that consolidates all these changes and r

Re: Review Request 12251: Incorporating the review comments given by Alena and Sheng

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12251/#review22900 --- server/src/com/cloud/configuration/ConfigurationManagerImpl.java

Re: Review Request 12251: Incorporating the review comments given by Alena and Sheng

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12251/#review22839 --- engine/schema/src/com/cloud/network/dao/IPAddressDaoImpl.java

Re: Review Request 12251: Incorporating the review comments given by Alena and Sheng

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12251/ --- (Updated July 8, 2013, 5:47 p.m.) Review request for cloudstack, Alena Prokharc

Re: Review Request 12251: Incorporating the review comments given by Alena and Sheng

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12251/#review22836 --- server/src/com/cloud/configuration/ConfigurationManagerImpl.java

Re: Review Request 12251: Incorporating the review comments given by Alena and Sheng

> On July 3, 2013, 3:58 p.m., bharat kumar wrote: > > server/src/com/cloud/configuration/ConfigurationManagerImpl.java, line 3054 > > > > > > removed the sql exception > > Alena Prokharchyk wrote: > Bharat, I sti

Re: Review Request 12251: Incorporating the review comments given by Alena and Sheng

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12251/ --- (Updated July 4, 2013, 2:09 a.m.) Review request for cloudstack, Alena Prokharc

Re: Review Request 12251: Incorporating the review comments given by Alena and Sheng

> On July 3, 2013, 3:58 p.m., bharat kumar wrote: > > server/src/com/cloud/configuration/ConfigurationManagerImpl.java, line 3054 > > > > > > removed the sql exception > > Alena Prokharchyk wrote: > Bharat, I sti

Re: Review Request 12251: Incorporating the review comments given by Alena and Sheng

> On July 3, 2013, 3:58 p.m., bharat kumar wrote: > > server/src/com/cloud/configuration/ConfigurationManagerImpl.java, line 3054 > > > > > > removed the sql exception Bharat, I still see SQLException being caught:

Re: Review Request 12251: Incorporating the review comments given by Alena and Sheng

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12251/#review22722 --- core/src/com/cloud/agent/api/routing/DnsMasqConfigCommand.java

Review Request 12251: Incorporating the review comments given by Alena and Sheng

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12251/ --- Review request for cloudstack, Alena Prokharchyk, Abhinandan Prateek, and Sheng