> On July 15, 2013, 6:33 p.m., Sheng Yang wrote: > > I think we can split the patch by different fixes(ensure each one of them > > won't break compile or any functionality), then we can commit it gradually. > > Do all of them in one batch is too big and hard to review. > > > > Besides, I didn't see any change to dnsmasq config file update mechanism. > > Regenerated one file is unacceptable for now since cloud-early-config would > > modify the file as well.
Yes I agree, in that we break this into a set of manageable pieces that can be reviewed and independently committed. - Abhinandan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12251/#review23165 ----------------------------------------------------------- On July 13, 2013, 2:33 p.m., bharat kumar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12251/ > ----------------------------------------------------------- > > (Updated July 13, 2013, 2:33 p.m.) > > > Review request for cloudstack, Alena Prokharchyk, Abhinandan Prateek, and > Sheng Yang. > > > Repository: cloudstack-git > > > Description > ------- > > Incorporating the review comments given by Alena and Sheng. > > > Diffs > ----- > > api/src/com/cloud/agent/api/to/DhcpTO.java PRE-CREATION > api/src/com/cloud/agent/api/to/DnsmasqTO.java c7be04d > api/src/com/cloud/network/Network.java a06208b > api/src/com/cloud/network/NetworkService.java 405cecd > api/src/com/cloud/network/element/DhcpServiceProvider.java 83008ca > core/src/com/cloud/agent/api/routing/DnsMasqConfigCommand.java a52af90 > core/src/com/cloud/network/DnsMasqConfigurator.java dd34926 > engine/schema/src/com/cloud/network/dao/IPAddressDao.java 3eba6d8 > engine/schema/src/com/cloud/network/dao/IPAddressDaoImpl.java 1051b69 > patches/systemvm/debian/config/root/createIpAlias.sh 1db210b > patches/systemvm/debian/config/root/deleteIpAlias.sh cf6d4de > scripts/network/domr/call_dnsmasq.sh 097e185 > scripts/vm/hypervisor/xenserver/createipAlias.sh c35658e > scripts/vm/hypervisor/xenserver/deleteipAlias.sh 6816edd > server/src/com/cloud/configuration/ConfigurationManagerImpl.java 27c1a51 > server/src/com/cloud/network/NetworkManagerImpl.java 708c03d > server/src/com/cloud/network/NetworkServiceImpl.java 8cdcfde > server/src/com/cloud/network/element/VirtualRouterElement.java 1916678 > server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java > e863af4 > server/src/com/cloud/vm/VirtualMachineManagerImpl.java de0368a > server/test/com/cloud/network/MockNetworkManagerImpl.java 077395f > server/test/com/cloud/vpc/MockNetworkManagerImpl.java b609022 > utils/src/com/cloud/utils/net/NetUtils.java 5c13454 > > Diff: https://reviews.apache.org/r/12251/diff/ > > > Testing > ------- > > > Thanks, > > bharat kumar > >
