----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12251/#review23246 -----------------------------------------------------------
Ship it! Ship It! - Abhinandan Prateek On July 17, 2013, 5:52 a.m., bharat kumar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12251/ > ----------------------------------------------------------- > > (Updated July 17, 2013, 5:52 a.m.) > > > Review request for cloudstack, Alena Prokharchyk, Abhinandan Prateek, and > Sheng Yang. > > > Repository: cloudstack-git > > > Description > ------- > > Incorporating the review comments given by Alena and Sheng. > > > Diffs > ----- > > api/src/com/cloud/agent/api/to/DhcpTO.java PRE-CREATION > api/src/com/cloud/agent/api/to/DnsmasqTO.java c7be04d > api/src/com/cloud/network/Network.java a06208b > api/src/com/cloud/network/NetworkService.java 405cecd > api/src/com/cloud/network/element/DhcpServiceProvider.java 83008ca > core/src/com/cloud/agent/api/routing/DnsMasqConfigCommand.java a52af90 > core/src/com/cloud/network/DnsMasqConfigurator.java dd34926 > engine/schema/src/com/cloud/capacity/dao/CapacityDaoImpl.java cecc145 > engine/schema/src/com/cloud/network/dao/IPAddressDao.java 3eba6d8 > engine/schema/src/com/cloud/network/dao/IPAddressDaoImpl.java 1051b69 > engine/schema/src/com/cloud/vm/dao/NicDao.java 83f280e > engine/schema/src/com/cloud/vm/dao/NicDaoImpl.java 420643f > patches/systemvm/debian/config/root/createIpAlias.sh 1db210b > patches/systemvm/debian/config/root/deleteIpAlias.sh cf6d4de > patches/systemvm/debian/config/root/dnsmasq.sh 656fd3c > scripts/network/domr/call_dnsmasq.sh 097e185 > scripts/vm/hypervisor/xenserver/createipAlias.sh c35658e > scripts/vm/hypervisor/xenserver/deleteipAlias.sh 6816edd > server/src/com/cloud/configuration/ConfigurationManagerImpl.java 801028d > server/src/com/cloud/network/NetworkManagerImpl.java db375c3 > server/src/com/cloud/network/NetworkServiceImpl.java ccd23bf > server/src/com/cloud/network/element/VirtualRouterElement.java 1916678 > server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java > e437af6 > > server/src/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImpl.java > 39d0895 > server/src/com/cloud/vm/VirtualMachineManagerImpl.java afdc85d > server/test/com/cloud/network/MockNetworkManagerImpl.java 9c7d092 > > server/test/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImplTest.java > 04a3601 > server/test/com/cloud/vpc/MockNetworkManagerImpl.java 523dfb8 > utils/conf/db.properties e1b5fe9 > utils/src/com/cloud/utils/net/NetUtils.java 68f4965 > > Diff: https://reviews.apache.org/r/12251/diff/ > > > Testing > ------- > > > Thanks, > > bharat kumar > >
