Re: Review Request 24111: Coverity findings for brocade-plugin

2014-08-05 Thread Santhosh Edukulla
> On Aug. 5, 2014, 9:31 a.m., Santhosh Edukulla wrote: > > Ship It! Pushed to master Updated Branches: refs/heads/master 1bfb1f650 -> cc725e53e - Santhosh --- This is an automatically generated e-mail. To reply, visit: https://reviews

Re: Review Request 24111: Coverity findings for brocade-plugin

2014-08-05 Thread Santhosh Edukulla
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24111/#review49578 --- Ship it! Ship It! - Santhosh Edukulla On July 31, 2014, 5:57 p.m

Re: Review Request 24111: Coverity findings for brocade-plugin

2014-08-03 Thread Santhosh Edukulla
> On Aug. 1, 2014, 5:57 a.m., Santhosh Edukulla wrote: > > plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/BrocadeVcsApi.java, > > line 547 > > > > > > It seems there is no corresponding catch here,

Re: Review Request 24111: Coverity findings for brocade-plugin

2014-08-01 Thread Ritu Sabharwal
> On Aug. 1, 2014, 5:57 a.m., Santhosh Edukulla wrote: > > plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/BrocadeVcsApi.java, > > line 547 > > > > > > It seems there is no corresponding catch here,

Re: Review Request 24111: Coverity findings for brocade-plugin

2014-07-31 Thread Santhosh Edukulla
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24111/#review49323 --- plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/

Re: Review Request 24111: Coverity findings for brocade-plugin

2014-07-31 Thread Ritu Sabharwal
> On July 31, 2014, 7:01 a.m., Santhosh Edukulla wrote: > > plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/BrocadeVcsApi.java, > > line 482 > > > > > > This particular try\except is for an IO exc

Re: Review Request 24111: Coverity findings for brocade-plugin

2014-07-31 Thread Ritu Sabharwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24111/ --- (Updated July 31, 2014, 5:57 p.m.) Review request for cloudstack and Hugo Tripp

Re: Review Request 24111: Coverity findings for brocade-plugin

2014-07-31 Thread Santhosh Edukulla
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24111/#review49213 --- plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/

Re: Review Request 24111: Coverity findings for brocade-plugin

2014-07-30 Thread Ritu Sabharwal
> On July 31, 2014, 4:19 a.m., Santhosh Edukulla wrote: > > plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/BrocadeVcsApi.java, > > line 482 > > > > > > Message info seems to be corrected. Hi Santh

Re: Review Request 24111: Coverity findings for brocade-plugin

2014-07-30 Thread Santhosh Edukulla
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24111/#review49200 --- plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/