> On Aug. 1, 2014, 5:57 a.m., Santhosh Edukulla wrote: > > plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/BrocadeVcsApi.java, > > line 547 > > <https://reviews.apache.org/r/24111/diff/2/?file=646948#file646948line547> > > > > It seems there is no corresponding catch here, did compilation worked? > > Ritu Sabharwal wrote: > Hi Santhosh, > > This log statement is not there in the latest patch that I submitted. > > There is a throws clause in the method signature private String > responseToErrorMessage(HttpResponse response) throws IOException and the > IOException is handled in the caller methods. > > The compilation works fine. > > Thanks, > Ritu S.
It seems that patch was not in correct git format, we can do "git apply" and "git commit -m --author=...", if its ok. Hugo, if we don't have any other concerns, we can push i believe. Santhosh - Santhosh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24111/#review49323 ----------------------------------------------------------- On July 31, 2014, 5:57 p.m., Ritu Sabharwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24111/ > ----------------------------------------------------------- > > (Updated July 31, 2014, 5:57 p.m.) > > > Review request for cloudstack and Hugo Trippaers. > > > Bugs: CLOUDSTACK-6823 > https://issues.apache.org/jira/browse/CLOUDSTACK-6823 > > > Repository: cloudstack-git > > > Description > ------- > > Fixed Coverity findings for brocade-plugin > > > Diffs > ----- > > > plugins/network-elements/brocade-vcs/src/com/cloud/api/response/BrocadeVcsDeviceResponse.java > 60edbcf > > plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/BrocadeVcsApi.java > d5f06f8 > > Diff: https://reviews.apache.org/r/24111/diff/ > > > Testing > ------- > > > Thanks, > > Ritu Sabharwal > >
