Re: Review Request: Release old DHCP entries

2013-05-02 Thread Chiradeep Vittal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10884/#review20088 --- Ship it! Ship It! - Chiradeep Vittal On May 2, 2013, 5:38 a.m.,

Re: Review Request: Release old DHCP entries

2013-05-02 Thread Marcus Sorensen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10884/#review20076 --- Ship it! Ship It! - Marcus Sorensen On May 2, 2013, 5:38 a.m., D

Re: Review Request: Release old DHCP entries

2013-05-01 Thread Dennis Lawler
> On May 1, 2013, 10:05 p.m., Chiradeep Vittal wrote: > > patches/systemvm/debian/config/root/edithosts.sh, line 104 > > > > > > Please check for the existence of 'dhcp_release' binary. You will have > > folks upgradi

Re: Review Request: Release old DHCP entries

2013-05-01 Thread Dennis Lawler
> On May 1, 2013, 8:36 p.m., Marcus Sorensen wrote: > > patches/systemvm/debian/config/root/edithosts.sh, line 103 > > > > > > shouldn't this be $ipv4?, and if it fails to find the mac in the leases > > file, will it

Re: Review Request: Release old DHCP entries

2013-05-01 Thread Dennis Lawler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10884/ --- (Updated May 2, 2013, 5:38 a.m.) Review request for cloudstack. Changes -

Re: Review Request: Release old DHCP entries

2013-05-01 Thread Chiradeep Vittal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10884/#review20031 --- patches/systemvm/debian/config/root/edithosts.sh

Re: Review Request: Release old DHCP entries

2013-05-01 Thread Marcus Sorensen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10884/#review20025 --- patches/systemvm/debian/config/root/edithosts.sh