> On May 1, 2013, 8:36 p.m., Marcus Sorensen wrote: > > patches/systemvm/debian/config/root/edithosts.sh, line 103 > > <https://reviews.apache.org/r/10884/diff/2/?file=286739#file286739line103> > > > > shouldn't this be $ipv4?, and if it fails to find the mac in the leases > > file, will it kill the whole script?
That's right - bad typo. If it fails to find the MAC in the leases file (the usual case), dhcp_release does not get enough args and fails. It shouldn't kill the whole script, or at least it hasn't in testing. - Dennis ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10884/#review20025 ----------------------------------------------------------- On May 2, 2013, 5:38 a.m., Dennis Lawler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10884/ > ----------------------------------------------------------- > > (Updated May 2, 2013, 5:38 a.m.) > > > Review request for cloudstack. > > > Description > ------- > > Release old DHCP entries when adding new entries. > > Add dnsmasq-utils to System VM template. > > > This addresses bug CLOUDSTACK-2299. > > > Diffs > ----- > > patches/systemvm/debian/config/root/edithosts.sh 1f98fbf > scripts/network/exdhcp/dnsmasq_edithosts.sh 05285d9 > tools/appliance/definitions/systemvmtemplate/postinstall.sh ae8f1ad > tools/appliance/definitions/systemvmtemplate64/postinstall.sh ae8f1ad > > Diff: https://reviews.apache.org/r/10884/diff/ > > > Testing > ------- > > Tested in staging VM destroyed and re-instantiated with same IP. > Did not test adding dnsmasq-utils to system VM build (yet). > > > Thanks, > > Dennis Lawler > >
