-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10884/#review20025
-----------------------------------------------------------



patches/systemvm/debian/config/root/edithosts.sh
<https://reviews.apache.org/r/10884/#comment41259>

    shouldn't this be $ipv4?, and if it fails to find the mac in the leases 
file, will it kill the whole script?


- Marcus Sorensen


On May 1, 2013, 6:41 p.m., Dennis Lawler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10884/
> -----------------------------------------------------------
> 
> (Updated May 1, 2013, 6:41 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Description
> -------
> 
> Release old DHCP entries when adding new entries. 
> 
> Add dnsmasq-utils to System VM template.
> 
> 
> This addresses bug CLOUDSTACK-2299.
> 
> 
> Diffs
> -----
> 
>   patches/systemvm/debian/config/root/edithosts.sh 1f98fbf 
>   scripts/network/exdhcp/dnsmasq_edithosts.sh 05285d9 
>   tools/appliance/definitions/systemvmtemplate/postinstall.sh ae8f1ad 
>   tools/appliance/definitions/systemvmtemplate64/postinstall.sh ae8f1ad 
> 
> Diff: https://reviews.apache.org/r/10884/diff/
> 
> 
> Testing
> -------
> 
> Tested in staging VM destroyed and re-instantiated with same IP.
> Did not test adding dnsmasq-utils to system VM build (yet).
> 
> 
> Thanks,
> 
> Dennis Lawler
> 
>

Reply via email to