Re: Review Request 19902: CLOUDSTACK-6223. removeNicFromVirtualMachine fails if another instance in another domain has a nic with the same ip and a forwarding rule configured on it

2014-05-29 Thread daan Hoogland
.org/r/19902/ > --- > > (Updated April 2, 2014, 5:09 a.m.) > > > Review request for cloudstack and Alena Prokharchyk. > > > Repository: cloudstack-git > > > Description > --- > > CLOUDSTACK-6223. removeNicFromVirtualMachine fails if anot

Re: Review Request 19902: CLOUDSTACK-6223. removeNicFromVirtualMachine fails if another instance in another domain has a nic with the same ip and a forwarding rule configured on it

2014-05-29 Thread ASF Subversion and Git Services
x27;s branch refs/heads/master from Upendra Moturi [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=e9af5f4 ] CLOUDSTACK-6223. removeNicFromVirtualMachine fails if another instance in another domain has a nic with the same ip and a forwarding rule configured on it Signed-off-by: Daan Hoo

Re: Review Request 19902: CLOUDSTACK-6223. removeNicFromVirtualMachine fails if another instance in another domain has a nic with the same ip and a forwarding rule configured on it

2014-05-05 Thread Daan Hoogland
ere is portforward rule assigned. > > > > > > - upendra > > On April 2nd, 2014, 5:09 a.m. UTC, upendra moturi wrote: > Review request for cloudstack and Alena Prokharchyk. > By upendra moturi. > > *Updated April 2, 2014, 5:09 a.m.* > *Repository: * cloudstack-git &

Re: Review Request 19902: CLOUDSTACK-6223. removeNicFromVirtualMachine fails if another instance in another domain has a nic with the same ip and a forwarding rule configured on it

2014-04-23 Thread upendra moturi
; > > Repository: cloudstack-git > > > Description > --- > > CLOUDSTACK-6223. removeNicFromVirtualMachine fails if another instance in > another domain has a nic with the same ip and a forwarding rule configured on > it > > > Diffs > -

Re: Review Request 19902: CLOUDSTACK-6223. removeNicFromVirtualMachine fails if another instance in another domain has a nic with the same ip and a forwarding rule configured on it

2014-04-21 Thread daan Hoogland
.org/r/19902/ > --- > > (Updated April 2, 2014, 5:09 a.m.) > > > Review request for cloudstack and Alena Prokharchyk. > > > Repository: cloudstack-git > > > Description > --- > > CLOUDSTACK-6223. removeNicFromVirtualMachine fail

Re: Review Request 19902: CLOUDSTACK-6223. removeNicFromVirtualMachine fails if another instance in another domain has a nic with the same ip and a forwarding rule configured on it

2014-04-21 Thread Upendra Moturi
t; *Repository: * cloudstack-git > Description > > CLOUDSTACK-6223. removeNicFromVirtualMachine fails if another instance in > another domain has a nic with the same ip and a forwarding rule configured on > it > > Diffs > >- engine/schema/src/com/cloud/network/rules/dao

Review Request 19902: CLOUDSTACK-6223. removeNicFromVirtualMachine fails if another instance in another domain has a nic with the same ip and a forwarding rule configured on it

2014-04-01 Thread upendra moturi
-git Description --- CLOUDSTACK-6223. removeNicFromVirtualMachine fails if another instance in another domain has a nic with the same ip and a forwarding rule configured on it Diffs - engine/schema/src/com/cloud/network/rules/dao/PortForwardingRulesDao.java 4694cb9 engine/schema

Re: CLOUDSTACK-6223.

2014-04-01 Thread Alena Prokharchyk
Upendra, please go ahead and create a review board ticket with the suggested fix. https://reviews.apache.org/ -Alena. On 4/1/14, 6:21 AM, "Upendra Moturi" wrote: >Hi, > >Bug ID : CLOUDSTACK-6223.(removeNicFromVirtualMachine fails if another >instance in another domain h

CLOUDSTACK-6223.

2014-04-01 Thread Upendra Moturi
Hi, Bug ID : CLOUDSTACK-6223.(removeNicFromVirtualMachine fails if another instance in another domain has a nic with the same ip and a forwarding rule configured on it) Here is my proposed fix . Add new method to get rules by destip and instanceid so that we get rules only for that vm instead