----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19902/#review40905 -----------------------------------------------------------
did you verify that this works for your use case? Can you add unit tests and test scenario? - daan Hoogland On April 2, 2014, 5:09 a.m., upendra moturi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19902/ > ----------------------------------------------------------- > > (Updated April 2, 2014, 5:09 a.m.) > > > Review request for cloudstack and Alena Prokharchyk. > > > Repository: cloudstack-git > > > Description > ------- > > CLOUDSTACK-6223. removeNicFromVirtualMachine fails if another instance in > another domain has a nic with the same ip and a forwarding rule configured on > it > > > Diffs > ----- > > engine/schema/src/com/cloud/network/rules/dao/PortForwardingRulesDao.java > 4694cb9 > > engine/schema/src/com/cloud/network/rules/dao/PortForwardingRulesDaoImpl.java > 45c0aeb > server/src/com/cloud/network/rules/RulesManagerImpl.java 13f6306 > > Diff: https://reviews.apache.org/r/19902/diff/ > > > Testing > ------- > > > Thanks, > > upendra moturi > >
