Alena, I see nothing that keeps us from aplying this patch, do you?
regards, On Wed, Apr 23, 2014 at 4:41 PM, upendra moturi <upendra.mot...@sungard.com>wrote: > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19902/ > > On April 21st, 2014, 6:17 p.m. UTC, *daan Hoogland* wrote: > > did you verify that this works for your use case? Can you add unit tests and > test scenario? > > Test Scenario : > Add two vms with two nics each having different networks .Two networks to > each vm. > One network of each vm have same network configurations (i.e 10.20.30.0/24). > One nic of each vm have same ipaddress and one of the nic has portforward > rule and try deleting other vm nic throws error saying there is portforward > rule assigned. > > VM1 (nic1,nic2) -> network1,network2. > VM2 (nic3,nic4) -> network3,network4. > > network2 - 10.20.30.0/24 > network4 <http://10.20.30.0/24network4> - 10.20.30.0/24 > > nic2(VM1) ipaddress - 10.20.30.5 > nic4(VM2) ipaddress - 10.20.30.5 > > nic2 has portforward rule defined and trying to to delete nic4 throws message > saying there is portforward rule assigned. > > > > > > - upendra > > On April 2nd, 2014, 5:09 a.m. UTC, upendra moturi wrote: > Review request for cloudstack and Alena Prokharchyk. > By upendra moturi. > > *Updated April 2, 2014, 5:09 a.m.* > *Repository: * cloudstack-git > Description > > CLOUDSTACK-6223. removeNicFromVirtualMachine fails if another instance in > another domain has a nic with the same ip and a forwarding rule configured on > it > > Diffs > > - engine/schema/src/com/cloud/network/rules/dao/PortForwardingRulesDao.java > (4694cb9) > - > engine/schema/src/com/cloud/network/rules/dao/PortForwardingRulesDaoImpl.java > (45c0aeb) > - server/src/com/cloud/network/rules/RulesManagerImpl.java (13f6306) > > View Diff <https://reviews.apache.org/r/19902/diff/> > -- Daan
