Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1371#issuecomment-219168493
Please verify why the jobs are failing and re-push this PR to try to get it
green. I need to verify the process to test new system templates and how to
build and dis
Github user abhinandanprateek commented on the pull request:
https://github.com/apache/cloudstack/pull/1371#issuecomment-218997501
@jburwell briefly moving to java 8 made me realise that it has lot more
ipv6 primitives then there are in 7.
---
If your project is set up for it, you ca
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r63139322
--- Diff: api/src/com/cloud/network/vpc/OSPFZoneConfig.java ---
@@ -0,0 +1,329 @@
+// Licensed to the Apache Software Foundation (ASF) under
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r63130081
--- Diff: api/src/com/cloud/network/vpc/OSPFZoneConfig.java ---
@@ -0,0 +1,332 @@
+// Licensed to the Apache Software Foundation (ASF) under
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r63127043
--- Diff: api/src/com/cloud/network/vpc/OSPFZoneConfig.java ---
@@ -0,0 +1,332 @@
+// Licensed to the Apache Software Foundation (ASF) under one
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62989315
--- Diff: utils/src/main/java/com/cloud/utils/net/cidr/CIDR6.java ---
@@ -0,0 +1,95 @@
+//
+// Licensed to the Apache Software Foundatio
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62967326
--- Diff: utils/src/main/java/com/cloud/utils/net/cidr/CIDR4.java ---
@@ -0,0 +1,172 @@
+//
+// Licensed to the Apache Software Foundati
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62965518
--- Diff: utils/src/main/java/com/cloud/utils/net/NetUtils.java ---
@@ -1159,6 +1181,25 @@ public static boolean validateGuestCidr(final String
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62963739
--- Diff: test/integration/component/test_ospf.py ---
@@ -0,0 +1,477 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+#
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62963628
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsQuagga.py ---
@@ -0,0 +1,85 @@
+# Licensed to the Apache Software Foundation (AS
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62962859
--- Diff:
server/src/org/apache/cloudstack/network/topology/BasicNetworkVisitor.java ---
@@ -316,4 +317,9 @@ public boolean visit(final StaticR
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62837384
--- Diff: server/src/com/cloud/network/router/CommandSetupHelper.java ---
@@ -1048,4 +1052,33 @@ protected String getGuestDhcpRange(final NicPro
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62835972
--- Diff:
engine/schema/src/com/cloud/network/vpc/dao/VpcServiceMapDaoImpl.java ---
@@ -62,7 +62,31 @@ protected VpcServiceMapDaoImpl() {
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62831265
--- Diff:
engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
---
@@ -1445,28 +1466,31 @@ public void
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62827236
--- Diff:
core/src/com/cloud/agent/resource/virtualnetwork/facade/QuaggaConfigItem.java
---
@@ -0,0 +1,93 @@
+//
+// Licensed to the A
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62827143
--- Diff:
core/src/com/cloud/agent/resource/virtualnetwork/facade/QuaggaConfigItem.java
---
@@ -0,0 +1,93 @@
+//
+// Licensed to the A
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62826751
--- Diff:
core/src/com/cloud/agent/resource/virtualnetwork/facade/QuaggaConfigItem.java
---
@@ -0,0 +1,93 @@
+//
+// Licensed to the A
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62826214
--- Diff:
core/src/com/cloud/agent/resource/virtualnetwork/facade/QuaggaConfigItem.java
---
@@ -0,0 +1,93 @@
+//
+// Licensed to the A
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62824571
--- Diff: core/src/com/cloud/agent/api/routing/QuaggaConfigCommand.java ---
@@ -0,0 +1,86 @@
+//
+// Licensed to the Apache Software Fou
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62820395
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/vpc/VPCOSPFConfigUpdateCmd.java
---
@@ -0,0 +1,207 @@
+// Licensed to the Apache Software Fo
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62819915
--- Diff: api/src/com/cloud/network/vpc/OSPFZoneConfig.java ---
@@ -0,0 +1,329 @@
+// Licensed to the Apache Software Foundation (ASF) under
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62819651
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/vpc/VPCOSPFConfigUpdateCmd.java
---
@@ -0,0 +1,207 @@
+// Licensed to the Apache
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62819537
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/vpc/VPCOSPFConfigUpdateCmd.java
---
@@ -0,0 +1,207 @@
+// Licensed to the Apache
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62819412
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/vpc/VPCOSPFConfigUpdateCmd.java
---
@@ -0,0 +1,207 @@
+// Licensed to the Apache
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62819397
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/vpc/VPCOSPFConfigUpdateCmd.java
---
@@ -0,0 +1,207 @@
+// Licensed to the Apache
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62819375
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/vpc/VPCOSPFConfigUpdateCmd.java
---
@@ -0,0 +1,207 @@
+// Licensed to the Apache
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62819354
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/vpc/VPCOSPFConfigUpdateCmd.java
---
@@ -0,0 +1,207 @@
+// Licensed to the Apache
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62819265
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/vpc/VPCOSPFConfigUpdateCmd.java
---
@@ -0,0 +1,207 @@
+// Licensed to the Apache
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62819386
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/vpc/VPCOSPFConfigUpdateCmd.java
---
@@ -0,0 +1,207 @@
+// Licensed to the Apache
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62796202
--- Diff: client/tomcatconf/commands.properties.in ---
@@ -485,6 +485,10 @@ updateVPCOffering=1
deleteVPCOffering=1
listVPCOfferings=1
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62796102
--- Diff: api/src/com/cloud/network/vpc/OSPFZoneConfig.java ---
@@ -0,0 +1,332 @@
+// Licensed to the Apache Software Foundation (ASF) under
Github user jburwell commented on the pull request:
https://github.com/apache/cloudstack/pull/1371#issuecomment-218355774
@abhinandanprateek Reading through the code, it seems like there could be
benefit from the following value objects:
* IpAddress interface whose implementat
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62788791
--- Diff: utils/src/main/java/com/cloud/utils/net/cidr/CIDRFactory.java ---
@@ -0,0 +1,79 @@
+//
+// Licensed to the Apache Software Foundation (
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62788718
--- Diff: utils/src/main/java/com/cloud/utils/net/cidr/CIDRFactory.java ---
@@ -0,0 +1,79 @@
+//
+// Licensed to the Apache Software Foundation (
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62788636
--- Diff: utils/src/main/java/com/cloud/utils/net/cidr/CIDR6.java ---
@@ -0,0 +1,95 @@
+//
+// Licensed to the Apache Software Foundation (ASF) u
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62788572
--- Diff: utils/src/main/java/com/cloud/utils/net/cidr/CIDR4.java ---
@@ -0,0 +1,172 @@
+//
+// Licensed to the Apache Software Foundation (ASF)
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62788491
--- Diff: utils/src/main/java/com/cloud/utils/net/cidr/CIDR.java ---
@@ -0,0 +1,98 @@
+//
+// Licensed to the Apache Software Foundation (ASF) un
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62788397
--- Diff: utils/src/main/java/com/cloud/utils/net/cidr/CIDR4.java ---
@@ -0,0 +1,172 @@
+//
+// Licensed to the Apache Software Foundation (ASF)
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62788312
--- Diff: utils/src/main/java/com/cloud/utils/net/cidr/CIDR4.java ---
@@ -0,0 +1,172 @@
+//
+// Licensed to the Apache Software Foundation (ASF)
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62788201
--- Diff: utils/src/main/java/com/cloud/utils/net/cidr/CIDR4.java ---
@@ -0,0 +1,172 @@
+//
+// Licensed to the Apache Software Foundation (ASF)
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62788152
--- Diff: utils/src/main/java/com/cloud/utils/net/cidr/CIDR4.java ---
@@ -0,0 +1,172 @@
+//
+// Licensed to the Apache Software Foundation (ASF)
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62787923
--- Diff: utils/src/main/java/com/cloud/utils/net/cidr/CIDR4.java ---
@@ -0,0 +1,172 @@
+//
+// Licensed to the Apache Software Foundation (ASF)
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62787904
--- Diff: utils/src/main/java/com/cloud/utils/net/cidr/CIDR4.java ---
@@ -0,0 +1,172 @@
+//
+// Licensed to the Apache Software Foundation (ASF)
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62787677
--- Diff: utils/src/main/java/com/cloud/utils/net/cidr/CIDR4.java ---
@@ -0,0 +1,172 @@
+//
+// Licensed to the Apache Software Foundation (ASF)
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62787612
--- Diff: utils/src/main/java/com/cloud/utils/net/cidr/CIDR4.java ---
@@ -0,0 +1,172 @@
+//
+// Licensed to the Apache Software Foundation (ASF)
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62787530
--- Diff: utils/src/main/java/com/cloud/utils/net/cidr/CIDR4.java ---
@@ -0,0 +1,172 @@
+//
+// Licensed to the Apache Software Foundation (ASF)
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62787493
--- Diff: utils/src/main/java/com/cloud/utils/net/cidr/CIDR4.java ---
@@ -0,0 +1,172 @@
+//
+// Licensed to the Apache Software Foundation (ASF)
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62787426
--- Diff: utils/src/main/java/com/cloud/utils/net/cidr/CIDR4.java ---
@@ -0,0 +1,172 @@
+//
+// Licensed to the Apache Software Foundation (ASF)
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62787416
--- Diff: utils/src/main/java/com/cloud/utils/net/cidr/CIDR4.java ---
@@ -0,0 +1,172 @@
+//
+// Licensed to the Apache Software Foundation (ASF)
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62787378
--- Diff: utils/src/main/java/com/cloud/utils/net/cidr/CIDR.java ---
@@ -0,0 +1,98 @@
+//
+// Licensed to the Apache Software Foundation (ASF) un
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62787136
--- Diff: utils/src/main/java/com/cloud/utils/net/cidr/CIDR.java ---
@@ -0,0 +1,98 @@
+//
+// Licensed to the Apache Software Foundation (ASF) un
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62787151
--- Diff: utils/src/main/java/com/cloud/utils/net/cidr/CIDR.java ---
@@ -0,0 +1,98 @@
+//
+// Licensed to the Apache Software Foundation (ASF) un
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62787129
--- Diff: utils/src/main/java/com/cloud/utils/net/cidr/CIDR.java ---
@@ -0,0 +1,98 @@
+//
+// Licensed to the Apache Software Foundation (ASF) un
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62787143
--- Diff: utils/src/main/java/com/cloud/utils/net/cidr/CIDR.java ---
@@ -0,0 +1,98 @@
+//
+// Licensed to the Apache Software Foundation (ASF) un
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62787123
--- Diff: utils/src/main/java/com/cloud/utils/net/cidr/CIDR.java ---
@@ -0,0 +1,98 @@
+//
+// Licensed to the Apache Software Foundation (ASF) un
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62787065
--- Diff: utils/src/main/java/com/cloud/utils/net/cidr/CIDR.java ---
@@ -0,0 +1,98 @@
+//
+// Licensed to the Apache Software Foundation (ASF) un
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62787032
--- Diff: utils/src/main/java/com/cloud/utils/net/cidr/CIDR.java ---
@@ -0,0 +1,98 @@
+//
+// Licensed to the Apache Software Foundation (ASF) un
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62786873
--- Diff:
utils/src/main/java/com/cloud/utils/net/cidr/BadCIDRException.java ---
@@ -0,0 +1,33 @@
+//
+// Licensed to the Apache Software Founda
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62786802
--- Diff:
utils/src/main/java/com/cloud/utils/net/cidr/BadCIDRException.java ---
@@ -0,0 +1,33 @@
+//
+// Licensed to the Apache Software Founda
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62786731
--- Diff: utils/src/main/java/com/cloud/utils/net/NetUtils.java ---
@@ -1159,6 +1181,25 @@ public static boolean validateGuestCidr(final String
cidr) {
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62786638
--- Diff: utils/src/main/java/com/cloud/utils/net/NetUtils.java ---
@@ -1159,6 +1181,25 @@ public static boolean validateGuestCidr(final String
cidr) {
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62786538
--- Diff: utils/src/main/java/com/cloud/utils/net/NetUtils.java ---
@@ -1135,6 +1142,21 @@ public static boolean isSameIpRange(final String
cidrA, final
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62786497
--- Diff: utils/src/main/java/com/cloud/utils/net/NetUtils.java ---
@@ -903,6 +906,10 @@ static boolean areCidrsNotEmpty(String cidrA, String
cidrB) {
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62786345
--- Diff: test/integration/smoke/test_ospf_zone_config.py ---
@@ -0,0 +1,165 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+#
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62786260
--- Diff: test/integration/smoke/test_ospf_zone_config.py ---
@@ -0,0 +1,165 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+#
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62786232
--- Diff: test/integration/smoke/test_ospf_zone_config.py ---
@@ -0,0 +1,165 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+#
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62786188
--- Diff: test/integration/smoke/test_ospf_zone_config.py ---
@@ -0,0 +1,165 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+#
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62786148
--- Diff: test/integration/smoke/test_ospf_zone_config.py ---
@@ -0,0 +1,165 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+#
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62786093
--- Diff: test/integration/component/test_ospf.py ---
@@ -0,0 +1,477 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62786006
--- Diff: test/integration/component/test_ospf.py ---
@@ -0,0 +1,477 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62785940
--- Diff: test/integration/component/test_ospf.py ---
@@ -0,0 +1,477 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62785864
--- Diff: test/integration/component/test_ospf.py ---
@@ -0,0 +1,477 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62785806
--- Diff: test/integration/component/test_ospf.py ---
@@ -0,0 +1,477 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62785711
--- Diff: test/integration/component/test_ospf.py ---
@@ -0,0 +1,477 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62785662
--- Diff: test/integration/component/test_ospf.py ---
@@ -0,0 +1,477 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62785576
--- Diff: test/integration/component/test_ospf.py ---
@@ -0,0 +1,477 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62785361
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsQuagga.py ---
@@ -0,0 +1,85 @@
+# Licensed to the Apache Software Foundation (ASF) under
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62785317
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsQuagga.py ---
@@ -0,0 +1,85 @@
+# Licensed to the Apache Software Foundation (ASF) under
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62783518
--- Diff:
server/src/org/apache/cloudstack/network/topology/BasicNetworkVisitor.java ---
@@ -316,4 +317,9 @@ public boolean visit(final StaticRoutesRule
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62783468
--- Diff:
server/src/org/apache/cloudstack/network/topology/AdvancedNetworkVisitor.java
---
@@ -212,4 +214,20 @@ public boolean visit(final AdvancedVpn
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62783380
--- Diff: server/src/com/cloud/server/ConfigurationServerImpl.java ---
@@ -1236,18 +1218,34 @@ public void
doInTransactionWithoutResult(TransactionStatu
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62783052
--- Diff: server/src/com/cloud/network/vpc/VpcManagerImpl.java ---
@@ -809,15 +945,22 @@ public Vpc createVpc(final long zoneId, final long
vpcOffId, fi
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62783039
--- Diff: server/src/com/cloud/network/vpc/VpcManagerImpl.java ---
@@ -809,15 +945,22 @@ public Vpc createVpc(final long zoneId, final long
vpcOffId, fi
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62782933
--- Diff: server/src/com/cloud/network/vpc/VpcManagerImpl.java ---
@@ -747,6 +810,67 @@ public VpcOffering updateVpcOffering(final long
vpcOffId, final
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62782870
--- Diff: server/src/com/cloud/network/vpc/VpcManagerImpl.java ---
@@ -747,6 +810,67 @@ public VpcOffering updateVpcOffering(final long
vpcOffId, final
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62782819
--- Diff: server/src/com/cloud/network/vpc/VpcManagerImpl.java ---
@@ -747,6 +810,67 @@ public VpcOffering updateVpcOffering(final long
vpcOffId, final
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62782681
--- Diff: server/src/com/cloud/network/vpc/VpcManagerImpl.java ---
@@ -747,6 +810,67 @@ public VpcOffering updateVpcOffering(final long
vpcOffId, final
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62782579
--- Diff: server/src/com/cloud/network/vpc/VpcManagerImpl.java ---
@@ -747,6 +810,67 @@ public VpcOffering updateVpcOffering(final long
vpcOffId, final
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62782496
--- Diff: server/src/com/cloud/network/vpc/VpcManagerImpl.java ---
@@ -747,6 +810,67 @@ public VpcOffering updateVpcOffering(final long
vpcOffId, final
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62782438
--- Diff: server/src/com/cloud/network/vpc/VpcManagerImpl.java ---
@@ -705,6 +744,30 @@ public boolean deleteVpcOffering(final long offId) {
}
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62782392
--- Diff: server/src/com/cloud/network/vpc/VpcManagerImpl.java ---
@@ -705,6 +744,30 @@ public boolean deleteVpcOffering(final long offId) {
}
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62782162
--- Diff: server/src/com/cloud/network/vpc/VpcManagerImpl.java ---
@@ -529,14 +545,14 @@ private boolean findCapabilityForService(final Map
serviceCapab
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62782148
--- Diff: server/src/com/cloud/network/vpc/VpcManagerImpl.java ---
@@ -501,7 +517,7 @@ private void
validateConnectivtyServiceCapabilities(final Set pro
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62782035
--- Diff: server/src/com/cloud/network/vpc/VpcManagerImpl.java ---
@@ -309,6 +314,19 @@ public void doInTransactionWithoutResult(final
TransactionStatus
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62781813
--- Diff: server/src/com/cloud/network/vpc/VpcManagerImpl.java ---
@@ -309,6 +314,19 @@ public void doInTransactionWithoutResult(final
TransactionStatus
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62781709
--- Diff:
server/src/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImpl.java
---
@@ -455,16 +471,26 @@ protected void finalizeNetworkRulesF
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62781651
--- Diff:
server/src/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImpl.java
---
@@ -455,16 +471,26 @@ protected void finalizeNetworkRulesF
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62781596
--- Diff:
server/src/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImpl.java
---
@@ -455,16 +471,26 @@ protected void finalizeNetworkRulesF
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62781459
--- Diff:
server/src/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImpl.java
---
@@ -198,14 +199,26 @@ public boolean removeVpcRouterFromGu
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62781348
--- Diff: server/src/com/cloud/network/router/CommandSetupHelper.java ---
@@ -1048,4 +1052,33 @@ protected String getGuestDhcpRange(final NicProfile
gue
1 - 100 of 193 matches
Mail list logo
