Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1302#discussion_r60565861
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -2030,12 +2030,29 @@ int getReservedCpuMHZ(Vir
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1302#issuecomment-212873785
@priyankparihar we'll need a unit test that shows that this change is
backward compatible. I like that we're considering both default instance name
with host name
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1302#discussion_r60562805
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -2030,12 +2030,29 @@ int getReservedCpuMHZ(Vir
Github user sateesh-chodapuneedi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1302#discussion_r60562370
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -2030,12 +2030,29 @@ int getReserv
Github user sateesh-chodapuneedi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1302#discussion_r60562268
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -2030,12 +2030,29 @@ int getReserv
Github user sateesh-chodapuneedi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1302#discussion_r60562111
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -2030,12 +2030,29 @@ int getReserv
Github user sateesh-chodapuneedi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1302#discussion_r60561870
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -2030,12 +2030,29 @@ int getReserv
Github user sateesh-chodapuneedi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1302#discussion_r60561591
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -2030,12 +2030,29 @@ int getReserv
Github user priyankparihar commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1302#discussion_r60372700
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -2030,12 +2030,29 @@ int getReservedCpuM
Github user alexandrelimassantana commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1302#discussion_r53554647
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -2030,12 +2030,29 @@ int getReser
Github user priyankparihar commented on the pull request:
https://github.com/apache/cloudstack/pull/1302#issuecomment-179028659
Hi,
@alexandrelimassantana thanks for notifying. I have made modification,
according to your suggestion.
---
If your project is set up for it, you c
Github user alexandrelimassantana commented on the pull request:
https://github.com/apache/cloudstack/pull/1302#issuecomment-174396396
@priyankparihar, since you are modifying this method, you could also
generate it's javadoc. It would be a nice upgrade from that single line comment
p
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1302#discussion_r49183061
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -2032,11 +2032,20 @@ int getReservedC
Github user priyankparihar commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1302#discussion_r49171092
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -2032,11 +2032,20 @@ int getReservedCpuM
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1302#discussion_r49103580
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -2032,11 +2032,20 @@ int getReservedC
GitHub user priyankparihar opened a pull request:
https://github.com/apache/cloudstack/pull/1302
CLOUDSTACK-9104: VM naming convention in case vmware is used
I have reverted all the changes. Now functionality is same as it was in
earlier version.
ACS Bug Link is as follow ==>
Github user priyankparihar closed the pull request at:
https://github.com/apache/cloudstack/pull/1165
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fe
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1165#issuecomment-164401688
@priyankparihar I won't be able to give a LGTM without the null check,
split string related code and a unit test that breaks if someone tries to
change the convent
Github user priyankparihar commented on the pull request:
https://github.com/apache/cloudstack/pull/1165#issuecomment-164388358
@bhaisaab I think null check is not required. I have verified( because in
case of null if automatically picks some random value). But if you still think
it
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1165#discussion_r47469908
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -1889,11 +1889,20 @@ int getReservedCpuMHZ(Vir
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1165#issuecomment-164374286
@priyankparihar Fair enough, please see a code review comment. Once you fix
the null check, I think your PR is good to go. Also, write a unit test to
enforce the c
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1165#discussion_r47469773
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -1889,11 +1889,20 @@ int getReservedCpuMHZ(Vir
Github user priyankparihar commented on the pull request:
https://github.com/apache/cloudstack/pull/1165#issuecomment-164348885
@bhaisaab
User with different account cannot create VMs with the same name, which was
possible earlier (I am not sure in which CCP version). That time na
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1165#issuecomment-164178352
@bhaisaab @priyankparihar what is the verdict on this change?
---
If your project is set up for it, you can reply to this email and have your
reply appear on G
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1165#issuecomment-162413895
@DaanHoogland yes I can do that, I'm personally dealt with a lot of
vmware/cloudstack naming issues. The syntax/pattern has changes several times
in the past betwe
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1165#discussion_r46787171
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -1889,11 +1889,20 @@ int getReservedCpuMHZ(Vir
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1165#issuecomment-162341273
@priyankparihar I do not know any vmware users
@bhaisaab Do you have any insight on this change? or do you know any
candidate reviewer for this?
---
If yo
GitHub user priyankparihar opened a pull request:
https://github.com/apache/cloudstack/pull/1165
CLOUDSTACK-9104: VM naming convention in case vmware is used
I have reverted all the changes. Now functionality is same as it was in
earlier version.
You can merge this pull request i
28 matches
Mail list logo
