Github user bhaisaab commented on the pull request:

    https://github.com/apache/cloudstack/pull/1165#issuecomment-164374286
  
    @priyankparihar Fair enough, please see a code review comment. Once you fix 
the null check, I think your PR is good to go. Also, write a unit test to 
enforce the changes; i.e. the unit test should break in future if someone tries 
to change the VM naming convention in future.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to