Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1188
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1188#issuecomment-164125758
LGTM based on these tests:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=true \
component/test_
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1188#issuecomment-164069434
did a test build:
```
[INFO]
[INFO] BUILD SUCCESS
[INFO]
-
Github user kansal commented on the pull request:
https://github.com/apache/cloudstack/pull/1188#issuecomment-162839268
cc @bhaisaab @DaanHoogland I closed the previous PR. Created this one and
rebased with the master. Not sure why the tests were failing in the previous
one. Maybe so
GitHub user kansal opened a pull request:
https://github.com/apache/cloudstack/pull/1188
CLOUDSTACK-9086: ACS allows to create isolated networks with invalideâ¦
⦠gateway IP address - Fixed and Test cases added
Problem: There was no check for the network and broadcast IP
Github user kansal closed the pull request at:
https://github.com/apache/cloudstack/pull/1125
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1125#issuecomment-162497602
it is the NetUtilsTest.test31BitPrefix...() family of tests that are failing
---
If your project is set up for it, you can reply to this email and have your
re
Github user kansal commented on the pull request:
https://github.com/apache/cloudstack/pull/1125#issuecomment-162490625
@DaanHoogland I see a test case in the NetUtilsTest.java class'
testIsSameIpRange() function.
assertFalse(NetUtils.isSameIpRange(cidrFirst, "10.3.6.5/50"));
Github user kansal commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1125#discussion_r46809694
--- Diff: utils/src/main/java/com/cloud/utils/net/NetUtils.java ---
@@ -1523,7 +1524,15 @@ public static boolean isIpWithtInCidrRange(final
String ipAddre
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1125#issuecomment-162480371
Not sure if it is related but
```
Running com.cloud.utils.net.NetUtilsTest
2015-12-07 11:33:08,471 INFO [utils.net.NetUtils] (main:) Invalid va
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1125#discussion_r46805977
--- Diff: utils/src/main/java/com/cloud/utils/net/NetUtils.java ---
@@ -1523,7 +1524,15 @@ public static boolean isIpWithtInCidrRange(final
String i
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1125#issuecomment-162474888
LGTM
I will run a test build on this
also github reports conflicts on this branch, did you fork this of master?
and when? It may need a rebase to merge
Github user kansal commented on the pull request:
https://github.com/apache/cloudstack/pull/1125#issuecomment-162471051
cc @bhaisaab @DaanHoogland . Added test cases and made some minor changes
to the function. Please have a look.
---
If your project is set up for it, you can reply t
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1125#issuecomment-162415947
@kansal can you address some of the issues Daan has mentioned, if you can
fix them today I help can review and merge this. Thanks.
---
If your project is set up f
Github user kansal commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1125#discussion_r46673005
--- Diff: utils/src/main/java/com/cloud/utils/net/NetUtils.java ---
@@ -1526,6 +1527,14 @@ public static boolean isIpWithtInCidrRange(final
String ipAddre
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1125#discussion_r46672870
--- Diff: utils/src/main/java/com/cloud/utils/net/NetUtils.java ---
@@ -1526,6 +1527,14 @@ public static boolean isIpWithtInCidrRange(final
String i
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1125#discussion_r46672736
--- Diff: server/src/com/cloud/network/NetworkServiceImpl.java ---
@@ -1197,6 +1197,10 @@ public Network createGuestNetwork(CreateNetworkCmd
cmd) th
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1125#discussion_r46672603
--- Diff: server/src/com/cloud/network/NetworkServiceImpl.java ---
@@ -1197,6 +1197,10 @@ public Network createGuestNetwork(CreateNetworkCmd
cmd) th
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1125#issuecomment-161919700
LGTM based on these tests:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=true \
component/test_
GitHub user kansal opened a pull request:
https://github.com/apache/cloudstack/pull/1125
CLOUDSTACK-9086: ACS allows to create isolated networks with invalid â¦
â¦gateway IP address - Fixed
Problem: There was no check for the network and broadcast IP addresses in
the case
20 matches
Mail list logo
