Github user kansal commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1125#discussion_r46809694
  
    --- Diff: utils/src/main/java/com/cloud/utils/net/NetUtils.java ---
    @@ -1523,7 +1524,15 @@ public static boolean isIpWithtInCidrRange(final 
String ipAddress, final String
     
             final boolean isInRange = 
subnetUtils.getInfo().isInRange(ipAddress);
     
    -        return isInRange;
    +        return !isInRange;
    --- End diff --
    
    @DaanHoogland Nothing changes functionality wise. I reversed it so as it 
makes sense with the name of the function isNetworkorBroadCastIP() should 
return true if its a network or broadcast IP. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to