Github user mike-tutkowski commented on the pull request:
https://github.com/apache/cloudstack/pull/547#issuecomment-137821588
I found an old e-mail from me on this:
http://mail-archives.apache.org/mod_mbox/cloudstack-dev/201312.mbox/%3ccaconxch2hgtwrwkvb-__vgga9q-xjya-mouyd4i
Github user mike-tutkowski commented on the pull request:
https://github.com/apache/cloudstack/pull/547#issuecomment-137820920
I see we already do this:
dsSummary.isMultipleHostAccess() == false
But that doesn't seem to work the way we thought.
---
If your project is
Github user mike-tutkowski commented on the pull request:
https://github.com/apache/cloudstack/pull/547#issuecomment-137816807
Here is the relevant code (in HostMO.java):
public List>
getLocalDatastoreOnHost() throws Exception {
List> dsList = new
ArrayList>()
Github user mike-tutkowski commented on the pull request:
https://github.com/apache/cloudstack/pull/547#issuecomment-137816233
We need a more robust solution.
Does anyone know how to detect that a datastore does not reside on the
local storage of the host in question?
---
If
Github user mike-tutkowski commented on the pull request:
https://github.com/apache/cloudstack/pull/547#issuecomment-137815613
OK, I mainly remembered the issue correctly, but not entirely. The way we
avoid this problem (usually) is by looking to see if the datastore starts with
"-iqn
Github user mike-tutkowski commented on the pull request:
https://github.com/apache/cloudstack/pull/547#issuecomment-137813369
Hey...I just noticed something.
I have a datastore that I manually added to my ESXi hosts (shared storage)
that is based on an iSCSI target.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/547
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/547#issuecomment-129337423
@mike-tutkowski Thanks! It seems the testing / verification is still to do
and that is the work. Merging itself can be done with a one-liner. Are you able
to ver
Github user mike-tutkowski commented on the pull request:
https://github.com/apache/cloudstack/pull/547#issuecomment-129276125
The code LGTM. Are we under the assumption that it was properly tested? If
so, I can just merge it at this point.
---
If your project is set up for it, you c
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/547#issuecomment-129227036
Who wants to step in and finish this work? It seems the original author is
not able to finish it. If no one steps in, we'll have to close the PR without
merging
Github user mike-tutkowski commented on the pull request:
https://github.com/apache/cloudstack/pull/547#issuecomment-128594438
Aside from a couple minor comments, LGTM. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. I
Github user mike-tutkowski commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/547#discussion_r36490618
--- Diff:
engine/storage/volume/src/org/apache/cloudstack/storage/datastore/provider/DefaultHostListener.java
---
@@ -71,6 +74,17 @@ public boolea
Github user mike-tutkowski commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/547#discussion_r36490405
--- Diff:
engine/schema/src/org/apache/cloudstack/storage/datastore/db/PrimaryDataStoreDaoImpl.java
---
@@ -53,6 +53,7 @@
protected final
Github user mike-tutkowski commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/547#discussion_r36490233
--- Diff: core/src/com/cloud/agent/api/ModifyStoragePoolAnswer.java ---
@@ -26,6 +26,7 @@
public class ModifyStoragePoolAnswer extends Answer {
GitHub user likitha opened a pull request:
https://github.com/apache/cloudstack/pull/547
CLOUDSTACK-8601. VMFS storage added as local storage can be re-added â¦
â¦as shared storage.
Fail addition of a VMFS shared storage pool in case it has already been
added as local sto
15 matches
Mail list logo
