Github user mike-tutkowski commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/547#discussion_r36490405
--- Diff:
engine/schema/src/org/apache/cloudstack/storage/datastore/db/PrimaryDataStoreDaoImpl.java
---
@@ -53,6 +53,7 @@
protected final SearchBuilder<StoragePoolVO> DcPodSearch;
protected final SearchBuilder<StoragePoolVO> DcPodAnyClusterSearch;
protected final SearchBuilder<StoragePoolVO> DeleteLvmSearch;
+ protected final SearchBuilder<StoragePoolVO> DcLocalStorageSearch;
--- End diff --
By convention, variables do not typically start with a capital letter.
I realize here that you are likely just doing that to fit in with the other
nearby code.
This might be a nice opportunity to rename all six of these member
variables to start with a lower-case version of the applicable letter (possibly
even prefixing them with an underscore as many people recognize that as a
convention for a member variable).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
