Github user mike-tutkowski commented on the pull request:
https://github.com/apache/cloudstack/pull/547#issuecomment-137813369
Hey...I just noticed something.
I have a datastore that I manually added to my ESXi hosts (shared storage)
that is based on an iSCSI target.
When I restart the CS MS, this datastore (which I already added to
CloudStack as shared primary storage) gets re-added as local storage (so it's
listed as both shared and local primary storages).
I think this is perhaps what lead to this pull-request in the first place,
but the problem still exists.
What happens now that this pull-request code is in is that the datastore
conflict is detected and an error message is printed, but I still see my shared
primary storage has been added as well as local storage.
I'm looking into this more, but wanted to point out this observation.
I had forgotten about this issue (I think it's pretty old). At the time, we
put in a workaround where datastores that started with "-" or "_" were assumed
to be shared and not re-added as local. It just happens that my manually added,
shared datastore does not start with "-" or "_", so I see the problem.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
