Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/844#issuecomment-216190807
@ustcweizhou please rebase against latest master and push -f, update on
status of your PR
---
If your project is set up for it, you can reply to this email and have
Github user GabrielBrascher commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/844#discussion_r55611837
--- Diff: client/WEB-INF/classes/resources/messages.properties ---
@@ -1823,6 +1823,7 @@ message.after.enable.swift=Swift configured. Note\:
When
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/844#issuecomment-194147680
rebased, and fixed an issue in assignvm to project.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/844#issuecomment-175668842
@ustcweizhou Can you please meld the commits into a single commit, and
incorporate any remaining changes asked in the review?
Ping, can we have a re-review
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/844#issuecomment-152764843
did the regular regression suite in my sbp provided bubble and all passed.
network:
```
Create a redundant VPC with two networks with two VMs in
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/844#issuecomment-149149393
So that means the SG tests are missing still. Ok, I will add it to my
testing backlog.
---
If your project is set up for it, you can reply to this email and ha
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/844#issuecomment-149147999
@DaanHoogland I think the status is still the same as of 7 days ago. Or am
I missing something?
---
If your project is set up for it, you can reply to this
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/844#issuecomment-149146910
@miguelaferreira @remibergsma are you satisfied with this PR, now?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/844#issuecomment-147326575
no problem for me.
it is always good to get feedback from community. @miguelaferreira
I have some features/improvements to be ported from old CS to mainst
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/844#issuecomment-147325019
Thanks for clarifying @ustcweizhou
I guess that we then need to wait for when @wilderrodrigues will have time
to test the SGs.
---
If your project is s
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/844#issuecomment-147324618
@miguelaferreira
1. no, I did not test the same as @wilderrodrigues .
2. I've tested advanced zone (without security groups), it works fine. For
Advance
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/844#issuecomment-147312092
@ustcweizhou It is not clear to me if you tested the same things
@wilderrodrigues did, or if you tested "the security groups bit". Would you be
so kind as to
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/844#issuecomment-147311168
@miguelaferreira I have tested the test cases listed above. I think it is
isolated from other areas.
I agree more and careful testing are better. Can you
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/844#issuecomment-146845866
@ustcweizhou may I ask you if you believe that the change in this PR will
not impact the areas you mention because you've tested it (been manually?). Or
beca
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/844#issuecomment-146839857
@wilderrodrigues thanks for you testing. I believe this PR will not impact
the current network/vr/storage.
It will only change the owner of a vm, and add the
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/844#issuecomment-146240976
Hi @ustcweizhou @DaanHoogland @remibergsma @karuturi @miguelaferreira
I executed the tests on my side. Despite some exceptions with network
cleanup
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/844#issuecomment-146175526
Hi @ustcweizhou
Thanks for the details. Are there some integration tests that we could use
to cover the cases you described?
I can runt the
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/844#issuecomment-145445260
guys, anyone has update ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does no
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/844#issuecomment-142515867
@wilderrodrigues
test cases
1. advanced zone
(1) a shared network for domain domain1.
account1: in domain 1, one isolated net
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/844#issuecomment-141095617
Hi @ustcweizhou ,
I will :-1: this PR until we get to know which integration tests you
executed, against which environment and the steps so we can d
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/844#issuecomment-141086916
The build job already passed the point it had failed before
(fingers-crossed)
---
If your project is set up for it, you can reply to this email and have you
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/844#issuecomment-141065052
@DaanHoogland @miguelaferreira @wilderrodrigues
I have rebase with the lastest master, and force push to github.
let's see if it will be fixed.
---
If
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/844#issuecomment-141064763
Thanks for rebasing @ustcweizhou
The pull-analysis is now running.
https://builds.apache.org/job/cloudstack-pull-analysis/583/
Lets keep an e
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/844#issuecomment-141059487
@DaanHoogland @wilderrodrigues @ustcweizhou I agree with Daan, the problem
is most likely elsewhere. But I also agree with Wilder, first we need to figure
o
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/844#issuecomment-141058143
@wilderrodrigues that is not fair, it is not @ustcweizhou 's bug that needs
fixing!
---
If your project is set up for it, you can reply to this email and have
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/844#issuecomment-141052485
@ustcweizhou ,
Which tests did you execute?
I would say: no merge until it's fixed, tested by @ustcweizhou and he let
us know how we should
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/844#issuecomment-141051316
@ustcweizhou @miguelaferreira @karuturi @remibergsma so no merges till this
is fixed?
---
If your project is set up for it, you can reply to this email and ha
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/844#issuecomment-140833060
Apache Jenkins build reports 5 failing tests
(https://builds.apache.org/job/cloudstack-pull-analysis/575/testReport/)
https://cloud.githubuserconten
GitHub user ustcweizhou opened a pull request:
https://github.com/apache/cloudstack/pull/844
CLOUDSTACK-7985: assignVM in Advanced zone with Security Groups
This commit contains the following changes:
(1) implementation of assignVM in Advanced zone with Security Groups
(2) ke
29 matches
Mail list logo
