Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/844#issuecomment-146175526 Hi @ustcweizhou Thanks for the details. Are there some integration tests that we could use to cover the cases you described? I can runt the following tests to make sure it doesn't break existing features: ``` echo "Running tests with required_hardware=true" nosetests --with-marvin --marvin-config=[MARVIN_CONFIG_HERE] -s -a tags=advanced,required_hardware=true \ component/test_vpc_redundant.py \ component/test_routers_iptables_default_policy.py \ component/test_vpc_router_nics.py echo "Running tests with required_hardware=false" nosetests --with-marvin --marvin-config=[MARVIN_CONFIG_HERE] -s -a tags=advanced,required_hardware=false \ smoke/test_routers.py \ smoke/test_network_acl.py \ smoke/test_privategw_acl.py \ smoke/test_reset_vm_on_reboot.py \ smoke/test_vm_life_cycle.py \ smoke/test_vpc_vpn.py \ smoke/test_service_offerings.py \ component/test_vpc_offerings.py \ component/test_vpc_routers.py ``` But I'm not sure if those tests will cover all of your changes. Cheers, Wilder
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---