Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/844#issuecomment-147324618
@miguelaferreira
1. no, I did not test the same as @wilderrodrigues .
2. I've tested advanced zone (without security groups), it works fine. For
Advanced zone with security group, I used this code in 4.2.1 for long time,
then I ported to mainstream.sorry I did not test it in advanced zone with SG.
However, compared to the implementation for Basic zone, I think this code is
good.
3. Different from PR #761 which might be called by other functions, this PR
is just an implementation for AssignVM in advanced zone with SG. The worst
problem I can see is that this functionality does not work, but it will never
impact other functionalities.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
