Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1365#issuecomment-216906241
Thanks @swill for verifying
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1365#issuecomment-216893135
Just as an update for everyone. CI ran against master with the merge
conflict fix and everything went smoothly, so we are all set. Thanks for the
help on this @rhty
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1365#issuecomment-216572547
No worries @GabrielBrascher, I realized after I CCed you that you really
just fixed a typo. :) Thanks for the feedback...
---
If your project is set up for it, you
Github user GabrielBrascher commented on the pull request:
https://github.com/apache/cloudstack/pull/1365#issuecomment-216571886
@swill I haven't worked much on that file (I had fixed a typo in the name
of the "ROOT_DISK_CONTROLLER" variable).
At the first look I would agree w
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1365#issuecomment-216541819
@mike-tutkowski, yes I think the change is expected. I just want some more
eyes on this since it did not go through the usual CI and code review channels
because we
Github user mike-tutkowski commented on the pull request:
https://github.com/apache/cloudstack/pull/1365#issuecomment-216446492
@swill It seems reasonable to me. It doesn't look like equivalent
functionality to what was previously there, but presumably that was why it was
changed?
-
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1365#issuecomment-216442130
@rhtyd thanks for fixing the merge conflicts. ð
@GabrielBrascher and @mike-tutkowski, I know you guys have spent some time
with this file, would you guys
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1365#issuecomment-216433479
Obviously this merge conflict exists because something has been refactored
in master which was not merged into previous versions. We need to understand
what was done
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1365#discussion_r61833516
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorageProcessor.java
---
@@ -1363,24 +1364,15 @@ private Answer attachVolume(Co
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1365#discussion_r61833203
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorageProcessor.java
---
@@ -1363,24 +1364,15 @@ private Answer attachVolume(Co
Github user swill commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1365#discussion_r61807823
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorageProcessor.java
---
@@ -1363,24 +1364,15 @@ private Answer attachVolume(Co
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1365
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1365#issuecomment-216304460
Thanks @DaanHoogland -- though there is a way to run ESXi6 with vCenter 6
on KVM (http://rohit.yadav.xyz/logs/vmware-esxi-vcenter-on-kvm-cloudstack)
/cc @swil
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1365#issuecomment-216248411
did a code walk through and saw no extravaganzas and some useful
extractions and renamings. As for the functionality, I have no clue. I am not a
vmware user, l
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1365#issuecomment-216221452
@agneya2001 @jburwell @DaanHoogland @sureshanaparti LGTM/review please,
thanks
---
If your project is set up for it, you can reply to this email and have your
reply
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1365#issuecomment-216185039
tag:easypr
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1365#issuecomment-215506015
These CI results basically show that the standard VM workflow in KVM is not
affected. I don't have the ability to test this on VMware, but I know you guys
are alread
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1365#issuecomment-215505081
### CI RESULTS
```
Tests Run: 85
Skipped: 0
Failed: 0
Errors: 0
```
**Associated Uploads**
**
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1365#issuecomment-213329597
@GabrielBrascher @swill @jburwell @rafaelweingartner please share your LGTM
or comment what needs fixing, thanks.
---
If your project is set up for it, you can re
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1365#issuecomment-211785845
@swill we're good with this PR and it is not dependent on any other PR. For
building noredist rpms/deb, one can use this repo with the dep-jars --
https://github.c
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1365#discussion_r60188424
--- Diff: pom.xml ---
@@ -92,7 +92,7 @@
2.5
1.2
1.0-20081010.060147
-5.5
+6.0
--- End diff --
@r
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1365#issuecomment-211565374
@rafaelweingartner I am not sure. @bhaisaab would you mind clarifying for
us. I am trying to stay on top of this stuff, but I am very much playing
catchup. :)
--
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1365#issuecomment-211555695
@swill my final state is LGTM, will this be merged forward?
I believe @bhaisaab has mentioned that he has another PR that bumps VMware
dependencies and
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1365#issuecomment-211554643
I think this one is pretty close. I want to run CI against it since there
have been changes since the last CI run. I also need some LGTM code reviews.
I don't see
As I said I understand the check of "vm!= null". I was only referring to
the "vm.getType". I did not know that it could not be null.
I think what you were trying to say is that, once "vm" object is not null,
there is no way "getType" can return null, right? If that is a sure thing,
I am ok with th
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1365#discussion_r60096454
--- Diff: server/src/com/cloud/storage/VolumeApiServiceImpl.java ---
@@ -1835,6 +1847,26 @@ private Volume orchestrateDetachVolumeFromVM(long
vmId, long
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1365#issuecomment-211479815
if you say so.
Be my guest.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1365#issuecomment-211479011
@rafaelweingartner both your comments are opinionated and not technical;
we've to agree to disagree here ask you to be practical and pragmatic here.
I've left comm
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1365#discussion_r60095758
--- Diff: server/src/com/cloud/storage/VolumeApiServiceImpl.java ---
@@ -1835,6 +1847,26 @@ private Volume orchestrateDetachVolumeFromVM(long
v
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1365#discussion_r60095074
--- Diff: server/src/com/cloud/storage/VolumeApiServiceImpl.java ---
@@ -1835,6 +1847,26 @@ private Volume orchestrateDetachVolumeFromVM(long
vmId, long
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1365#issuecomment-211359119
@swill , @bhaisaab
There are still questions to be addressed here. One example is the question
at âVolumeApiServiceImplâ line1857. Another one is
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1365#discussion_r60035619
--- Diff: server/src/com/cloud/storage/VolumeApiServiceImpl.java ---
@@ -1835,6 +1847,26 @@ private Volume orchestrateDetachVolumeFromVM(long
v
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1365#issuecomment-211264892
@swill can we get this merged, while ShapeBlue has tested this internally
if you test with your non-vmware CI that should confirm it does not break
anything else;
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1365#discussion_r59486755
--- Diff: server/src/com/cloud/storage/VolumeApiServiceImpl.java ---
@@ -1835,6 +1847,26 @@ private Volume orchestrateDetachVolumeFromVM(long
vmId, long
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1365#discussion_r58941182
--- Diff: server/src/com/cloud/storage/VolumeApiServiceImpl.java ---
@@ -1835,6 +1847,26 @@ private Volume orchestrateDetachVolumeFromVM(long
v
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1365#discussion_r58940609
--- Diff: server/src/com/cloud/storage/VolumeApiServiceImpl.java ---
@@ -1835,6 +1847,26 @@ private Volume orchestrateDetachVolumeFromVM(long
v
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1365#discussion_r58931640
--- Diff: server/src/com/cloud/storage/VolumeApiServiceImpl.java ---
@@ -1835,6 +1847,25 @@ private Volume orchestrateDetachVolumeFromVM(long
vmId, long
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1365#discussion_r58929616
--- Diff: server/src/com/cloud/storage/VolumeApiServiceImpl.java ---
@@ -1835,6 +1847,25 @@ private Volume orchestrateDetachVolumeFromVM(long
v
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1365#issuecomment-207022111
I can't specifically test the VMware functionality, but I can validate that
it does not break anything else. I have added this to my queue for CI.
---
If your proje
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1365#issuecomment-207019005
@swill @rafaelweingartner @jburwell fixed outstanding issues and added more
unit tests
---
If your project is set up for it, you can reply to this email and have
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1365#discussion_r58906935
--- Diff:
utils/src/test/java/org/apache/cloudstack/utils/volume/VirtualMachineDiskInfoTest.java
---
@@ -0,0 +1,46 @@
+//
+// Licensed to the A
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1365#discussion_r58906447
--- Diff:
utils/src/main/java/org/apache/cloudstack/utils/volume/VirtualMachineDiskInfo.java
---
@@ -39,4 +38,11 @@ public void setDiskDeviceBusName(St
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1365#discussion_r58906077
--- Diff: server/test/com/cloud/vm/UserVmManagerTest.java ---
@@ -928,4 +928,13 @@ public void testUpdateVmNicIpFailure3() throws
Exception {
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1365#discussion_r58904980
--- Diff: server/src/com/cloud/vm/UserVmManagerImpl.java ---
@@ -5455,6 +5456,15 @@ private void encryptAndStorePassword(UserVmVO vm,
String password) {
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1365#discussion_r58904519
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorageProcessor.java
---
@@ -1363,24 +1363,17 @@ private Answer attachVolume
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1365#discussion_r58904000
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -4729,6 +4729,17 @@ private VirtualMachineGues
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1365#discussion_r58903873
--- Diff:
vmware-base/src/com/cloud/hypervisor/vmware/mo/GuestOsDescriptorType.java ---
@@ -0,0 +1,46 @@
+// Licensed to the Apache Software Foundat
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1365#discussion_r58903775
--- Diff:
vmware-base/src/com/cloud/hypervisor/vmware/mo/VirtualMachineMO.java ---
@@ -2137,7 +2141,8 @@ public int getScsiDiskControllerKey(String
dis
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1365#discussion_r58903799
--- Diff:
vmware-base/src/com/cloud/hypervisor/vmware/mo/VirtualMachineMO.java ---
@@ -2118,8 +2118,12 @@ public int getScsiDiskControllerKey(String
di
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1365#discussion_r58803540
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -4729,6 +4729,17 @@ private VirtualMa
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1365#discussion_r58787329
--- Diff: server/test/com/cloud/vm/UserVmManagerTest.java ---
@@ -928,4 +928,13 @@ public void testUpdateVmNicIpFailure3() throws
Exception {
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1365#discussion_r58786157
--- Diff:
vmware-base/src/com/cloud/hypervisor/vmware/mo/VirtualMachineMO.java ---
@@ -2137,7 +2141,8 @@ public int getScsiDiskControllerKey(String
dis
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1365#discussion_r58786110
--- Diff:
vmware-base/src/com/cloud/hypervisor/vmware/mo/VirtualMachineMO.java ---
@@ -2137,7 +2141,8 @@ public int getScsiDiskControllerKey(String
dis
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1365#discussion_r58785773
--- Diff:
vmware-base/src/com/cloud/hypervisor/vmware/mo/VirtualMachineMO.java ---
@@ -2118,8 +2118,12 @@ public int getScsiDiskControllerKey(String
di
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1365#discussion_r58785250
--- Diff:
utils/src/test/java/org/apache/cloudstack/utils/volume/VirtualMachineDiskInfoTest.java
---
@@ -0,0 +1,46 @@
+//
+// Licensed to the A
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1365#discussion_r58784849
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -4729,6 +4729,17 @@ private VirtualMachineGues
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1365#discussion_r58782658
--- Diff:
utils/src/main/java/org/apache/cloudstack/utils/volume/VirtualMachineDiskInfo.java
---
@@ -39,4 +38,11 @@ public void setDiskDeviceBusName(St
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1365#discussion_r58782564
--- Diff:
utils/src/main/java/org/apache/cloudstack/utils/volume/VirtualMachineDiskInfo.java
---
@@ -39,4 +38,11 @@ public void setDiskDeviceBusName(St
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1365#discussion_r58782481
--- Diff: server/src/com/cloud/vm/UserVmManagerImpl.java ---
@@ -5455,6 +5456,15 @@ private void encryptAndStorePassword(UserVmVO vm,
String password) {
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1365#discussion_r58782174
--- Diff: server/src/com/cloud/storage/VolumeApiServiceImpl.java ---
@@ -1924,6 +1935,23 @@ public Volume migrateVolume(MigrateVolumeCmd cmd) {
Github user GabrielBrascher commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1365#discussion_r58781801
--- Diff: server/src/com/cloud/storage/VolumeApiServiceImpl.java ---
@@ -1924,6 +1935,23 @@ public Volume migrateVolume(MigrateVolumeCmd cmd) {
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1365#discussion_r58780935
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorageProcessor.java
---
@@ -1363,24 +1363,17 @@ private Answer attachVolume
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1365#discussion_r58780807
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorageProcessor.java
---
@@ -1363,24 +1363,17 @@ private Answer attachVolume
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1365#discussion_r58780261
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -4729,6 +4729,17 @@ private VirtualMa
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1365#discussion_r58779767
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -4729,6 +4729,17 @@ private VirtualMa
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1365#discussion_r58778722
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -4729,6 +4729,17 @@ private VirtualMachineGues
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1365#discussion_r58778373
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -4729,6 +4729,17 @@ private VirtualMachineGues
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1365#discussion_r58778117
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -4729,6 +4729,17 @@ private VirtualMachineGues
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1365#discussion_r58768337
--- Diff: server/src/com/cloud/storage/VolumeApiServiceImpl.java ---
@@ -1924,6 +1935,23 @@ public Volume migrateVolume(MigrateVolumeCmd cmd) {
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1365#discussion_r58767464
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -4729,6 +4729,17 @@ private VirtualMa
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1365#discussion_r58766497
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -4729,6 +4729,17 @@ private VirtualMa
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1365#discussion_r58763970
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -4729,6 +4729,17 @@ private VirtualMachineGues
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1365#discussion_r58763620
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -4729,6 +4729,17 @@ private VirtualMachineGues
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1365#discussion_r58763269
--- Diff: server/src/com/cloud/storage/VolumeApiServiceImpl.java ---
@@ -1924,6 +1935,23 @@ public Volume migrateVolume(MigrateVolumeCmd cmd) {
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1365#discussion_r58762975
--- Diff: server/src/com/cloud/storage/VolumeApiServiceImpl.java ---
@@ -1924,6 +1935,23 @@ public Volume migrateVolume(MigrateVolumeCmd cmd) {
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1365#discussion_r58762482
--- Diff: server/src/com/cloud/vm/UserVmManagerImpl.java ---
@@ -5455,6 +5456,15 @@ private void encryptAndStorePassword(UserVmVO vm,
String password) {
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1365#discussion_r58744278
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -4729,6 +4729,17 @@ private VirtualMa
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1365#discussion_r58743708
--- Diff: server/src/com/cloud/vm/UserVmManagerImpl.java ---
@@ -5455,6 +5456,15 @@ private void encryptAndStorePassword(UserVmVO vm,
String pa
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1365#discussion_r58743442
--- Diff: server/src/com/cloud/storage/VolumeApiServiceImpl.java ---
@@ -1924,6 +1935,23 @@ public Volume migrateVolume(MigrateVolumeCmd cmd) {
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1365#discussion_r58743070
--- Diff: server/src/com/cloud/storage/VolumeApiServiceImpl.java ---
@@ -1924,6 +1935,23 @@ public Volume migrateVolume(MigrateVolumeCmd cmd) {
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1365#discussion_r58742032
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -4729,6 +4729,17 @@ private VirtualMa
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1365#issuecomment-206435758
I would like to get at least one code review with a LGTM before I merge. I
am pretty confident with the tests run. As long as we get 105 tests passing in
that CI en
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1365#issuecomment-206185015
@swill fyi, this was a production issue that was delivered as a patch and
this was heavily tested by ShapeBlue internally against vmware environment with
several r
Github user bvbharatk commented on the pull request:
https://github.com/apache/cloudstack/pull/1365#issuecomment-199232343
### ACS CI BVT Run
**Sumarry:**
Build Number 114
Hypervisor xenserver
NetworkType Advanced
Passed=105
Failed=13
Skipped=4
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1365#discussion_r53929677
--- Diff:
vmware-base/src/com/cloud/hypervisor/vmware/mo/GuestOsDescriptorType.java ---
@@ -0,0 +1,46 @@
+// Licensed to the Apache Software Foundat
Github user GabrielBrascher commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1365#discussion_r52853711
--- Diff:
vmware-base/src/com/cloud/hypervisor/vmware/mo/GuestOsDescriptorType.java ---
@@ -0,0 +1,46 @@
+// Licensed to the Apache Software
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1365#discussion_r52050632
--- Diff: core/src/org/apache/cloudstack/storage/command/AttachAnswer.java
---
@@ -34,6 +37,12 @@ public AttachAnswer(DiskTO disk) {
setDis
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1365#discussion_r51719809
--- Diff: core/src/org/apache/cloudstack/storage/command/AttachAnswer.java
---
@@ -34,6 +37,12 @@ public AttachAnswer(DiskTO disk) {
setDis
Github user GabrielBrascher commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1365#discussion_r51717944
--- Diff: core/src/org/apache/cloudstack/storage/command/AttachAnswer.java
---
@@ -34,6 +37,12 @@ public AttachAnswer(DiskTO disk) {
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1365#issuecomment-178696450
@GabrielBrascher thanks, fixed the accessor
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If you
Github user GabrielBrascher commented on the pull request:
https://github.com/apache/cloudstack/pull/1365#issuecomment-177495811
@bhaisaab Thanks for the test and StringUtils fix.
**-** Could you please change the Access Levels of diskDeviceBusName and
diskChain from public to
91 matches
Mail list logo
