Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1365#discussion_r58782481
  
    --- Diff: server/src/com/cloud/vm/UserVmManagerImpl.java ---
    @@ -5455,6 +5456,15 @@ private void encryptAndStorePassword(UserVmVO vm, 
String password) {
             }
         }
     
    +    public void persistDeviceBusInfo(UserVmVO vm, String 
rootDiskController) {
    +        String existingVmRootDiskController = 
vm.getDetail(VmDetailConstants.ROOT_DISK_CONTROLLER);
    +        if (StringUtils.isEmpty(existingVmRootDiskController) && 
!StringUtils.isEmpty(rootDiskController)) {
    +            vm.setDetail(VmDetailConstants.ROOT_DISK_CONTROLLER, 
rootDiskController);
    +            _vmDao.saveDetails(vm);
    +            s_logger.debug("Persisted device bus information 
rootDiskController=" + rootDiskController + " for vm: " + vm.getDisplayName());
    --- End diff --
    
    Wrap this ``debug`` call in a ``if (isDebugEnabled()`` block.  Also, please 
add the vm id to the log message to assist with debugging.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to