Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1365#discussion_r58782174
--- Diff: server/src/com/cloud/storage/VolumeApiServiceImpl.java ---
@@ -1924,6 +1935,23 @@ public Volume migrateVolume(MigrateVolumeCmd cmd) {
throw new
InvalidParameterValueException("Cannot migrate ROOT volume of a stopped VM to a
storage pool in a different VMware datacenter");
}
}
+
--- End diff --
agree with @rafaelweingartner. All methods should have a single
responsibility -- it is critical to maintainability and testability. While it
is not possible to fix this problem all at once, we certainly shouldn't be
adding to it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
