[GitHub] cloudstack-www issue #34: Remove link to “planet.apache.org” and update ...

2017-02-02 Thread terbolous
Github user terbolous commented on the issue: https://github.com/apache/cloudstack-www/pull/34 Actually @swill, searching through JIRA and infra mailing lists it seems that it is possible for a role commit by certain ASF jenkins slaves [0], [1] Talked to @Humbedooh a bit

[GitHub] cloudstack-www issue #34: Remove link to “planet.apache.org” and update ...

2017-02-02 Thread terbolous
Github user terbolous commented on the issue: https://github.com/apache/cloudstack-www/pull/34 The actual changes looks good, but shouldn't you update the markdown in `source/` rather than the generated html? --- If your project is set up for it, you can reply to this email and

[GitHub] cloudstack-www pull request #33: Updated the 2017 conference details

2017-01-26 Thread terbolous
Github user terbolous commented on a diff in the pull request: https://github.com/apache/cloudstack-www/pull/33#discussion_r98154267 --- Diff: source/index.html.erb --- @@ -113,22 +113,23 @@ Join Us - 2016 CloudStack Collaboration

[GitHub] cloudstack-www pull request #33: Updated the 2017 conference details

2017-01-26 Thread terbolous
Github user terbolous commented on a diff in the pull request: https://github.com/apache/cloudstack-www/pull/33#discussion_r98102390 --- Diff: source/index.html.erb --- @@ -113,22 +113,23 @@ Join Us - 2016 CloudStack Collaboration

[GitHub] cloudstack-www pull request #29: Added Delimiter Corp to known users

2016-12-01 Thread terbolous
GitHub user terbolous opened a pull request: https://github.com/apache/cloudstack-www/pull/29 Added Delimiter Corp to known users You can merge this pull request into a Git repository by running: $ git pull https://github.com/terbolous/cloudstack-www master Alternatively you

[GitHub] cloudstack pull request: ui: fix typo in dashboard's fetchlatest u...

2016-04-04 Thread terbolous
Github user terbolous commented on the pull request: https://github.com/apache/cloudstack/pull/1462#issuecomment-205654507 @bhaisaab here you go: https://issues.apache.org/jira/browse/CLOUDSTACK-9335 please update the PR and add the issue to the title --- If your project is

[GitHub] cloudstack pull request: ui: fix typo in dashboard's fetchlatest u...

2016-04-04 Thread terbolous
Github user terbolous commented on the pull request: https://github.com/apache/cloudstack/pull/1462#issuecomment-205178712 Tested this manually by patching dashboard.js and re-gzipping it. The parameter is now passed as 'fetchLatest' as it should. ![Request

[GitHub] cloudstack-www pull request: Updated list with makewholist.py

2016-02-24 Thread terbolous
Github user terbolous commented on the pull request: https://github.com/apache/cloudstack-www/pull/25#issuecomment-188276456 My bad, they aren't actually removed from the emeritus list, just added to the active list. --- If your project is set up for it, you can reply to

[GitHub] cloudstack-www pull request: Updated list with makewholist.py

2016-02-24 Thread terbolous
Github user terbolous commented on the pull request: https://github.com/apache/cloudstack-www/pull/25#issuecomment-188271943 Some of these are moved from emeritus to active with this commit --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack-docs pull request: Add Nuage plugin to the list

2016-01-11 Thread terbolous
Github user terbolous commented on the pull request: https://github.com/apache/cloudstack-docs/pull/15#issuecomment-170481810 done --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack-docs pull request: Inclusion of Nuage-VSP plugin

2016-01-05 Thread terbolous
Github user terbolous commented on the pull request: https://github.com/apache/cloudstack-docs/pull/14#issuecomment-168970701 already made a PR for it :) #15 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack-docs pull request: Add Nuage plugin to the list

2016-01-05 Thread terbolous
GitHub user terbolous opened a pull request: https://github.com/apache/cloudstack-docs/pull/15 Add Nuage plugin to the list You can merge this pull request into a Git repository by running: $ git pull https://github.com/terbolous/cloudstack-docs master Alternatively you can

[GitHub] cloudstack-docs pull request: Inclusion of Nuage-VSP plugin

2016-01-05 Thread terbolous
Github user terbolous commented on the pull request: https://github.com/apache/cloudstack-docs/pull/14#issuecomment-168939634 It is there (http://docs.cloudstack.apache.org/en/latest/networking/nuage-plugin.html) but should be linked to from the index and networking pages. --- If

[GitHub] cloudstack pull request: Strongswan vpn feature

2016-01-05 Thread terbolous
Github user terbolous commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/872#discussion_r48824088 --- Diff: systemvm/patches/debian/config/opt/cloud/bin/configure.py --- @@ -479,13 +479,13 @@ def process(self): def deletevpn(self, ip

[GitHub] cloudstack pull request: Strongswan vpn feature

2016-01-04 Thread terbolous
Github user terbolous commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/872#discussion_r48774570 --- Diff: systemvm/patches/debian/config/opt/cloud/bin/configure.py --- @@ -479,13 +479,13 @@ def process(self): def deletevpn(self, ip

[GitHub] cloudstack pull request: Setup routes for RFC 1918 ip space

2015-12-11 Thread terbolous
Github user terbolous commented on the pull request: https://github.com/apache/cloudstack/pull/1214#issuecomment-163912372 Although it is technically possible to use official ip address space on the public network with routes to rfc1918 I don't know if those scenarios are wides

[GitHub] cloudstack pull request: Setup routes for RFC 1918 ip space

2015-12-11 Thread terbolous
Github user terbolous commented on the pull request: https://github.com/apache/cloudstack/pull/1214#issuecomment-163906540 Not sure how easy it is to implement, but a configuration setting for 'route rfc1918 per default via the internal network' would probably satisy my

[GitHub] cloudstack pull request: Setup routes for RFC 1918 ip space

2015-12-11 Thread terbolous
Github user terbolous commented on the pull request: https://github.com/apache/cloudstack/pull/1214#issuecomment-16388 My point would be a setup like this: Management network: 10.1.1.0/24 - this is the internal network on eth2 Configured public network: 172.16.1.0/24

[GitHub] cloudstack pull request: L10N update before 4.7.0 RC1

2015-12-11 Thread terbolous
Github user terbolous commented on the pull request: https://github.com/apache/cloudstack/pull/1217#issuecomment-163875819 ping @milamberspace Norwegian updated :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: Setup routes for RFC 1918 ip space

2015-12-10 Thread terbolous
Github user terbolous commented on the pull request: https://github.com/apache/cloudstack/pull/1214#issuecomment-163867518 Might only be me, but I think it is a bit assumptious to assume that the internal network is routable for everyone. To clarify I am mostly worried about the

[GitHub] cloudstack pull request: Setup routes for RFC 1918 ip space

2015-12-10 Thread terbolous
Github user terbolous commented on the pull request: https://github.com/apache/cloudstack/pull/1214#issuecomment-163862541 What about users who solely use rfc1918 address space? That could easily be the case for internal or enterprise users. I am in doubt about this change, as I

[GitHub] cloudstack pull request: Fixed issues with test_vpc_vpn script

2015-12-07 Thread terbolous
Github user terbolous commented on the pull request: https://github.com/apache/cloudstack/pull/1156#issuecomment-162797528 @sanju1010 it works for XenServer as well atleast, haven't tried VMware. But you'll have to change your script to adjust to the different output -

[GitHub] cloudstack pull request: Fixed issues with test_vpc_vpn script

2015-12-07 Thread terbolous
Github user terbolous commented on the pull request: https://github.com/apache/cloudstack/pull/1156#issuecomment-162544664 @sanju1010 the error lies in the script due to different outputs. the test seems to use macchinina as template, which has the following output for ping

[GitHub] cloudstack pull request: Strongswan vpn feature

2015-12-07 Thread terbolous
Github user terbolous commented on the pull request: https://github.com/apache/cloudstack/pull/872#issuecomment-162467255 @DaanHoogland: yes, we're unable to use 4.6 due to the bug mentioned. now, the original issue may be fixed in 4.6 with openswan later, but i would much rathe

[GitHub] cloudstack pull request: Strongswan vpn feature

2015-12-06 Thread terbolous
Github user terbolous commented on the pull request: https://github.com/apache/cloudstack/pull/872#issuecomment-162437862 @jayapalu that would be great, but due note that feature freeze is today. @remibergsma @DaanHoogland: is this really a new feature, rather an improvement, no

[GitHub] cloudstack pull request: Strongswan vpn feature

2015-12-04 Thread terbolous
Github user terbolous commented on the pull request: https://github.com/apache/cloudstack/pull/872#issuecomment-162106175 @jayapalu i believe that is broken in 4.6 already, atleast i filed an issue for it with the current openswan implementation at https://issues.apache.org/jira

[GitHub] cloudstack-www pull request: downloads: State packages on download...

2015-11-25 Thread terbolous
Github user terbolous commented on the pull request: https://github.com/apache/cloudstack-www/pull/20#issuecomment-159585876 @karuturi there is the issue with noredist under ASF though, how about we move this as a discuss thread to dev@? there are more changes that could be discussed

[GitHub] cloudstack-www pull request: downloads: State packages on download...

2015-11-25 Thread terbolous
Github user terbolous commented on the pull request: https://github.com/apache/cloudstack-www/pull/20#issuecomment-159543089 According to @ke4qqq we should be able to use packages.apache.org (see https://mail-archives.apache.org/mod_mbox/cloudstack-dev/201506.mbox/%3CCAKprHVYH+m-A2g

[GitHub] cloudstack-www pull request: downloads: State packages on download...

2015-11-24 Thread terbolous
Github user terbolous commented on the pull request: https://github.com/apache/cloudstack-www/pull/20#issuecomment-159526854 @remibergsma If we state that packages are 3rd party it gives sense (imho) to inform who makes those packages. the regular ones from apt-get.eu could be

[GitHub] cloudstack-www pull request: Update the list of known CloudStack u...

2015-11-04 Thread terbolous
Github user terbolous commented on a diff in the pull request: https://github.com/apache/cloudstack-www/pull/17#discussion_r43938320 --- Diff: source/users.markdown --- @@ -229,5 +245,4 @@ If you noticed something wrong with your entry here (or if you’d like us to r

[GitHub] cloudstack-www pull request: Update the list of known CloudStack u...

2015-11-04 Thread terbolous
GitHub user terbolous opened a pull request: https://github.com/apache/cloudstack-www/pull/17 Update the list of known CloudStack users Based on formwize as of 2015/11/04 You can merge this pull request into a Git repository by running: $ git pull https://github.com/terbolous

[GitHub] cloudstack-docs-admin pull request: Clarified GPU description.

2015-11-03 Thread terbolous
Github user terbolous commented on the pull request: https://github.com/apache/cloudstack-docs-admin/pull/31#issuecomment-153312934 LGTM, verified in the github preview that the output renders correctly. --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack pull request: CLOUDSTACK-8977: remove session creation ...

2015-10-30 Thread terbolous
Github user terbolous commented on the pull request: https://github.com/apache/cloudstack/pull/961#issuecomment-152491165 just proves that we really need a new web ui :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cloudstack pull request: Strongswan vpn feature

2015-10-29 Thread terbolous
Github user terbolous commented on the pull request: https://github.com/apache/cloudstack/pull/872#issuecomment-152123825 Any update here @jayapalu? @remibergsma @karuturi what is the chance for this getting into 4.6? replacing the old openswan would be good.. --- If your project is

[GitHub] cloudstack pull request: squashed commit for dockerfiles part#2 in...

2015-10-29 Thread terbolous
Github user terbolous commented on the pull request: https://github.com/apache/cloudstack/pull/999#issuecomment-152107883 The changes themselves LGTM, I can test them as well just to be sure, takes some time though :-) --- If your project is set up for it, you can reply to this

[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-8994 Add logging for the...

2015-10-28 Thread terbolous
Github user terbolous commented on the pull request: https://github.com/apache/cloudstack/pull/983#issuecomment-151776994 How does this impact logrotating? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack-www pull request: Improvements to survey.html

2015-10-13 Thread terbolous
Github user terbolous commented on the pull request: https://github.com/apache/cloudstack-www/pull/16#issuecomment-147637056 I didn't touch the html manually, but included the generated html in the commit. Not sure if that is necessary or not. Should I wait for a coup

[GitHub] cloudstack-www pull request: Improvements to survey.html

2015-10-12 Thread terbolous
GitHub user terbolous opened a pull request: https://github.com/apache/cloudstack-www/pull/16 Improvements to survey.html Made the survey.html agnostic to protocol used, previously the iframe was hardcoded with a http:// link and this breaks when visiting the site over https

[GitHub] cloudstack pull request: Dockerfile part2

2015-10-05 Thread terbolous
Github user terbolous commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/910#discussion_r41142674 --- Diff: tools/docker/init.sh_centos6 --- @@ -17,27 +17,35 @@ # under the License. # # update database connection +# /usr/bin

[GitHub] cloudstack pull request: Dockerfile part2

2015-10-05 Thread terbolous
Github user terbolous commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/910#discussion_r41121330 --- Diff: tools/docker/Dockerfile.centos6 --- @@ -23,15 +23,19 @@ LABEL Vendor="Apache.org" License="ApacheV2" Version="4.6.

[GitHub] cloudstack pull request: Dockerfile part2

2015-10-05 Thread terbolous
Github user terbolous commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/910#discussion_r41120279 --- Diff: tools/docker/Dockerfile.centos6 --- @@ -23,15 +23,19 @@ LABEL Vendor="Apache.org" License="ApacheV2" Version="4.6.

[GitHub] cloudstack pull request: Strongswan vpn feature

2015-09-22 Thread terbolous
Github user terbolous commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/872#discussion_r40074130 --- Diff: systemvm/patches/debian/vpn/etc/ipsec.d/l2tp.conf --- @@ -30,4 +33,6 @@ conn L2TP-PSK

[GitHub] cloudstack pull request: Configured dnsmasq to listen on all inter...

2015-09-22 Thread terbolous
Github user terbolous commented on the pull request: https://github.com/apache/cloudstack/pull/870#issuecomment-142232541 Tested by implementing the fix manually and testing DNS over VPC RA VPN. Works as expected. LGTM --- If your project is set up for it, you can reply to

[GitHub] cloudstack-www pull request: update download URL

2015-09-01 Thread terbolous
Github user terbolous commented on the pull request: https://github.com/apache/cloudstack-www/pull/15#issuecomment-136613436 @runseb Ok, no worries then :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack-www pull request: update download URL

2015-08-31 Thread terbolous
Github user terbolous commented on the pull request: https://github.com/apache/cloudstack-www/pull/15#issuecomment-136596035 Looks good to me, but have we been informed of this change from infra? Did a search for closer.cgi and closer.lua in my mailbox, and the only reference I found

[GitHub] cloudstack pull request: messages: fix string in pt_BR translation...

2015-08-27 Thread terbolous
Github user terbolous commented on the pull request: https://github.com/apache/cloudstack/pull/749#issuecomment-135321371 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack-www pull request: Python script to generate pmc and com...

2015-08-27 Thread terbolous
Github user terbolous commented on a diff in the pull request: https://github.com/apache/cloudstack-www/pull/14#discussion_r38068791 --- Diff: makewholist.py --- @@ -0,0 +1,68 @@ +#!/usr/bin/env python +# Licensed to the Apache Software Foundation (ASF) under one +# or

[GitHub] cloudstack-www pull request: Python script to generate pmc and com...

2015-08-27 Thread terbolous
Github user terbolous commented on the pull request: https://github.com/apache/cloudstack-www/pull/14#issuecomment-135317900 As mentioned in #13, I went ahead and made a script that does not rely on any ASF privileges. --- If your project is set up for it, you can reply to this

[GitHub] cloudstack-www pull request: Python script to generate pmc and com...

2015-08-27 Thread terbolous
GitHub user terbolous opened a pull request: https://github.com/apache/cloudstack-www/pull/14 Python script to generate pmc and commiter list Made a small tool to create pmc and committer list by parsing the JSON files on projects.apache.org. This is accessible by anyone and

[GitHub] cloudstack-www pull request: Moved Remi to PMC list

2015-08-26 Thread terbolous
Github user terbolous commented on the pull request: https://github.com/apache/cloudstack-www/pull/13#issuecomment-135307448 I like having tools that help us do the job right, and equally, every time. However, if we were to choose an official tool for the job it should be usable

[GitHub] cloudstack-www pull request: Moved Remi to PMC list

2015-08-26 Thread terbolous
Github user terbolous commented on the pull request: https://github.com/apache/cloudstack-www/pull/13#issuecomment-135171873 It wasn't meant as a -1 vote really, just a note that there's a discrepancy that should be settled. Remi does after all belong in the PMC table :-

[GitHub] cloudstack-www pull request: Moved Remi to PMC list

2015-08-26 Thread terbolous
Github user terbolous commented on the pull request: https://github.com/apache/cloudstack-www/pull/13#issuecomment-135166727 There's a small discrepancy about how to list PMC members. Previous to this[1] commit, they were listed in a separate table (moved from committers t

[GitHub] cloudstack pull request: fix debian package after addition of lice...

2015-08-26 Thread terbolous
Github user terbolous commented on the pull request: https://github.com/apache/cloudstack/pull/746#issuecomment-134991229 Verified that the command works as expected. LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack pull request: Git PR merge script improvements

2015-08-24 Thread terbolous
Github user terbolous commented on the pull request: https://github.com/apache/cloudstack/pull/734#issuecomment-134350634 Verified that it now works on my weird URL as well. LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: Git PR merge script improvements

2015-08-24 Thread terbolous
Github user terbolous commented on the pull request: https://github.com/apache/cloudstack/pull/734#issuecomment-134167474 @remibergsma it does point to the apache repo, but with a somewhat different url I used 'git clone gh:apache/cloudstack' to initialize the repo

[GitHub] cloudstack pull request: Git PR merge script improvements

2015-08-24 Thread terbolous
Github user terbolous commented on the pull request: https://github.com/apache/cloudstack/pull/734#issuecomment-134163621 On the other side, if you just drop the '.git' suffix, you risk matching things like 'cloudstack-docs-rn' while you really mean 'cloudsta

[GitHub] cloudstack pull request: Git PR merge script improvements

2015-08-24 Thread terbolous
Github user terbolous commented on the pull request: https://github.com/apache/cloudstack/pull/734#issuecomment-134163369 Might not be related as this is the first time I try the script, but I'm getting this: eriweb@eriweb:~/git/cloudstack/tools/git master$ git pr 735 --

[GitHub] cloudstack pull request: Update L10N resource files on master bran...

2015-08-19 Thread terbolous
Github user terbolous commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/699#discussion_r37389322 --- Diff: client/WEB-INF/classes/resources/messages_es.properties --- @@ -808,7 +808,7 @@ label.skip.guide=He utilizado CloudStack anteriormente

[GitHub] cloudstack pull request: Update L10N resource files on master bran...

2015-08-19 Thread terbolous
Github user terbolous commented on the pull request: https://github.com/apache/cloudstack/pull/699#issuecomment-132485606 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request: CLOUDSTACK-8744 Add missing localization ...

2015-08-19 Thread terbolous
Github user terbolous commented on the pull request: https://github.com/apache/cloudstack/pull/712#issuecomment-132484500 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request: Update L10N resource files on 4.5 branch ...

2015-08-19 Thread terbolous
Github user terbolous commented on the pull request: https://github.com/apache/cloudstack/pull/697#issuecomment-132484646 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request: Update L10N resource files on master bran...

2015-08-19 Thread terbolous
Github user terbolous commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/699#discussion_r37388778 --- Diff: client/WEB-INF/classes/resources/messages_es.properties --- @@ -808,7 +808,7 @@ label.skip.guide=He utilizado CloudStack anteriormente

[GitHub] cloudstack pull request: Update L10N resource files on 4.5 branch ...

2015-08-14 Thread terbolous
Github user terbolous commented on the pull request: https://github.com/apache/cloudstack/pull/697#issuecomment-131095612 label.local.storage.enabled is removed from multiple languages, but added to one. Is that right? --- If your project is set up for it, you can reply to this

[GitHub] cloudstack pull request: CLOUDSTACK-8457: SAML auth plugin improve...

2015-06-25 Thread terbolous
Github user terbolous commented on the pull request: https://github.com/apache/cloudstack/pull/489#issuecomment-115305839 Excellent, let me know when you consider it ready and I'll give it a spin. Erik Den torsdag 25. juni 2015 skrev Rohit Yadav føl

[GitHub] cloudstack pull request: CLOUDSTACK-8457: SAML auth plugin improve...

2015-06-25 Thread terbolous
Github user terbolous commented on the pull request: https://github.com/apache/cloudstack/pull/489#issuecomment-115259844 I can test your changes against ADFS if you want to, not sure if I can find time this week though. --- If your project is set up for it, you can reply to this

[GitHub] cloudstack pull request: As an operator I want to be able to chang...

2015-06-25 Thread terbolous
Github user terbolous commented on the pull request: https://github.com/apache/cloudstack/pull/527#issuecomment-115251794 Excellent, thanks :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cloudstack pull request: As an operator I want to be able to chang...

2015-06-25 Thread terbolous
Github user terbolous commented on the pull request: https://github.com/apache/cloudstack/pull/527#issuecomment-115249502 Would it be too much to ask for a corresponding Jira ticket? Definitely makes it easier to track changes when writing release notes :-) --- If your project is

[GitHub] cloudstack-docs-rn pull request: Update with 4.4.4 notes

2015-06-25 Thread terbolous
Github user terbolous commented on the pull request: https://github.com/apache/cloudstack-docs-rn/pull/23#issuecomment-115131799 @runseb or @pdion891 you care to take a look? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack-docs-rn pull request: Update with 4.4.4 notes

2015-06-24 Thread terbolous
GitHub user terbolous opened a pull request: https://github.com/apache/cloudstack-docs-rn/pull/23 Update with 4.4.4 notes Many chances I might have missed or did something wrong, so please review You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cloudstack pull request: CLOUDSTACK-8455: Use the correct label to...

2015-06-17 Thread terbolous
GitHub user terbolous opened a pull request: https://github.com/apache/cloudstack/pull/471 CLOUDSTACK-8455: Use the correct label to display extractable checkbox Simple fix to use the appropriate label name You can merge this pull request into a Git repository by running

[GitHub] cloudstack pull request: Embedded Tomcat & Jetty

2015-06-09 Thread terbolous
Github user terbolous commented on the pull request: https://github.com/apache/cloudstack/pull/372#issuecomment-110320351 Thanks @rsafonseca, your efforts are well appreciated, don't think otherwise. Small changes equals, atleast usually, a smaller set of testing.

[GitHub] cloudstack pull request: Embedded Tomcat & Jetty

2015-06-09 Thread terbolous
Github user terbolous commented on the pull request: https://github.com/apache/cloudstack/pull/372#issuecomment-110257923 I'm with Wilder & co on this. If you break it down, it's easier to test and thus merge. For instance, the mysql licensing could n

[GitHub] cloudstack pull request: Embedded Tomcat & Jetty

2015-06-08 Thread terbolous
Github user terbolous commented on the pull request: https://github.com/apache/cloudstack/pull/372#issuecomment-110145052 By the way, what kind of testing has this undergone? In particular I'm interested in upgrade testing, as we don't want to break any old installations

[GitHub] cloudstack pull request: Embedded Tomcat & Jetty

2015-06-08 Thread terbolous
Github user terbolous commented on the pull request: https://github.com/apache/cloudstack/pull/372#issuecomment-110144112 I'm by no means an expert on this, but isn't the reason we didn't ship the mysql connector previously due to licensing? @ke4qqq or @runseb wanna chi

[GitHub] cloudstack pull request: verifying template creation permission ba...

2015-05-28 Thread terbolous
Github user terbolous commented on the pull request: https://github.com/apache/cloudstack/pull/153#issuecomment-106607317 @gauravaradhye is this something you could take a look at? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack pull request: Fixed yum and apt repo locations used by ...

2015-05-28 Thread terbolous
Github user terbolous commented on the pull request: https://github.com/apache/cloudstack/pull/323#issuecomment-106591169 LGTM. @bhaisaab You might want to change this back when/if the testing repo comes back? --- If your project is set up for it, you can reply to this email and

[GitHub] cloudstack pull request: Reinstate working sessions in browser

2015-05-26 Thread terbolous
Github user terbolous commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/308#discussion_r31083230 --- Diff: ui/scripts/cloudStack.js --- @@ -329,7 +325,6 @@ g_regionsecondaryenabled = null

[GitHub] cloudstack pull request: CLOUDSTACK-8339: Allow non-root users to ...

2015-05-24 Thread terbolous
Github user terbolous commented on the pull request: https://github.com/apache/cloudstack/pull/288#issuecomment-105076586 On Mon, May 25, 2015 at 12:50 AM, Rafael da Fonseca < notificati...@github.com> wrote: > Creating a user for this use would be worse, because

[GitHub] cloudstack pull request: CLOUDSTACK-8339: Allow non-root users to ...

2015-05-24 Thread terbolous
Github user terbolous commented on the pull request: https://github.com/apache/cloudstack/pull/288#issuecomment-105064856 Why don't we make a dedicated user (be it 'cloud' or anything) during agent install time? Makes a lot more sense to me, than relying

[GitHub] cloudstack pull request: WIP: affinitygroup: implement project sup...

2015-05-19 Thread terbolous
Github user terbolous commented on the pull request: https://github.com/apache/cloudstack/pull/264#issuecomment-103669243 Been waiting for this! Lack of affinity groups in projects is one of the main reason we don't use them (projects). thank you! --- If your project i

[GitHub] cloudstack pull request: CLOUDSTACK-8301: Enable configuring local...

2015-05-19 Thread terbolous
Github user terbolous commented on the pull request: https://github.com/apache/cloudstack/pull/259#issuecomment-103450660 I'm a bit unsure of how our i18n process is, but should this message be applied to language files (ie. messages_*.properties) as well? --- If your project i

[GitHub] cloudstack pull request: Implementation for the ability to disable...

2015-05-19 Thread terbolous
Github user terbolous commented on the pull request: https://github.com/apache/cloudstack/pull/257#issuecomment-103403115 Excellent, thanks for the update. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack pull request: Implementation for the ability to disable...

2015-05-18 Thread terbolous
Github user terbolous commented on the pull request: https://github.com/apache/cloudstack/pull/257#issuecomment-103369983 I love this feature! Is there a related Jira issue and/or FS spec for it? What happens if a user tries to resize a volume that resides on a disabled

[GitHub] cloudstack pull request: Build and create tomcat, fix several othe...

2015-05-13 Thread terbolous
Github user terbolous commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/238#discussion_r30280222 --- Diff: packaging/package.sh --- @@ -48,6 +48,13 @@ function packaging() { fi DISTRO=$3 + +JDK=$(rpm -qa | grep

[GitHub] cloudstack pull request: Build and create tomcat, fix several othe...

2015-05-13 Thread terbolous
Github user terbolous commented on the pull request: https://github.com/apache/cloudstack/pull/238#issuecomment-101825246 Getting this: [root@jenkins packaging]# bash package.sh -d centos63 -d centos63 -- 7 java-1.x.0-jdk-devel 1.7.0+ not found\n Cannot retrieve

[GitHub] cloudstack pull request:

2015-05-12 Thread terbolous
Github user terbolous commented on the pull request: https://github.com/apache/cloudstack/commit/58999daafe862ebbe953903ce7f928939c9b85f0#commitcomment-11161993 In packaging/centos63/cloud.spec: In packaging/centos63/cloud.spec on line 363: This removed commons

[GitHub] cloudstack pull request: CLOUDSTACK-1667: Make a better descriptio...

2015-05-12 Thread terbolous
GitHub user terbolous opened a pull request: https://github.com/apache/cloudstack/pull/245 CLOUDSTACK-1667: Make a better description of the extractable flag The extractable flag is a bit confusing, as it is easy to imply some sort of extraction (zip, bzip2, gzip etc.) support

[GitHub] cloudstack pull request: tool to aid db comaprision for upgrade te...

2015-04-23 Thread terbolous
Github user terbolous commented on the pull request: https://github.com/apache/cloudstack/pull/188#issuecomment-95821124 Shouldn't the files have licensing information in them? --- If your project is set up for it, you can reply to this email and have your reply appear on GitH

[GitHub] cloudstack pull request: Upgrades from 4.4: disable foreign key ch...

2015-04-13 Thread terbolous
Github user terbolous commented on the pull request: https://github.com/apache/cloudstack/pull/164#issuecomment-92511037 4.5.0 is already released, although not announced, should we then change files in that version? What is the consequence of moving this to the 4.5.1 upgrade scripts

[GitHub] cloudstack-docs pull request: Fixed the description of the attachi...

2015-03-02 Thread terbolous
Github user terbolous commented on the pull request: https://github.com/apache/cloudstack-docs/pull/9#issuecomment-76901559 Would you mind updating the new administration docs? The relevant section should be in https://github.com/apache/cloudstack-docs-admin/blob/master/source

[GitHub] cloudstack pull request:

2015-02-24 Thread terbolous
Github user terbolous commented on the pull request: https://github.com/apache/cloudstack/commit/0c0c7dd070c146e2f55bfe6a3cebf3ced115690f#commitcomment-9901732 Looks like a bad backport of https://github.com/apache/cloudstack/commit/c368d3b6eeb41efe508bb0d3e0abe3a4ca5bb8e2

[GitHub] cloudstack pull request: CLOUDSTACK-8215: SAML changing date calcu...

2015-02-05 Thread terbolous
Github user terbolous commented on the pull request: https://github.com/apache/cloudstack/pull/71#issuecomment-73025102 I agree with you :-) I didn't know we had Joda DateTime available, and with my limited Java experience I didn't want to head out on the journey to in

[GitHub] cloudstack pull request: CLOUDSTACK-8215: SAML changing date calcu...

2015-02-05 Thread terbolous
GitHub user terbolous opened a pull request: https://github.com/apache/cloudstack/pull/71 CLOUDSTACK-8215: SAML changing date calculation Changed to java.util.Calendar which is a bit more straight forward to use. Tested and verified that the new certificate is valid for 3

[GitHub] cloudstack pull request: CLOUDSTACK-8157: Add absolute schema refe...

2015-01-14 Thread terbolous
Github user terbolous commented on the pull request: https://github.com/apache/cloudstack/pull/67#issuecomment-69927499 Yes, that would also work. I considered it, but since the file works with both cloud and cloud_usage I wasn --- If your project is set up for it, you can reply to

[GitHub] cloudstack pull request: CLOUDSTACK-8157: Add absolute schema refe...

2015-01-14 Thread terbolous
GitHub user terbolous opened a pull request: https://github.com/apache/cloudstack/pull/67 CLOUDSTACK-8157: Add absolute schema references to support MySQL 5.6 better This should fix the problem some people are seeing with cloudstack-setup-databases complaining about 'No dat

[GitHub] cloudstack-docs-install pull request: added -f and a note about en...

2014-12-15 Thread terbolous
Github user terbolous commented on the pull request: https://github.com/apache/cloudstack-docs-install/pull/19#issuecomment-66980759 @hannibal20 Thank you for your contribution, your patch has been merged to all branches --- If your project is set up for it, you can reply to this

[GitHub] cloudstack-docs-install pull request: added -f and a note about en...

2014-12-15 Thread terbolous
Github user terbolous commented on the pull request: https://github.com/apache/cloudstack-docs-install/pull/19#issuecomment-66961199 I did, lets hope I did it right :-) @runseb or @pdion891 (or anyone else): do you think this should be applied to 4.4/4.3 branches as well

[GitHub] cloudstack-docs-install pull request: added -f and a note about en...

2014-12-14 Thread terbolous
Github user terbolous commented on the pull request: https://github.com/apache/cloudstack-docs-install/pull/19#issuecomment-66924638 Looks good to me --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack-docs-install pull request: Updated systemvm template pa...

2014-08-24 Thread terbolous
Github user terbolous closed the pull request at: https://github.com/apache/cloudstack-docs-install/pull/18 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cloudstack-docs-admin pull request: CLOUDSTACK-5879: Updated rabbi...

2014-08-20 Thread terbolous
Github user terbolous closed the pull request at: https://github.com/apache/cloudstack-docs-admin/pull/16 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

  1   2   >