Github user terbolous commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/872#discussion_r48824088
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/configure.py ---
@@ -479,13 +479,13 @@ def process(self):
def deletevpn(self, ip):
logging.info("Removing VPN configuration for %s", ip)
- CsHelper.execute("ipsec auto --down vpn-%s" % ip)
- CsHelper.execute("ipsec auto --delete vpn-%s" % ip)
+ CsHelper.execute("ipsec down vpn-%s" % ip)
+ CsHelper.execute("ipsec down vpn-%s" % ip)
--- End diff --
Thanks for the explanation @jayapalu
I have tested this manually on a 4.5.2 installation by backporting the
scripts directly inside a VR and can say that it fundamentally works. Not sure
if I have time to spin up a new setup before freeze though.
All in all it LGTM, but I would want someone with a more extensive test
than myself to vouch as well
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
