Github user rodrigo93 commented on the pull request:
https://github.com/apache/cloudstack/pull/1557#issuecomment-222007302
Hello again @rafaelweingartner,
I did as you suggested. I also checked that the variable **file** was not
used anywhere else besides lines 60 - 76, so I also
Github user rodrigo93 commented on the pull request:
https://github.com/apache/cloudstack/pull/1557#issuecomment-221426317
Hi @rafaelweingartner ,
Thanks for the advice. I will take a look on that and do the proper changes
as soon as I can.
---
If your project is set up for it
GitHub user rodrigo93 opened a pull request:
https://github.com/apache/cloudstack/pull/1557
Removed unused methods from XenServerConnectionPool
Removed the following methods that are unused from the class
_com.cloud.hypervisor.xenserver.resource.XenServerConnectionPool_
Github user rodrigo93 commented on the pull request:
https://github.com/apache/cloudstack/pull/1440#issuecomment-220795597
Thanks for the help! =)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user rodrigo93 commented on the pull request:
https://github.com/apache/cloudstack/pull/1439#issuecomment-197832134
Sorry for the delay to answer.
Hi @rafaelweingartner , thanks for the suggestion. I will revise my PR and
do the proper changes.
@syed I am not sure
Github user rodrigo93 commented on the pull request:
https://github.com/apache/cloudstack/pull/1439#issuecomment-196020657
Squashed last 2 commits.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
GitHub user rodrigo93 opened a pull request:
https://github.com/apache/cloudstack/pull/1440
Removed Unused Void Class
Removed the class _Void.java_ from
_/cloud-framework-ipc/src/org/apache/cloudstack/framework/async/Void.java_
since the method _public void AsyncMethod(Object
GitHub user rodrigo93 opened a pull request:
https://github.com/apache/cloudstack/pull/1439
Changed Void Methods to void
I have changed many "Void" methods to "void" since they have to return
null at the end and it has the same effect of "void" met
Github user rodrigo93 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/798#discussion_r53253724
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java
---
@@ -1464,4 +1440,45 @@ private String
Github user rodrigo93 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/798#discussion_r53048362
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java
---
@@ -1464,4 +1440,45 @@ private String
Github user rodrigo93 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/798#discussion_r53047922
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java
---
@@ -1464,4 +1440,45 @@ private String
Github user rodrigo93 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/625#discussion_r53039381
--- Diff: server/src/org/apache/cloudstack/report/AtomicGsonAdapter.java ---
@@ -0,0 +1,48 @@
+// Licensed to the Apache Software Foundation (ASF
Github user rodrigo93 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r53033391
--- Diff:
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
---
@@ -172,6 +195,12 @@ private
Github user rodrigo93 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r52845493
--- Diff:
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
---
@@ -172,6 +195,12 @@ private
Github user rodrigo93 commented on the pull request:
https://github.com/apache/cloudstack/pull/556#issuecomment-183909796
Could someone put this PR to test again? If it fails, it could be closed
since the author seems to be inactive on github since September of the last
year and the
Github user rodrigo93 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1410#discussion_r52655615
--- Diff:
engine/orchestration/src/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java
---
@@ -1054,9 +1075,28 @@ public void
Github user rodrigo93 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1320#discussion_r52106924
--- Diff: ui/scripts/instanceWizard.js ---
@@ -294,53 +295,67 @@
// Step 3: Service offering
function(args
Github user rodrigo93 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/837#discussion_r52094072
--- Diff: server/src/com/cloud/resource/ResourceManagerImpl.java ---
@@ -1148,15 +1148,16 @@ public Host cancelMaintenance(final
CancelMaintenanceCmd
Github user rodrigo93 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/837#discussion_r52093680
--- Diff:
engine/orchestration/src/com/cloud/agent/manager/AgentManagerImpl.java ---
@@ -971,33 +971,28 @@ public Answer easySend(final Long hostId
Github user rodrigo93 commented on the pull request:
https://github.com/apache/cloudstack/pull/1360#issuecomment-178002003
@GabrielBrascher @ProjectMoon, You are right. I thought I saw a some
section in Jira for minor improvements, but I was wrong. Besides that, the code
and work
Github user rodrigo93 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/672#discussion_r51428218
--- Diff:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
---
@@ -4251,6 +4257,34 @@ public void
Github user rodrigo93 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/672#discussion_r51367120
--- Diff:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
---
@@ -4251,6 +4257,34 @@ public void
Github user rodrigo93 commented on the pull request:
https://github.com/apache/cloudstack/pull/1360#issuecomment-177348201
Hi @ProjectMoon,
What a great work you did here.
Splitting the PR in two seems a good idea, in my point of view, since you
create two tests cases for
Github user rodrigo93 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/672#discussion_r51352994
--- Diff:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
---
@@ -4251,6 +4257,34 @@ public void
Github user rodrigo93 commented on the pull request:
https://github.com/apache/cloudstack/pull/969#issuecomment-177281584
Thanks @bhaisaab !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user rodrigo93 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1257#discussion_r50639477
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java
---
@@ -138,6 +142,8 @@
@Inject
Github user rodrigo93 commented on the pull request:
https://github.com/apache/cloudstack/pull/1362#issuecomment-174323189
@remibergsma Very nice! I have that problem as well while using ACS. =~
LGTM based on screenshots and code.
---
If your project is set up for it, you
Github user rodrigo93 commented on the pull request:
https://github.com/apache/cloudstack/pull/566#issuecomment-174322999
Why does this PR still open? Shouldn't be closed? Seems that has been
resolved already...
---
If your project is set up for it, you can reply to this emai
Github user rodrigo93 commented on the pull request:
https://github.com/apache/cloudstack/pull/1271#issuecomment-174322677
I tested it in my Firefox and it does exactly as @anshul1886 says. Instead
of sending the command to the VM, firefox opens the search tool.
Can anybody test
Github user rodrigo93 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1148#discussion_r50638624
--- Diff:
plugins/network-elements/juniper-srx/src/com/cloud/network/resource/JuniperSrxResource.java
---
@@ -2841,8 +2841,9 @@ private boolean
Github user rodrigo93 commented on the pull request:
https://github.com/apache/cloudstack/pull/1148#issuecomment-174321124
Hi @wenwenxiong, could you make a Jira for this PR?
Did you make any test?
---
If your project is set up for it, you can reply to this email and have your
Github user rodrigo93 commented on the pull request:
https://github.com/apache/cloudstack/pull/827#issuecomment-172394161
Hi @yvsubhash, could you make a Jira?
Sorry to ask you, but, why did you remove the tries and catches? It should
throw exceptions if that part of the code can
Github user rodrigo93 commented on the pull request:
https://github.com/apache/cloudstack/pull/969#issuecomment-172391494
@DaanHoogland I see... Well, thanks for your effort on helping in this PR.
:)
---
If your project is set up for it, you can reply to this email and have your
Github user rodrigo93 commented on the pull request:
https://github.com/apache/cloudstack/pull/914#issuecomment-172391340
@remibergsma The author seems to be inactive in github. His last public
activity was on Oct 20, 2015...
---
If your project is set up for it, you can reply to
Github user rodrigo93 commented on the pull request:
https://github.com/apache/cloudstack/pull/1238#issuecomment-172384379
LGTM based on the files, no tests were made.
What is happening with Jenkins? I noticed that many PRs are flagged with
error because Jenkins did not work
Github user rodrigo93 commented on the pull request:
https://github.com/apache/cloudstack/pull/1261#issuecomment-172383990
LGMT. Can I give you a suggestion? You could remove those variable
initializing with "_" (underscore) seems that is a common practice in C++
p
Github user rodrigo93 commented on the pull request:
https://github.com/apache/cloudstack/pull/1263#issuecomment-172383741
@GabrielBrascher Nice change. It is always good to keep the good
programming practices, especially in a project of this size.
Can you commit it again? It
Github user rodrigo93 commented on the pull request:
https://github.com/apache/cloudstack/pull/969#issuecomment-172028230
Hmmm, interesting... Did you know what exactly was causing that error?
@DaanHoogland
---
If your project is set up for it, you can reply to this email and have
Github user rodrigo93 commented on the pull request:
https://github.com/apache/cloudstack/pull/969#issuecomment-171442487
Thanks @DaanHoogland !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user rodrigo93 commented on the pull request:
https://github.com/apache/cloudstack/pull/1238#issuecomment-171046691
Nice @borisroman, can you send it to test it again?
It seems that Jenkins is not working...
---
If your project is set up for it, you can reply to this email
Github user rodrigo93 commented on the pull request:
https://github.com/apache/cloudstack/pull/969#issuecomment-170626131
I agree with @rafaelweingartner, since we can check that in last lines.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user rodrigo93 commented on the pull request:
https://github.com/apache/cloudstack/pull/969#issuecomment-170394300
Alright @DaanHoogland. Thanks for the help! =)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user rodrigo93 commented on the pull request:
https://github.com/apache/cloudstack/pull/1252#issuecomment-170381257
@DaanHoogland I see... With that option in settings, things could be more
manageable. That is a good suggestion.
---
If your project is set up for it, you can
Github user rodrigo93 commented on the pull request:
https://github.com/apache/cloudstack/pull/969#issuecomment-170379092
That's ok @DaanHoogland, don't need to hurry.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub a
Github user rodrigo93 commented on the pull request:
https://github.com/apache/cloudstack/pull/1252#issuecomment-170130323
Did someone tested it? This can be very handy.
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user rodrigo93 commented on the pull request:
https://github.com/apache/cloudstack/pull/943#issuecomment-170073454
Many thanks for the help everyone!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user rodrigo93 commented on the pull request:
https://github.com/apache/cloudstack/pull/969#issuecomment-170073320
Hello everyone. Sorry to bother you but, how are the tests going?
Is there anything else that I can do?
---
If your project is set up for it, you can reply to
Github user rodrigo93 commented on the pull request:
https://github.com/apache/cloudstack/pull/943#issuecomment-160714102
@DaanHoogland Can you tell us where the conflict is? It seems ok to me.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user rodrigo93 commented on the pull request:
https://github.com/apache/cloudstack/pull/943#issuecomment-160323858
Hi guys.
Sorry for the delay. Thank you all for helping me out. I had some personal
problems.
My bad.
Thanks once again! I hope this commit will help
Github user rodrigo93 commented on the pull request:
https://github.com/apache/cloudstack/pull/969#issuecomment-160323830
Hi guys.
Sorry for the delay. Thank you all for helping me out. I had some personal
problems.
My bad.
Thanks once again! I hope this commit will help
Github user rodrigo93 commented on the pull request:
https://github.com/apache/cloudstack/pull/969#issuecomment-158792594
Hi @remibergsma. I am trying to fix it to put all in one commit. I have
force pushed already, but it seems that it does no work. I have tried to squash
them, but
Github user rodrigo93 commented on the pull request:
https://github.com/apache/cloudstack/pull/943#issuecomment-158790894
Hi @remibergsma. Thanks for the reminding! I was merging that commit with
that actual master and I forgot to put the title in the commit.
I have fixed that
Github user rodrigo93 commented on the pull request:
https://github.com/apache/cloudstack/pull/943#issuecomment-158671944
PR merged with master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user rodrigo93 commented on the pull request:
https://github.com/apache/cloudstack/pull/969#issuecomment-158671871
Just to update, I merged the commit with master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user rodrigo93 commented on the pull request:
https://github.com/apache/cloudstack/pull/943#issuecomment-151547183
@remibergsma I see. Next time I will try to rebase it with master before
commiting.
---
If your project is set up for it, you can reply to this email and have
Github user rodrigo93 commented on the pull request:
https://github.com/apache/cloudstack/pull/943#issuecomment-151206169
Hi @remibergsma, the files that I am changing were not altered in the
current master. Why do we need to rebase?
Thanks for your time.
---
If your project is
Github user rodrigo93 commented on the pull request:
https://github.com/apache/cloudstack/pull/969#issuecomment-151204587
.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user rodrigo93 reopened a pull request:
https://github.com/apache/cloudstack/pull/969
Fixed return type Void to void in DataMotionStrategy.
The main changes are:
- Changing methods âVoidâ to âvoidâ.
- Removal of the method âVoid copyAsync(DataObject
Github user rodrigo93 closed the pull request at:
https://github.com/apache/cloudstack/pull/969
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user rodrigo93 commented on the pull request:
https://github.com/apache/cloudstack/pull/943#issuecomment-150824034
Hi @remibergsma, thanks for the advice!
I have changed the title of the last commit already as you both suggest.
I will provide a JIRA issue and prepend
Github user rodrigo93 commented on the pull request:
https://github.com/apache/cloudstack/pull/943#issuecomment-150744688
@borisroman Hi borisroman, sure! What about this one?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
GitHub user rodrigo93 opened a pull request:
https://github.com/apache/cloudstack/pull/969
Fixed return type Void to void in DataMotionStrategy.
The main changes are:
- Changing methods âVoidâ to âvoidâ.
- Removal of the method âVoid copyAsync(DataObject
Github user rodrigo93 commented on the pull request:
https://github.com/apache/cloudstack/pull/943#issuecomment-149059531
@rafaelweingartner Thanks for the advice! I am squashing them right now. I
will commit again as soon as possible.
---
If your project is set up for it, you can
GitHub user rodrigo93 opened a pull request:
https://github.com/apache/cloudstack/pull/943
Removed unused adapters from async-job-component.xml.
I was looking the file /cloud-server/test/async-job-component.xml, and I
found an adapter configuration that seems to have no use. The
GitHub user rodrigo93 opened a pull request:
https://github.com/apache/cloudstack/pull/854
Fixed return type Void to void in DataMotionStrategy.
The main changes are:
- Changing methods âVoidâ to âvoidâ.
- Removal of the method âVoid copyAsync(DataObject
65 matches
Mail list logo
